[kudu-CR] KUDU-2587: support conditional update feature
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14377 to look at the new patch set (#4). Change subject: KUDU-2587: support conditional update feature .. KUDU-2587: support conditional update feature Change-Id: Ieebe6c7ece67e723c179a4c16444b59a63aa4612 --- M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java M java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java M java/kudu-client/src/main/java/org/apache/kudu/client/KuduSession.java M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java M java/kudu-client/src/main/java/org/apache/kudu/client/SessionConfiguration.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java A java/kudu-client/src/test/java/org/apache/kudu/client/TestConditionalUpdate.java M src/kudu/client/schema-internal.h M src/kudu/client/schema.cc M src/kudu/client/schema.h M src/kudu/common/common.proto M src/kudu/common/row_changelist.cc M src/kudu/common/row_changelist.h M src/kudu/common/row_operations-test.cc M src/kudu/common/row_operations.cc M src/kudu/common/row_operations.h M src/kudu/common/schema.cc M src/kudu/common/schema.h M src/kudu/common/wire_protocol.cc M src/kudu/consensus/log-test.cc M src/kudu/master/catalog_manager.cc M src/kudu/tablet/all_types-scan-correctness-test.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/delta_stats.cc M src/kudu/tablet/delta_store.cc M src/kudu/tablet/delta_store.h M src/kudu/tablet/deltamemstore-test.cc M src/kudu/tablet/diskrowset-test-base.h M src/kudu/tablet/diskrowset-test.cc M src/kudu/tablet/memrowset-test.cc M src/kudu/tablet/memrowset.cc M src/kudu/tablet/tablet-decoder-eval-test.cc M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet.cc M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/tool_action_common.cc M src/kudu/tserver/tserver.proto 41 files changed, 1,603 insertions(+), 70 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/14377/4 -- To view, visit http://gerrit.cloudera.org:8080/14377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ieebe6c7ece67e723c179a4c16444b59a63aa4612 Gerrit-Change-Number: 14377 Gerrit-PatchSet: 4 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-2587: support conditional update feature
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14377 to look at the new patch set (#3). Change subject: KUDU-2587: support conditional update feature .. KUDU-2587: support conditional update feature Change-Id: Ieebe6c7ece67e723c179a4c16444b59a63aa4612 --- M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java M java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java M java/kudu-client/src/main/java/org/apache/kudu/client/KuduSession.java M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java M java/kudu-client/src/main/java/org/apache/kudu/client/SessionConfiguration.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java A java/kudu-client/src/test/java/org/apache/kudu/client/TestConditionalUpdate.java M src/kudu/client/schema-internal.h M src/kudu/client/schema.cc M src/kudu/client/schema.h M src/kudu/common/common.proto M src/kudu/common/row_changelist.cc M src/kudu/common/row_changelist.h M src/kudu/common/row_operations-test.cc M src/kudu/common/row_operations.cc M src/kudu/common/row_operations.h M src/kudu/common/schema.cc M src/kudu/common/schema.h M src/kudu/common/wire_protocol.cc M src/kudu/consensus/log-test.cc M src/kudu/master/catalog_manager.cc M src/kudu/tablet/all_types-scan-correctness-test.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/delta_stats.cc M src/kudu/tablet/delta_store.cc M src/kudu/tablet/delta_store.h M src/kudu/tablet/deltamemstore-test.cc M src/kudu/tablet/diskrowset-test-base.h M src/kudu/tablet/diskrowset-test.cc M src/kudu/tablet/memrowset-test.cc M src/kudu/tablet/memrowset.cc M src/kudu/tablet/tablet-decoder-eval-test.cc M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet.cc M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/tool_action_common.cc M src/kudu/tserver/tserver.proto 41 files changed, 1,610 insertions(+), 70 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/14377/3 -- To view, visit http://gerrit.cloudera.org:8080/14377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ieebe6c7ece67e723c179a4c16444b59a63aa4612 Gerrit-Change-Number: 14377 Gerrit-PatchSet: 3 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-2587: support conditional update feature
Hello Tidy Bot, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14377 to look at the new patch set (#2). Change subject: KUDU-2587: support conditional update feature .. KUDU-2587: support conditional update feature Change-Id: Ieebe6c7ece67e723c179a4c16444b59a63aa4612 --- M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java M java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java M java/kudu-client/src/main/java/org/apache/kudu/client/KuduSession.java M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java M java/kudu-client/src/main/java/org/apache/kudu/client/SessionConfiguration.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java A java/kudu-client/src/test/java/org/apache/kudu/client/TestConditionalUpdate.java M src/kudu/client/schema-internal.h M src/kudu/client/schema.cc M src/kudu/client/schema.h M src/kudu/common/common.proto M src/kudu/common/row_changelist.cc M src/kudu/common/row_changelist.h M src/kudu/common/row_operations-test.cc M src/kudu/common/row_operations.cc M src/kudu/common/row_operations.h M src/kudu/common/schema.cc M src/kudu/common/schema.h M src/kudu/common/wire_protocol.cc M src/kudu/consensus/log-test.cc M src/kudu/master/catalog_manager.cc M src/kudu/tablet/all_types-scan-correctness-test.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/delta_stats.cc M src/kudu/tablet/delta_store.cc M src/kudu/tablet/delta_store.h M src/kudu/tablet/deltamemstore-test.cc M src/kudu/tablet/diskrowset-test-base.h M src/kudu/tablet/diskrowset-test.cc M src/kudu/tablet/memrowset-test.cc M src/kudu/tablet/memrowset.cc M src/kudu/tablet/tablet-decoder-eval-test.cc M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet.cc M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/tool_action_common.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tserver.proto 42 files changed, 1,589 insertions(+), 69 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/14377/2 -- To view, visit http://gerrit.cloudera.org:8080/14377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ieebe6c7ece67e723c179a4c16444b59a63aa4612 Gerrit-Change-Number: 14377 Gerrit-PatchSet: 2 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] KUDU-2587: support conditional update feature
XiaokaiWang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14377 Change subject: KUDU-2587: support conditional update feature .. KUDU-2587: support conditional update feature Change-Id: Ieebe6c7ece67e723c179a4c16444b59a63aa4612 --- M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java M java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java M java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java M java/kudu-client/src/main/java/org/apache/kudu/client/KuduSession.java M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java M java/kudu-client/src/main/java/org/apache/kudu/client/ProtobufHelper.java M java/kudu-client/src/main/java/org/apache/kudu/client/SessionConfiguration.java M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java A java/kudu-client/src/test/java/org/apache/kudu/client/TestConditionalUpdate.java M src/kudu/client/schema-internal.h M src/kudu/client/schema.cc M src/kudu/client/schema.h M src/kudu/common/common.proto M src/kudu/common/row_changelist.cc M src/kudu/common/row_changelist.h M src/kudu/common/row_operations-test.cc M src/kudu/common/row_operations.cc M src/kudu/common/row_operations.h M src/kudu/common/schema.cc M src/kudu/common/schema.h M src/kudu/common/wire_protocol.cc M src/kudu/consensus/log-test.cc M src/kudu/master/catalog_manager.cc M src/kudu/tablet/all_types-scan-correctness-test.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction.cc M src/kudu/tablet/delta_stats.cc M src/kudu/tablet/delta_store.cc M src/kudu/tablet/delta_store.h M src/kudu/tablet/deltamemstore-test.cc M src/kudu/tablet/diskrowset-test-base.h M src/kudu/tablet/diskrowset-test.cc M src/kudu/tablet/memrowset-test.cc M src/kudu/tablet/memrowset.cc M src/kudu/tablet/tablet-decoder-eval-test.cc M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet.cc M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/tool_action_common.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tserver.proto 42 files changed, 1,586 insertions(+), 66 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/14377/1 -- To view, visit http://gerrit.cloudera.org:8080/14377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ieebe6c7ece67e723c179a4c16444b59a63aa4612 Gerrit-Change-Number: 14377 Gerrit-PatchSet: 1 Gerrit-Owner: XiaokaiWang
[kudu-CR] docs: correct invalid link about schema design
XiaokaiWang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14028 ) Change subject: docs: correct invalid link about schema_design .. Patch Set 2: > I see. It looks like there is a correct way to handle this so it > works in github and on the official site too. > > The Impala page has an example of this for the HMS integration: > https://github.com/apache/kudu/blob/master/docs/kudu_impala_integration.adoc > > See < documentation>> for more details Hello Grant. Updated, please have a look. -- To view, visit http://gerrit.cloudera.org:8080/14028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41e8671f518bb898dd357dc5024a7d8ab335b401 Gerrit-Change-Number: 14028 Gerrit-PatchSet: 2 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: XiaokaiWang Gerrit-Comment-Date: Fri, 16 Aug 2019 16:20:16 + Gerrit-HasComments: No
[kudu-CR] docs: correct invalid link about schema design
Hello Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14028 to look at the new patch set (#2). Change subject: docs: correct invalid link about schema_design .. docs: correct invalid link about schema_design Change-Id: I41e8671f518bb898dd357dc5024a7d8ab335b401 --- M docs/index.adoc M docs/known_issues.adoc M docs/kudu_impala_integration.adoc M docs/prior_release_notes.adoc 4 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/14028/2 -- To view, visit http://gerrit.cloudera.org:8080/14028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I41e8671f518bb898dd357dc5024a7d8ab335b401 Gerrit-Change-Number: 14028 Gerrit-PatchSet: 2 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: XiaokaiWang
[kudu-CR] docs: correct invalid link
XiaokaiWang has posted comments on this change. ( http://gerrit.cloudera.org:8080/14028 ) Change subject: docs: correct invalid link .. Patch Set 1: > (1 comment) Hello Grant. Sorry for the late reply. I saw it from here: https://github.com/apache/kudu/blob/master/docs/schema_design.html -- To view, visit http://gerrit.cloudera.org:8080/14028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41e8671f518bb898dd357dc5024a7d8ab335b401 Gerrit-Change-Number: 14028 Gerrit-PatchSet: 1 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: XiaokaiWang Gerrit-Comment-Date: Thu, 15 Aug 2019 03:55:02 + Gerrit-HasComments: No
[kudu-CR] docs: correct invalid link
XiaokaiWang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14028 Change subject: docs: correct invalid link .. docs: correct invalid link Change-Id: I41e8671f518bb898dd357dc5024a7d8ab335b401 --- M docs/known_issues.adoc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/14028/1 -- To view, visit http://gerrit.cloudera.org:8080/14028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I41e8671f518bb898dd357dc5024a7d8ab335b401 Gerrit-Change-Number: 14028 Gerrit-PatchSet: 1 Gerrit-Owner: XiaokaiWang
[kudu-CR] testcase: TestTSRegisters adds ts seqno checking after ts restarts
XiaokaiWang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13988 ) Change subject: testcase: TestTSRegisters adds ts seqno checking after ts restarts .. Patch Set 2: > (1 comment) Changed it back. Thanks. -- To view, visit http://gerrit.cloudera.org:8080/13988 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic46674c007be05057c0ef614dc097e44b2acf303 Gerrit-Change-Number: 13988 Gerrit-PatchSet: 2 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: XiaokaiWang Gerrit-Comment-Date: Sat, 03 Aug 2019 01:51:44 + Gerrit-HasComments: No
[kudu-CR] testcase: TestTSRegisters adds ts seqno checking after ts restarts
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13988 to look at the new patch set (#2). Change subject: testcase: TestTSRegisters adds ts seqno checking after ts restarts .. testcase: TestTSRegisters adds ts seqno checking after ts restarts Change-Id: Ic46674c007be05057c0ef614dc097e44b2acf303 --- M src/kudu/integration-tests/registration-test.cc 1 file changed, 15 insertions(+), 4 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/13988/2 -- To view, visit http://gerrit.cloudera.org:8080/13988 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic46674c007be05057c0ef614dc097e44b2acf303 Gerrit-Change-Number: 13988 Gerrit-PatchSet: 2 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon
[kudu-CR] testcase: with CheckRowCount instead of CheckRowCountWithRetries
Hello Kudu Jenkins, Adar Dembo, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13989 to look at the new patch set (#2). Change subject: testcase: with CheckRowCount instead of CheckRowCountWithRetries .. testcase: with CheckRowCount instead of CheckRowCountWithRetries KUDU-796 was fixed. So, we need not retries when reading after a restart. Change-Id: I0f2d535bd9519e0cdd3c4f3d63e57c5c3bb53ebd --- M src/kudu/integration-tests/cluster_verifier.cc M src/kudu/integration-tests/cluster_verifier.h M src/kudu/integration-tests/ts_recovery-itest.cc 3 files changed, 15 insertions(+), 49 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/13989/2 -- To view, visit http://gerrit.cloudera.org:8080/13989 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0f2d535bd9519e0cdd3c4f3d63e57c5c3bb53ebd Gerrit-Change-Number: 13989 Gerrit-PatchSet: 2 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon
[kudu-CR] testcase: with CheckRowCount instead of CheckRowCountWithRetries
XiaokaiWang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13989 Change subject: testcase: with CheckRowCount instead of CheckRowCountWithRetries .. testcase: with CheckRowCount instead of CheckRowCountWithRetries KUDU-796 was fixed. So, we need not retries when reading after a restart. Change-Id: I0f2d535bd9519e0cdd3c4f3d63e57c5c3bb53ebd --- M src/kudu/integration-tests/cluster_verifier.cc M src/kudu/integration-tests/cluster_verifier.h M src/kudu/integration-tests/ts_recovery-itest.cc 3 files changed, 15 insertions(+), 48 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/13989/1 -- To view, visit http://gerrit.cloudera.org:8080/13989 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I0f2d535bd9519e0cdd3c4f3d63e57c5c3bb53ebd Gerrit-Change-Number: 13989 Gerrit-PatchSet: 1 Gerrit-Owner: XiaokaiWang
[kudu-CR] testcase: TestTSRegisters adds ts seqno checking after ts restarts
XiaokaiWang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13988 Change subject: testcase: TestTSRegisters adds ts seqno checking after ts restarts .. testcase: TestTSRegisters adds ts seqno checking after ts restarts Change-Id: Ic46674c007be05057c0ef614dc097e44b2acf303 --- M src/kudu/integration-tests/registration-test.cc 1 file changed, 16 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/13988/1 -- To view, visit http://gerrit.cloudera.org:8080/13988 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic46674c007be05057c0ef614dc097e44b2acf303 Gerrit-Change-Number: 13988 Gerrit-PatchSet: 1 Gerrit-Owner: XiaokaiWang
[kudu-CR] comment: delete the outdated comment
XiaokaiWang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13917 ) Change subject: comment: delete the outdated comment .. Patch Set 1: The file 'repeatable-reads.md' is not exist now, I think it's necessary to delete the comments to avoid misleading readers. -- To view, visit http://gerrit.cloudera.org:8080/13917 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If6f1a73c19ccb250f02f3faf9993521de3a842b5 Gerrit-Change-Number: 13917 Gerrit-PatchSet: 1 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: XiaokaiWang Gerrit-Comment-Date: Thu, 25 Jul 2019 08:33:02 + Gerrit-HasComments: No
[kudu-CR] comment: delete the outdated comment
XiaokaiWang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13917 Change subject: comment: delete the outdated comment .. comment: delete the outdated comment Change-Id: If6f1a73c19ccb250f02f3faf9993521de3a842b5 --- M src/kudu/consensus/time_manager.h M src/kudu/tablet/mvcc.h 2 files changed, 0 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/13917/1 -- To view, visit http://gerrit.cloudera.org:8080/13917 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: If6f1a73c19ccb250f02f3faf9993521de3a842b5 Gerrit-Change-Number: 13917 Gerrit-PatchSet: 1 Gerrit-Owner: XiaokaiWang
[kudu-CR] [docs]: Delete invalid link
XiaokaiWang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13881 ) Change subject: [docs]: Delete invalid link .. Patch Set 1: > (1 comment) Hmm, this will return back to 'Dictionary encoding' title, but actually that is where we are reading. Is this necessary? -- To view, visit http://gerrit.cloudera.org:8080/13881 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic61282e41eb2cd6ee4371d0ca2c7e42b9ccb4ee4 Gerrit-Change-Number: 13881 Gerrit-PatchSet: 1 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: XiaokaiWang Gerrit-Reviewer: Yao Xu Gerrit-Comment-Date: Fri, 19 Jul 2019 07:20:45 + Gerrit-HasComments: No
[kudu-CR] [docs]: Delete invalid link
XiaokaiWang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13881 Change subject: [docs]: Delete invalid link .. [docs]: Delete invalid link Change-Id: Ic61282e41eb2cd6ee4371d0ca2c7e42b9ccb4ee4 --- M docs/design-docs/cfile.md 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/13881/1 -- To view, visit http://gerrit.cloudera.org:8080/13881 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ic61282e41eb2cd6ee4371d0ca2c7e42b9ccb4ee4 Gerrit-Change-Number: 13881 Gerrit-PatchSet: 1 Gerrit-Owner: XiaokaiWang
[kudu-CR] KUDU-2722 (table level): Support new 'write enabled' table extra config
XiaokaiWang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13796 ) Change subject: KUDU-2722 (table level): Support new 'write_enabled' table extra config .. Patch Set 8: > I will add some context to KUDU-2722 on why I thought partition > level support would be useful/important. That said, it sounds like > Xiaokai has a use case for table level support per our chats: > > > Sometimes qps is over 10 thousand on partly nodes, which will > cause some problem such asdisk io. We should make sure that the > table of important task can be writed normally, so we will make the > not much important table's write is not enabled. When the heavy > traffic is over, we will open again. > > One thing I want to make sure we think about anytime we add a > configuration, is if it is really needed. The more configuration > Kudu has the harder it is to use, operate , and support. I think > adding this as experimental feature/config could make sense, but it > sounds like adding better support for throttling, prioritization of > tables/RPCs, and improved scalability would actually help solve the > core issue more holistically. Ok, got. Let's ignore the feature. -- To view, visit http://gerrit.cloudera.org:8080/13796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd3768eda36d9574be9c41e7cd3dd81cc5ae8f3a Gerrit-Change-Number: 13796 Gerrit-PatchSet: 8 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: XiaokaiWang Gerrit-Reviewer: Yao Xu Gerrit-Reviewer: Yingchun Lai <405403...@qq.com> Gerrit-Comment-Date: Thu, 11 Jul 2019 15:53:34 + Gerrit-HasComments: No
[kudu-CR] KUDU-2722 (table level): Support new 'write enabled' table extra config
Hello Tidy Bot, Yingchun Lai, Kudu Jenkins, Yao Xu, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13796 to look at the new patch set (#8). Change subject: KUDU-2722 (table level): Support new 'write_enabled' table extra config .. KUDU-2722 (table level): Support new 'write_enabled' table extra config Change-Id: Ibd3768eda36d9574be9c41e7cd3dd81cc5ae8f3a --- M src/kudu/client/client-test.cc M src/kudu/common/common.proto M src/kudu/common/wire_protocol.cc M src/kudu/tablet/tablet_metadata-test.cc M src/kudu/tools/kudu-admin-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/ts_tablet_manager-test.cc M src/kudu/tserver/tserver.proto 8 files changed, 127 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/13796/8 -- To view, visit http://gerrit.cloudera.org:8080/13796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibd3768eda36d9574be9c41e7cd3dd81cc5ae8f3a Gerrit-Change-Number: 13796 Gerrit-PatchSet: 8 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: XiaokaiWang Gerrit-Reviewer: Yao Xu Gerrit-Reviewer: Yingchun Lai <405403...@qq.com>
[kudu-CR] KUDU-2722 (table level): Support new 'write enabled' table extra config
XiaokaiWang has posted comments on this change. (
http://gerrit.cloudera.org:8080/13796 )
Change subject: KUDU-2722 (table level): Support new 'write_enabled' table
extra config
..
Patch Set 7:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13796/2/src/kudu/tserver/tablet_service.cc
File src/kudu/tserver/tablet_service.cc:
http://gerrit.cloudera.org:8080/#/c/13796/2/src/kudu/tserver/tablet_service.cc@1084
PS2, Line 1084: boost::optional extra_config =
tablet->metadata()->extra_config();
> Still missed this.
Sorry, done now.
http://gerrit.cloudera.org:8080/#/c/13796/7/src/kudu/tserver/tablet_service.cc
File src/kudu/tserver/tablet_service.cc:
http://gerrit.cloudera.org:8080/#/c/13796/7/src/kudu/tserver/tablet_service.cc@1146
PS7, Line 1146: Status s = Status::InvalidArgument("rejecting write
request: tablet is not writable");
: SetupErrorAndRespond(resp->mutable_error(), s,
> Nit: why not combine these as before?
The line length is long, it's more than 100 characters after indent.
--
To view, visit http://gerrit.cloudera.org:8080/13796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd3768eda36d9574be9c41e7cd3dd81cc5ae8f3a
Gerrit-Change-Number: 13796
Gerrit-PatchSet: 7
Gerrit-Owner: XiaokaiWang
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Grant Henke
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: XiaokaiWang
Gerrit-Reviewer: Yao Xu
Gerrit-Reviewer: Yingchun Lai <405403...@qq.com>
Gerrit-Comment-Date: Thu, 11 Jul 2019 13:39:45 +
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2722 (table level): Support new 'write enabled' table extra config
Hello Tidy Bot, Yingchun Lai, Kudu Jenkins, Yao Xu, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13796 to look at the new patch set (#7). Change subject: KUDU-2722 (table level): Support new 'write_enabled' table extra config .. KUDU-2722 (table level): Support new 'write_enabled' table extra config Change-Id: Ibd3768eda36d9574be9c41e7cd3dd81cc5ae8f3a --- M src/kudu/client/client-test.cc M src/kudu/common/common.proto M src/kudu/common/wire_protocol.cc M src/kudu/tablet/tablet_metadata-test.cc M src/kudu/tools/kudu-admin-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/ts_tablet_manager-test.cc M src/kudu/tserver/tserver.proto 8 files changed, 127 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/13796/7 -- To view, visit http://gerrit.cloudera.org:8080/13796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibd3768eda36d9574be9c41e7cd3dd81cc5ae8f3a Gerrit-Change-Number: 13796 Gerrit-PatchSet: 7 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: XiaokaiWang Gerrit-Reviewer: Yao Xu Gerrit-Reviewer: Yingchun Lai <405403...@qq.com>
[kudu-CR] KUDU-2722 (table level): Support new 'write enabled' table extra config
Hello Tidy Bot, Yingchun Lai, Kudu Jenkins, Yao Xu, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13796 to look at the new patch set (#6). Change subject: KUDU-2722 (table level): Support new 'write_enabled' table extra config .. KUDU-2722 (table level): Support new 'write_enabled' table extra config Change-Id: Ibd3768eda36d9574be9c41e7cd3dd81cc5ae8f3a --- M src/kudu/client/client-test.cc M src/kudu/common/common.proto M src/kudu/common/wire_protocol.cc M src/kudu/tablet/tablet_metadata-test.cc M src/kudu/tools/kudu-admin-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/ts_tablet_manager-test.cc M src/kudu/tserver/tserver.proto 8 files changed, 128 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/13796/6 -- To view, visit http://gerrit.cloudera.org:8080/13796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibd3768eda36d9574be9c41e7cd3dd81cc5ae8f3a Gerrit-Change-Number: 13796 Gerrit-PatchSet: 6 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: XiaokaiWang Gerrit-Reviewer: Yao Xu Gerrit-Reviewer: Yingchun Lai <405403...@qq.com>
[kudu-CR] KUDU-2722 (table level): Support new 'write enabled' table extra config
Hello Tidy Bot, Yingchun Lai, Kudu Jenkins, Yao Xu, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13796 to look at the new patch set (#5). Change subject: KUDU-2722 (table level): Support new 'write_enabled' table extra config .. KUDU-2722 (table level): Support new 'write_enabled' table extra config Change-Id: Ibd3768eda36d9574be9c41e7cd3dd81cc5ae8f3a --- M src/kudu/client/client-test.cc M src/kudu/common/common.proto M src/kudu/common/wire_protocol.cc M src/kudu/tablet/tablet_metadata-test.cc M src/kudu/tools/kudu-admin-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/ts_tablet_manager-test.cc M src/kudu/tserver/tserver.proto 8 files changed, 128 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/13796/5 -- To view, visit http://gerrit.cloudera.org:8080/13796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibd3768eda36d9574be9c41e7cd3dd81cc5ae8f3a Gerrit-Change-Number: 13796 Gerrit-PatchSet: 5 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: XiaokaiWang Gerrit-Reviewer: Yao Xu Gerrit-Reviewer: Yingchun Lai <405403...@qq.com>
[kudu-CR] [maintenance] Add extra config for maintenance manager task priority
XiaokaiWang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13659 ) Change subject: [maintenance] Add extra config for maintenance manager task priority .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13659/2/src/kudu/common/common.proto File src/kudu/common/common.proto: PS2: > Do you think we should update all of the tests that xiaokai updated (https: Do we need to confirm that it works on all respects? I think it is needed. -- To view, visit http://gerrit.cloudera.org:8080/13659 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I966ee626ef85ce56ba4517b9e494f3ac5b044867 Gerrit-Change-Number: 13659 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <405403...@qq.com> Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley Gerrit-Reviewer: XiaokaiWang Gerrit-Reviewer: Yao Xu Gerrit-Reviewer: Yingchun Lai <405403...@qq.com> Gerrit-Comment-Date: Wed, 10 Jul 2019 15:59:32 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2722 (table level): Support new 'write enabled' table extra config
Hello Tidy Bot, Kudu Jenkins, Yao Xu, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13796 to look at the new patch set (#4). Change subject: KUDU-2722 (table level): Support new 'write_enabled' table extra config .. KUDU-2722 (table level): Support new 'write_enabled' table extra config Change-Id: Ibd3768eda36d9574be9c41e7cd3dd81cc5ae8f3a --- M src/kudu/client/client-test.cc M src/kudu/common/common.proto M src/kudu/common/wire_protocol.cc M src/kudu/tablet/tablet_metadata-test.cc M src/kudu/tools/kudu-admin-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/ts_tablet_manager-test.cc M src/kudu/tserver/tserver.proto 8 files changed, 128 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/13796/4 -- To view, visit http://gerrit.cloudera.org:8080/13796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibd3768eda36d9574be9c41e7cd3dd81cc5ae8f3a Gerrit-Change-Number: 13796 Gerrit-PatchSet: 4 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: XiaokaiWang Gerrit-Reviewer: Yao Xu
[kudu-CR] KUDU-2722 (table level): Support new 'write enabled' table extra config
Hello Tidy Bot, Kudu Jenkins, Yao Xu, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13796 to look at the new patch set (#3). Change subject: KUDU-2722 (table level): Support new 'write_enabled' table extra config .. KUDU-2722 (table level): Support new 'write_enabled' table extra config Change-Id: Ibd3768eda36d9574be9c41e7cd3dd81cc5ae8f3a --- M src/kudu/client/client-test.cc M src/kudu/common/common.proto M src/kudu/common/wire_protocol.cc M src/kudu/tablet/tablet_metadata-test.cc M src/kudu/tools/kudu-admin-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/ts_tablet_manager-test.cc M src/kudu/tserver/tserver.proto M src/kudu/util/status.cc M src/kudu/util/status.h 10 files changed, 136 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/13796/3 -- To view, visit http://gerrit.cloudera.org:8080/13796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibd3768eda36d9574be9c41e7cd3dd81cc5ae8f3a Gerrit-Change-Number: 13796 Gerrit-PatchSet: 3 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: XiaokaiWang Gerrit-Reviewer: Yao Xu
[kudu-CR] KUDU-2722 (table level): Support new 'write enabled' table extra config
XiaokaiWang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13796 ) Change subject: KUDU-2722 (table level): Support new 'write_enabled' table extra config .. Patch Set 2: > I'm curious about how to implement the read-only range partition? > For the read-only range partitions, it seems that the tablet-based > configuration might be better, not a table. :) Hello Yao Xu, talking about this with Grant before. Yeah, table level config is not appropriate. An RPC would be used to set the tablet state to READ_ONLY (https://github.com/apache/kudu/blob/master/src/kudu/tablet/metadata.proto#L58). What do you think? @Adar -- To view, visit http://gerrit.cloudera.org:8080/13796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd3768eda36d9574be9c41e7cd3dd81cc5ae8f3a Gerrit-Change-Number: 13796 Gerrit-PatchSet: 2 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: XiaokaiWang Gerrit-Reviewer: Yao Xu Gerrit-Comment-Date: Wed, 10 Jul 2019 14:36:14 + Gerrit-HasComments: No
[kudu-CR] KUDU-2722 (table level): Support new 'write enabled' table extra config
XiaokaiWang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13796 ) Change subject: KUDU-2722 (table level): Support new 'write_enabled' table extra config .. Patch Set 2: > (14 comments) Thanks for your comments, Adar. I update the code for your all comments, please take a review again. -- To view, visit http://gerrit.cloudera.org:8080/13796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd3768eda36d9574be9c41e7cd3dd81cc5ae8f3a Gerrit-Change-Number: 13796 Gerrit-PatchSet: 2 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: XiaokaiWang Gerrit-Reviewer: Yao Xu Gerrit-Comment-Date: Wed, 10 Jul 2019 14:28:50 + Gerrit-HasComments: No
[kudu-CR] KUDU-2722 (table level): Support new 'write enabled' table extra config
Hello Tidy Bot, Kudu Jenkins, Yao Xu, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13796 to look at the new patch set (#2). Change subject: KUDU-2722 (table level): Support new 'write_enabled' table extra config .. KUDU-2722 (table level): Support new 'write_enabled' table extra config Change-Id: Ibd3768eda36d9574be9c41e7cd3dd81cc5ae8f3a --- M src/kudu/client/client-test.cc M src/kudu/common/common.proto M src/kudu/common/wire_protocol.cc M src/kudu/tablet/tablet_metadata-test.cc M src/kudu/tools/kudu-admin-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/ts_tablet_manager-test.cc M src/kudu/tserver/tserver.proto M src/kudu/util/status.h 9 files changed, 133 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/13796/2 -- To view, visit http://gerrit.cloudera.org:8080/13796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibd3768eda36d9574be9c41e7cd3dd81cc5ae8f3a Gerrit-Change-Number: 13796 Gerrit-PatchSet: 2 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: XiaokaiWang Gerrit-Reviewer: Yao Xu
[kudu-CR] KUDU-2722 (table level): Support table extraConfig 'write enabled' conf
XiaokaiWang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13796 ) Change subject: KUDU-2722 (table level): Support table extraConfig 'write_enabled' conf .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13796/1/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/13796/1/src/kudu/client/client-test.cc@2415 PS1, Line 2415: session->SetTimeoutMillis(1); > Is this strictly necessary for the test to pass? The session only insert one row, it's not necessary. I will delete it. -- To view, visit http://gerrit.cloudera.org:8080/13796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd3768eda36d9574be9c41e7cd3dd81cc5ae8f3a Gerrit-Change-Number: 13796 Gerrit-PatchSet: 1 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: XiaokaiWang Gerrit-Reviewer: Yao Xu Gerrit-Comment-Date: Wed, 10 Jul 2019 13:44:50 + Gerrit-HasComments: Yes
[kudu-CR] KUDU-2722 (table level): Support table extraConfig 'write enabled' conf
XiaokaiWang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13796 Change subject: KUDU-2722 (table level): Support table extraConfig 'write_enabled' conf .. KUDU-2722 (table level): Support table extraConfig 'write_enabled' conf Change-Id: Ibd3768eda36d9574be9c41e7cd3dd81cc5ae8f3a --- M src/kudu/client/client-test.cc M src/kudu/common/common.proto M src/kudu/common/wire_protocol.cc M src/kudu/tablet/tablet_metadata-test.cc M src/kudu/tools/kudu-admin-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/ts_tablet_manager-test.cc M src/kudu/tserver/tserver.proto 8 files changed, 136 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/13796/1 -- To view, visit http://gerrit.cloudera.org:8080/13796 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ibd3768eda36d9574be9c41e7cd3dd81cc5ae8f3a Gerrit-Change-Number: 13796 Gerrit-PatchSet: 1 Gerrit-Owner: XiaokaiWang
[kudu-CR] [tserver] Fix bug in AlterSchemaTransactionState::ToString
Hello Kudu Jenkins, Andrew Wong, Yao Xu, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13782 to look at the new patch set (#3). Change subject: [tserver] Fix bug in AlterSchemaTransactionState::ToString .. [tserver] Fix bug in AlterSchemaTransactionState::ToString The error_ condition is reversed, When error is null the tserver will crash. Stacktrace: 0x21f5dcc google::protobuf::TextFormat::Printer::Print() 0x21f5e6d google::protobuf::TextFormat::Printer::PrintToString() 0x204e335 kudu::pb_util::SecureShortDebugString() 0xbeae76 kudu::tablet::AlterSchemaTransactionState::ToString() 0xbead3f kudu::tablet::AlterSchemaTransaction::ToString() 0xbedaea kudu::tablet::TransactionDriver::ToString() 0xbf41e1 kudu::tablet::TransactionTracker::WaitForAllToFinish() 0xbf496f kudu::tablet::TransactionTracker::WaitForAllToFinish() 0xbe543f kudu::tablet::TabletReplica::Stop() 0x9cd198 kudu::tserver::TSTabletManager::DeleteTablet() 0x9d2f5f kudu::tserver::DeleteTabletRunnable::Run() 0x207365f kudu::ThreadPool::DispatchThread() 0x2068ec4 kudu::Thread::SuperviseThread() 0x7f01548b2dc5 start_thread 0x7f0152b8dced __clone Deleting old range partion, which will wait for all txns to finish. If being dumped txns contains 'AlterSchema-TXN', the tserver will crash. Change-Id: I7126edcdddae9cf21d343e6c6c219a003edb1be1 --- M src/kudu/tablet/transactions/alter_schema_transaction.cc M src/kudu/tablet/transactions/alter_schema_transaction.h 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/13782/3 -- To view, visit http://gerrit.cloudera.org:8080/13782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7126edcdddae9cf21d343e6c6c219a003edb1be1 Gerrit-Change-Number: 13782 Gerrit-PatchSet: 3 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: XiaokaiWang Gerrit-Reviewer: Yao Xu
[kudu-CR] [tserver] Fix bug in AlterSchemaTransactionState::ToString
XiaokaiWang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13782 ) Change subject: [tserver] Fix bug in AlterSchemaTransactionState::ToString .. Patch Set 2: > Build Failed > > http://jenkins.kudu.apache.org/job/kudu-gerrit/18177/ : FAILURE I look up the error, which is no relation with the cr. -- To view, visit http://gerrit.cloudera.org:8080/13782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7126edcdddae9cf21d343e6c6c219a003edb1be1 Gerrit-Change-Number: 13782 Gerrit-PatchSet: 2 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: XiaokaiWang Gerrit-Reviewer: Yao Xu Gerrit-Comment-Date: Tue, 02 Jul 2019 13:15:54 + Gerrit-HasComments: No
[kudu-CR] [tserver] Fix bug in AlterSchemaTransactionState::ToString
XiaokaiWang has posted comments on this change. ( http://gerrit.cloudera.org:8080/13782 ) Change subject: [tserver] Fix bug in AlterSchemaTransactionState::ToString .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13782/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13782/1//COMMIT_MSG@7 PS1, Line 7: [tserver] Fix bug in AlterSchemaTransactionState::ToString > nit: Can you split this into a title and a short body with a little bit of stacktrace: 0x21f5dcc google::protobuf::TextFormat::Printer::Print() 0x21f5e6d google::protobuf::TextFormat::Printer::PrintToString() 0x204e335 kudu::pb_util::SecureShortDebugString() 0xbeae76 kudu::tablet::AlterSchemaTransactionState::ToString() 0xbead3f kudu::tablet::AlterSchemaTransaction::ToString() 0xbedaea kudu::tablet::TransactionDriver::ToString() 0xbf41e1 kudu::tablet::TransactionTracker::WaitForAllToFinish() 0xbf496f kudu::tablet::TransactionTracker::WaitForAllToFinish() 0xbe543f kudu::tablet::TabletReplica::Stop() 0x9cd198 kudu::tserver::TSTabletManager::DeleteTablet() 0x9d2f5f kudu::tserver::DeleteTabletRunnable::Run() 0x207365f kudu::ThreadPool::DispatchThread() 0x2068ec4 kudu::Thread::SuperviseThread() 0x7f01548b2dc5 start_thread 0x7f0152b8dced __clone In our environment, everyday we will delete old range partitions(three days ago). May it has much transactions and AlterSchema txn cost more than 1s, when dumping txns to string, the tserver crashed. http://gerrit.cloudera.org:8080/#/c/13782/1//COMMIT_MSG@7 PS1, Line 7: [tserver] Fix bug in AlterSchemaTransactionState::ToString > Need to wrap. Btw, I think the headline should be more concise. OK, thanks. -- To view, visit http://gerrit.cloudera.org:8080/13782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7126edcdddae9cf21d343e6c6c219a003edb1be1 Gerrit-Change-Number: 13782 Gerrit-PatchSet: 2 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: XiaokaiWang Gerrit-Reviewer: Yao Xu Gerrit-Comment-Date: Tue, 02 Jul 2019 09:51:11 + Gerrit-HasComments: Yes
[kudu-CR] [tserver] Fix bug in AlterSchemaTransactionState::ToString
Hello Kudu Jenkins, Andrew Wong, Yao Xu, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13782 to look at the new patch set (#2). Change subject: [tserver] Fix bug in AlterSchemaTransactionState::ToString .. [tserver] Fix bug in AlterSchemaTransactionState::ToString The error_ condition is reversed, When error is null the tserver will crash. stacktrace: 0x21f5dcc google::protobuf::TextFormat::Printer::Print() 0x21f5e6d google::protobuf::TextFormat::Printer::PrintToString() 0x204e335 kudu::pb_util::SecureShortDebugString() 0xbeae76 kudu::tablet::AlterSchemaTransactionState::ToString() 0xbead3f kudu::tablet::AlterSchemaTransaction::ToString() 0xbedaea kudu::tablet::TransactionDriver::ToString() 0xbf41e1 kudu::tablet::TransactionTracker::WaitForAllToFinish() 0xbf496f kudu::tablet::TransactionTracker::WaitForAllToFinish() 0xbe543f kudu::tablet::TabletReplica::Stop() 0x9cd198 kudu::tserver::TSTabletManager::DeleteTablet() 0x9d2f5f kudu::tserver::DeleteTabletRunnable::Run() 0x207365f kudu::ThreadPool::DispatchThread() 0x2068ec4 kudu::Thread::SuperviseThread() 0x7f01548b2dc5 start_thread 0x7f0152b8dced __clone Deleting old range partion, which will wait for all txns to finish. If being dumped txns contains AlterSchema TXN and the txn is executed correct, tserver will crach. Change-Id: I7126edcdddae9cf21d343e6c6c219a003edb1be1 --- M src/kudu/tablet/transactions/alter_schema_transaction.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/13782/2 -- To view, visit http://gerrit.cloudera.org:8080/13782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I7126edcdddae9cf21d343e6c6c219a003edb1be1 Gerrit-Change-Number: 13782 Gerrit-PatchSet: 2 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yao Xu
[kudu-CR] tablet: fixed alter schema bug
XiaokaiWang has abandoned this change. ( http://gerrit.cloudera.org:8080/13783 ) Change subject: tablet: fixed alter schema bug .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/13783 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: abandon Gerrit-Change-Id: I43851bed3fedf79fb78f67dfc88ab37ab85a260e Gerrit-Change-Number: 13783 Gerrit-PatchSet: 1 Gerrit-Owner: XiaokaiWang Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] tablet: fixed alter schema bug
XiaokaiWang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13783 Change subject: tablet: fixed alter schema bug .. tablet: fixed alter schema bug alter_schema_transaction.cc ToString() function error_ condition is reverse. When error is null the server will crash Change-Id: I43851bed3fedf79fb78f67dfc88ab37ab85a260e --- M src/kudu/tablet/transactions/alter_schema_transaction.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/13783/1 -- To view, visit http://gerrit.cloudera.org:8080/13783 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I43851bed3fedf79fb78f67dfc88ab37ab85a260e Gerrit-Change-Number: 13783 Gerrit-PatchSet: 1 Gerrit-Owner: XiaokaiWang
[kudu-CR] alter schema transaction-ToString function error condition is reverse, when error happens the server may crash
XiaokaiWang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13782 Change subject: alter_schema_transaction-ToString function error_ condition is reverse, when error happens the server may crash .. alter_schema_transaction-ToString function error_ condition is reverse, when error happens the server may crash Change-Id: I7126edcdddae9cf21d343e6c6c219a003edb1be1 --- M src/kudu/tablet/transactions/alter_schema_transaction.cc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/13782/1 -- To view, visit http://gerrit.cloudera.org:8080/13782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I7126edcdddae9cf21d343e6c6c219a003edb1be1 Gerrit-Change-Number: 13782 Gerrit-PatchSet: 1 Gerrit-Owner: XiaokaiWang
