[kudu-CR] [test] Make the kudu-admin-test more robust by adding AssertEventually
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14070 ) Change subject: [test] Make the kudu-admin-test more robust by adding AssertEventually .. [test] Make the kudu-admin-test more robust by adding AssertEventually Sometimes it's possible the scan will not immediately retrieve the row even though the write has already succeeded, therefore add AssertEventually to assure the scan return the right result. It will make the test case more robust. Change-Id: Ied2993acaf35eef9d177f7e3cd1cd62ea9a1cdfb Reviewed-on: http://gerrit.cloudera.org:8080/14070 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo --- M src/kudu/tools/kudu-admin-test.cc 1 file changed, 18 insertions(+), 9 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/14070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ied2993acaf35eef9d177f7e3cd1cd62ea9a1cdfb Gerrit-Change-Number: 14070 Gerrit-PatchSet: 4 Gerrit-Owner: honeyhexin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: honeyhexin
[kudu-CR] [test] Make the kudu-admin-test more robust by adding AssertEventually
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14070 ) Change subject: [test] Make the kudu-admin-test more robust by adding AssertEventually .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/14070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied2993acaf35eef9d177f7e3cd1cd62ea9a1cdfb Gerrit-Change-Number: 14070 Gerrit-PatchSet: 3 Gerrit-Owner: honeyhexin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: honeyhexin Gerrit-Comment-Date: Thu, 15 Aug 2019 23:54:41 + Gerrit-HasComments: No
[kudu-CR] [test] Make the kudu-admin-test more robust by adding AssertEventually
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14070 to look at the new patch set (#3). Change subject: [test] Make the kudu-admin-test more robust by adding AssertEventually .. [test] Make the kudu-admin-test more robust by adding AssertEventually Sometimes it's possible the scan will not immediately retrieve the row even though the write has already succeeded, therefore add AssertEventually to assure the scan return the right result. It will make the test case more robust. Change-Id: Ied2993acaf35eef9d177f7e3cd1cd62ea9a1cdfb --- M src/kudu/tools/kudu-admin-test.cc 1 file changed, 18 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/14070/3 -- To view, visit http://gerrit.cloudera.org:8080/14070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ied2993acaf35eef9d177f7e3cd1cd62ea9a1cdfb Gerrit-Change-Number: 14070 Gerrit-PatchSet: 3 Gerrit-Owner: honeyhexin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: honeyhexin
[kudu-CR] [test] Make the kudu-admin-test more robust by adding AssertEventually
honeyhexin has posted comments on this change. (
http://gerrit.cloudera.org:8080/14070 )
Change subject: [test] Make the kudu-admin-test more robust by adding
AssertEventually
..
Patch Set 2:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/14070/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14070/1//COMMIT_MSG@7
PS1, Line 7: robust
> robust
Done
http://gerrit.cloudera.org:8080/#/c/14070/1/src/kudu/tools/kudu-admin-test.cc
File src/kudu/tools/kudu-admin-test.cc:
http://gerrit.cloudera.org:8080/#/c/14070/1/src/kudu/tools/kudu-admin-test.cc@2394
PS1, Line 2394: ASSERT_OK(client_->OpenTable(kTableId, &table));
> Or here.
Done
http://gerrit.cloudera.org:8080/#/c/14070/1/src/kudu/tools/kudu-admin-test.cc@2434
PS1, Line 2434: }
> Or here.
Done
http://gerrit.cloudera.org:8080/#/c/14070/1/src/kudu/tools/kudu-admin-test.cc@2535
PS1, Line 2535: // which will return error in lambda as we expect.
> Or here.
Done
http://gerrit.cloudera.org:8080/#/c/14070/1/src/kudu/tools/kudu-admin-test.cc@2564
PS1, Line 2564: ASSERT_EVENTUALLY([&]() {
> Or here.
Done
http://gerrit.cloudera.org:8080/#/c/14070/1/src/kudu/tools/kudu-admin-test.cc@2847
PS1, Line 2847: "drop_range_partition",
> Don't need it here.
Oops, I made a mistake. I will fix it.
--
To view, visit http://gerrit.cloudera.org:8080/14070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied2993acaf35eef9d177f7e3cd1cd62ea9a1cdfb
Gerrit-Change-Number: 14070
Gerrit-PatchSet: 2
Gerrit-Owner: honeyhexin
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Alexey Serbin
Gerrit-Reviewer: Andrew Wong
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: honeyhexin
Gerrit-Comment-Date: Thu, 15 Aug 2019 22:25:05 +
Gerrit-HasComments: Yes
[kudu-CR] [test] Make the kudu-admin-test more robust by adding AssertEventually
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14070 to look at the new patch set (#2). Change subject: [test] Make the kudu-admin-test more robust by adding AssertEventually .. [test] Make the kudu-admin-test more robust by adding AssertEventually Sometimes it's possible the scan will not immediately retrieve the row even though the write has already succeeded, therefore add AssertEventually to assure the scan return the right result. It will make the test case more robust. Change-Id: Ied2993acaf35eef9d177f7e3cd1cd62ea9a1cdfb --- M src/kudu/tools/kudu-admin-test.cc 1 file changed, 18 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/14070/2 -- To view, visit http://gerrit.cloudera.org:8080/14070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ied2993acaf35eef9d177f7e3cd1cd62ea9a1cdfb Gerrit-Change-Number: 14070 Gerrit-PatchSet: 2 Gerrit-Owner: honeyhexin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Kudu Jenkins (120)
