[kudu-CR] Add missing test dependency for Hive tests
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11733 ) Change subject: Add missing test dependency for Hive tests .. Patch Set 2: Verified+1 Failure is a flake, all Java tests passed. -- To view, visit http://gerrit.cloudera.org:8080/11733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33187880247b3fe930ff521b0671345646e0fbf4 Gerrit-Change-Number: 11733 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 19 Oct 2018 19:23:47 + Gerrit-HasComments: No
[kudu-CR] Add missing test dependency for Hive tests
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11733 ) Change subject: Add missing test dependency for Hive tests .. Add missing test dependency for Hive tests The HMS client internally calls into the JobConf class, which is provided by the org.apache.hadoop.hadoop-mapreduce-client-core artifact. The HMS only specifies an optional dependency on hadoop-mapreduce-client-core, so we are forced to depend on it explicitly. Change-Id: I33187880247b3fe930ff521b0671345646e0fbf4 Reviewed-on: http://gerrit.cloudera.org:8080/11733 Reviewed-by: Hao Hao Reviewed-by: Andrew Wong Tested-by: Dan Burkert --- M java/gradle/dependencies.gradle M java/kudu-client/build.gradle 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Hao Hao: Looks good to me, but someone else must approve Andrew Wong: Looks good to me, approved Dan Burkert: Verified -- To view, visit http://gerrit.cloudera.org:8080/11733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I33187880247b3fe930ff521b0671345646e0fbf4 Gerrit-Change-Number: 11733 Gerrit-PatchSet: 3 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Add missing test dependency for Hive tests
Dan Burkert has removed a vote on this change. Change subject: Add missing test dependency for Hive tests .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/11733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteVote Gerrit-Change-Id: I33187880247b3fe930ff521b0671345646e0fbf4 Gerrit-Change-Number: 11733 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Add missing test dependency for Hive tests
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11733 ) Change subject: Add missing test dependency for Hive tests .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/11733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33187880247b3fe930ff521b0671345646e0fbf4 Gerrit-Change-Number: 11733 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 19 Oct 2018 18:17:01 + Gerrit-HasComments: No
[kudu-CR] Add missing test dependency for Hive tests
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11733 ) Change subject: Add missing test dependency for Hive tests .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/11733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33187880247b3fe930ff521b0671345646e0fbf4 Gerrit-Change-Number: 11733 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 19 Oct 2018 18:16:30 + Gerrit-HasComments: No
[kudu-CR] Add missing test dependency for Hive tests
Hello Andrew Wong, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11733 to look at the new patch set (#2). Change subject: Add missing test dependency for Hive tests .. Add missing test dependency for Hive tests The HMS client internally calls into the JobConf class, which is provided by the org.apache.hadoop.hadoop-mapreduce-client-core artifact. The HMS only specifies an optional dependency on hadoop-mapreduce-client-core, so we are forced to depend on it explicitly. Change-Id: I33187880247b3fe930ff521b0671345646e0fbf4 --- M java/gradle/dependencies.gradle M java/kudu-client/build.gradle 2 files changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/11733/2 -- To view, visit http://gerrit.cloudera.org:8080/11733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I33187880247b3fe930ff521b0671345646e0fbf4 Gerrit-Change-Number: 11733 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Add missing test dependency for Hive tests
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11733 ) Change subject: Add missing test dependency for Hive tests .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11733/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11733/1//COMMIT_MSG@11 PS1, Line 11: Notably CDH 6.1-SNAPSHOT Maybe avoid calling out specific CDH versions? http://gerrit.cloudera.org:8080/#/c/11733/1/java/kudu-client/build.gradle File java/kudu-client/build.gradle: http://gerrit.cloudera.org:8080/#/c/11733/1/java/kudu-client/build.gradle@41 PS1, Line 41: // The HMS client relies on the MR client-core artifact for JobConf, but : // gradle doesn't correctly track the dependency for some versions of the HMS : // jar. Rather, the HMS is sometimes lists MR client-core as an optional dependency, but our tests definitely depend on it, so we're doing it explicitly here so gradle can pick it up. -- To view, visit http://gerrit.cloudera.org:8080/11733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33187880247b3fe930ff521b0671345646e0fbf4 Gerrit-Change-Number: 11733 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 19 Oct 2018 00:47:28 + Gerrit-HasComments: Yes
[kudu-CR] Add missing test dependency for Hive tests
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/11733 ) Change subject: Add missing test dependency for Hive tests .. Patch Set 1: Tracked down a bit more info on what's going on here. The HMS has an 'optional' dependency on hadoop-mapreduce-client-core, even though it 100% absolutely requires it to be on the classpath. Gradle never pulls in optional dependencies (except, it appears, at compile time). Somehow the branch-2 version of hive that we run against fulfills the dependency transitively through HBase, however it appears this isn't the case for other versions of Hive (again, notably CDH 6.x-SNAPSHOT). Since it's definitely a dependency of the HMS, and it's marked optional, I think it's appropriate to also include it as a test dependency here. -- To view, visit http://gerrit.cloudera.org:8080/11733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33187880247b3fe930ff521b0671345646e0fbf4 Gerrit-Change-Number: 11733 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 19 Oct 2018 00:42:04 + Gerrit-HasComments: No
[kudu-CR] Add missing test dependency for Hive tests
Hello Andrew Wong, Adar Dembo, Grant Henke, Hao Hao, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/11733 to review the following change. Change subject: Add missing test dependency for Hive tests .. Add missing test dependency for Hive tests The HMS client internally calls into the JobConf class, which is provided by the org.apache.hadoop.hadoop-mapreduce-client-core artifact. Apparently some versions of the HMS (Notably CDH 6.1-SNAPSHOT), when pulled in with gradle, don't include this dependency transitively. Adding it explicitly ourselves solves the problem. Change-Id: I33187880247b3fe930ff521b0671345646e0fbf4 --- M java/gradle/dependencies.gradle M java/kudu-client/build.gradle 2 files changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/11733/1 -- To view, visit http://gerrit.cloudera.org:8080/11733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I33187880247b3fe930ff521b0671345646e0fbf4 Gerrit-Change-Number: 11733 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Andrew Wong Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Hao Hao
