[kudu-CR] KUDU-1542: in some cases apply will hang.

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: KUDU-1542: in some cases apply will hang.
..


Patch Set 6:

> Lemme put it more clear:
 > 1 the "looping forever" happened when i am using "AUTO_FLUSH_BACKGROUND"
 > flush_mode.
 > 2 the timeout exception in log is like 
 > "com.stumbleupon.async.TimeoutException:
 > Timed out after 1ms when joining Defered@"
 > 3 this "looping forever" can hang quite a while ,maybe  several
 > hours . Reconnct kudu-client recover it.

That's very interesting; I wouldn't expect a background flush to hang for hours 
unless there's something broken in the client.

In KUDU-1542, JD asked if you've had a chance to retest with his newer patches. 
Did you have a chance to do that? I suspect that your fix works around a hang 
that was fixed.

-- 
To view, visit http://gerrit.cloudera.org:8080/3787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacd33cdc5316e294e613d1b2273ef12e6b1cf687
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: song bruce zhang 
Gerrit-HasComments: No

[kudu-CR] KUDU-1542: in some cases apply will hang.

[song bruce zhang (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3787

to look at the new patch set (#6).

Change subject: KUDU-1542: in some cases apply will hang.
..

KUDU-1542: in some cases apply will hang.

In current implementation, apply will retry
forever when met failure. It would be better to
have some deadline to stop it from hanging.

Change-Id: Iacd33cdc5316e294e613d1b2273ef12e6b1cf687
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduSession.java
1 file changed, 18 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/3787/6
-- 
To view, visit http://gerrit.cloudera.org:8080/3787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iacd33cdc5316e294e613d1b2273ef12e6b1cf687
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: song bruce zhang 

[kudu-CR] KUDU-1542: in some cases apply will hang.

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: KUDU-1542: in some cases apply will hang.
..


Patch Set 5:

Build Started http://104.196.14.100/job/kudu-gerrit/2674/

-- 
To view, visit http://gerrit.cloudera.org:8080/3787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacd33cdc5316e294e613d1b2273ef12e6b1cf687
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: song bruce zhang 
Gerrit-HasComments: No

[kudu-CR] KUDU-1542: in some cases apply will hang.

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: KUDU-1542: in some cases apply will hang.
..


Patch Set 4:

Build Started http://104.196.14.100/job/kudu-gerrit/2667/

-- 
To view, visit http://gerrit.cloudera.org:8080/3787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacd33cdc5316e294e613d1b2273ef12e6b1cf687
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: song bruce zhang 
Gerrit-HasComments: No

[kudu-CR] KUDU-1542: in some cases apply will hang.

[song bruce zhang (Code Review)]

song bruce zhang has posted comments on this change.

Change subject: KUDU-1542: in some cases apply will hang.
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3787/2/java/kudu-client/src/main/java/org/apache/kudu/client/KuduSession.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduSession.java:

Line 88: } catch (com.stumbleupon.async.TimeoutException e) {
> Wouldn't it be better to just check if the RPC has timed out?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacd33cdc5316e294e613d1b2273ef12e6b1cf687
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: song bruce zhang 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1542: in some cases apply will hang.

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: KUDU-1542: in some cases apply will hang.
..


Patch Set 3:

Build Started http://104.196.14.100/job/kudu-gerrit/2666/

-- 
To view, visit http://gerrit.cloudera.org:8080/3787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacd33cdc5316e294e613d1b2273ef12e6b1cf687
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] KUDU-1542: in some cases apply will hang.

[song bruce zhang (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3787

to look at the new patch set (#3).

Change subject: KUDU-1542: in some cases apply will hang.
..

KUDU-1542: in some cases apply will hang.

In current implementation, apply will retry
forever when met failed. It would be better to
have some limit to notify caller.

Change-Id: Iacd33cdc5316e294e613d1b2273ef12e6b1cf687
---
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduSession.java
1 file changed, 16 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/87/3787/3
-- 
To view, visit http://gerrit.cloudera.org:8080/3787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iacd33cdc5316e294e613d1b2273ef12e6b1cf687
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-1542: in some cases apply will hang.

[Jean-Daniel Cryans (Code Review)]

Jean-Daniel Cryans has posted comments on this change.

Change subject: KUDU-1542: in some cases apply will hang.
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3787/2/java/kudu-client/src/main/java/org/apache/kudu/client/KuduSession.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduSession.java:

Line 88:   retryTimes += 1;
Wouldn't it be better to just check if the RPC has timed out?


-- 
To view, visit http://gerrit.cloudera.org:8080/3787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacd33cdc5316e294e613d1b2273ef12e6b1cf687
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1542: in some cases apply will hang.

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: KUDU-1542: in some cases apply will hang.
..


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/2664/

-- 
To view, visit http://gerrit.cloudera.org:8080/3787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacd33cdc5316e294e613d1b2273ef12e6b1cf687
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No