[kudu-CR] [thirdparty] introduce chrony
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13915 ) Change subject: [thirdparty] introduce chrony .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71ed12311b10979af8a12094881b6b8b47ef8008 Gerrit-Change-Number: 13915 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 22 Aug 2019 01:18:02 + Gerrit-HasComments: No
[kudu-CR] [thirdparty] introduce chrony
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13915 ) Change subject: [thirdparty] introduce chrony .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/13915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71ed12311b10979af8a12094881b6b8b47ef8008 Gerrit-Change-Number: 13915 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 22 Aug 2019 00:18:58 + Gerrit-HasComments: No
[kudu-CR] [thirdparty] introduce chrony
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13915 to look at the new patch set (#3). Change subject: [thirdparty] introduce chrony .. [thirdparty] introduce chrony Added chrony into the thirdparty: a set of follow-up patches use the chronyd NTP implementation and its chronyc CLI to provide the functionality of reference NTP servers for test scenarios involving Kudu built-in NTP client. One nice feature that chronyd has is the ability to run in server-only mode, i.e. not driving the system clock: 'man chronyd', the '-x' option. Also, it's possible to chronyd NTP server using the system clock as a source instead of a physical device (GPS, oscillator, etc.). In addition, it's possible to manually set the reference time for chrony NTP server running in server-only local mode. The chrony suite has 'chronyc' CLI tool to send control commands to chronyd NTP daemon. As of now, the latest version 3.5 is used with not-yet-upstream patch to drop the requirements of being run under superuser UID when driving the system clock is not required (e.g., when running in server-only mode, see '-x' command-line flag). Change-Id: I71ed12311b10979af8a12094881b6b8b47ef8008 --- M thirdparty/build-definitions.sh M thirdparty/build-thirdparty.sh M thirdparty/download-thirdparty.sh A thirdparty/patches/chrony-no-superuser.patch M thirdparty/vars.sh 5 files changed, 86 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/13915/3 -- To view, visit http://gerrit.cloudera.org:8080/13915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I71ed12311b10979af8a12094881b6b8b47ef8008 Gerrit-Change-Number: 13915 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] introduce chrony
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13915 ) Change subject: [thirdparty] introduce chrony .. Patch Set 2: > (1 comment) Whoops. Not it's fixed. -- To view, visit http://gerrit.cloudera.org:8080/13915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71ed12311b10979af8a12094881b6b8b47ef8008 Gerrit-Change-Number: 13915 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 21 Aug 2019 20:25:21 + Gerrit-HasComments: No
[kudu-CR] [thirdparty] introduce chrony
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13915 ) Change subject: [thirdparty] introduce chrony .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/13915/1/thirdparty/patches/chrony-no-superuser.patch File thirdparty/patches/chrony-no-superuser.patch: PS1: > Done Hmm, no commit message? -- To view, visit http://gerrit.cloudera.org:8080/13915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71ed12311b10979af8a12094881b6b8b47ef8008 Gerrit-Change-Number: 13915 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Jul 2019 18:05:53 + Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] introduce chrony
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13915 ) Change subject: [thirdparty] introduce chrony .. Patch Set 1: (4 comments) > (4 comments) > > How long does chrony take to build? It's about 5 seconds to configure, build and install at 32-core 2GHz x86_64 machine. http://gerrit.cloudera.org:8080/#/c/13915/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/13915/1/thirdparty/build-definitions.sh@1013 PS1, Line 1013: #DESTDIR=$PREFIX \ > Remove? Done http://gerrit.cloudera.org:8080/#/c/13915/1/thirdparty/build-definitions.sh@1019 PS1, Line 1019: ./configure \ > Maybe add a comment rationalizing these config options? Done http://gerrit.cloudera.org:8080/#/c/13915/1/thirdparty/build-thirdparty.sh File thirdparty/build-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/13915/1/thirdparty/build-thirdparty.sh@577 PS1, Line 577: if [ -n "$F_TSAN" -o -n "$F_CHRONY" ]; then : build_chrony : fi > If we're only using it to test, could we put it in F_COMMON instead of F_UN Indeed, thanks! http://gerrit.cloudera.org:8080/#/c/13915/1/thirdparty/patches/chrony-no-superuser.patch File thirdparty/patches/chrony-no-superuser.patch: PS1: > Could you structure the patch as a git commit against master (or 3.5 or wha Done -- To view, visit http://gerrit.cloudera.org:8080/13915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71ed12311b10979af8a12094881b6b8b47ef8008 Gerrit-Change-Number: 13915 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Jul 2019 06:41:44 + Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] introduce chrony
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/13915 to look at the new patch set (#2). Change subject: [thirdparty] introduce chrony .. [thirdparty] introduce chrony Added chrony into the thirdparty: a set of follow-up patches use the chronyd NTP implementation and its chronyc CLI to provide the functionality of reference NTP servers for test scenarios involving Kudu built-in NTP client. One nice feature that chronyd has is the ability to run in server-only mode, i.e. not driving the system clock: 'man chronyd', the '-x' option. Also, it's possible to chronyd NTP server using the system clock as a source instead of a physical device (GPS, oscillator, etc.). In addition, it's possible to manually set the reference time for chrony NTP server running in server-only local mode. The chrony suite has 'chronyc' CLI tool to send control commands to chronyd NTP daemon. As of now, the latest version 3.5 is used with not-yet-upstream patch to drop the requirements of being run under superuser UID when driving the system clock is not required (e.g., when running in server-only mode, see '-x' command-line flag). Change-Id: I71ed12311b10979af8a12094881b6b8b47ef8008 --- M thirdparty/build-definitions.sh M thirdparty/build-thirdparty.sh M thirdparty/download-thirdparty.sh A thirdparty/patches/chrony-no-superuser.patch M thirdparty/vars.sh 5 files changed, 70 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/13915/2 -- To view, visit http://gerrit.cloudera.org:8080/13915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I71ed12311b10979af8a12094881b6b8b47ef8008 Gerrit-Change-Number: 13915 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] introduce chrony
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13915 ) Change subject: [thirdparty] introduce chrony .. Patch Set 1: (4 comments) How long does chrony take to build? http://gerrit.cloudera.org:8080/#/c/13915/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/13915/1/thirdparty/build-definitions.sh@1013 PS1, Line 1013: #DESTDIR=$PREFIX \ Remove? http://gerrit.cloudera.org:8080/#/c/13915/1/thirdparty/build-definitions.sh@1019 PS1, Line 1019: ./configure \ Maybe add a comment rationalizing these config options? http://gerrit.cloudera.org:8080/#/c/13915/1/thirdparty/build-thirdparty.sh File thirdparty/build-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/13915/1/thirdparty/build-thirdparty.sh@577 PS1, Line 577: if [ -n "$F_TSAN" -o -n "$F_CHRONY" ]; then : build_chrony : fi If we're only using it to test, could we put it in F_COMMON instead of F_UNINSTRUMENTED? http://gerrit.cloudera.org:8080/#/c/13915/1/thirdparty/patches/chrony-no-superuser.patch File thirdparty/patches/chrony-no-superuser.patch: PS1: Could you structure the patch as a git commit against master (or 3.5 or whatever)? That way there's more useful metadata that can be used to track provenance after your patch is accepted upstream. -- To view, visit http://gerrit.cloudera.org:8080/13915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71ed12311b10979af8a12094881b6b8b47ef8008 Gerrit-Change-Number: 13915 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 25 Jul 2019 19:16:10 + Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] introduce chrony
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13915 ) Change subject: [thirdparty] introduce chrony .. Patch Set 1: That makes sense. Thanks for clarifying. -- To view, visit http://gerrit.cloudera.org:8080/13915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71ed12311b10979af8a12094881b6b8b47ef8008 Gerrit-Change-Number: 13915 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 25 Jul 2019 17:51:26 + Gerrit-HasComments: No
[kudu-CR] [thirdparty] introduce chrony
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13915 ) Change subject: [thirdparty] introduce chrony .. Patch Set 1: > Given chrony is gplv2 licensed are we able to include it in our > build/project? See the Apache summary here: > https://www.apache.org/licenses/GPL-compatibility.html The use of chrony is only as a part of testing framework for Kudu: we are not linking it in or depending on it such a way that it might be considered as a sort of derivative project. FWIW, we use bison in 3rd-party as well it's under GPLv3, so I anticipate that GPLv2 license for a test-only tool shouldn't be a problem if it's not a problem for including bison which is build-time dependency and is under GPLv3. -- To view, visit http://gerrit.cloudera.org:8080/13915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71ed12311b10979af8a12094881b6b8b47ef8008 Gerrit-Change-Number: 13915 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 25 Jul 2019 17:00:53 + Gerrit-HasComments: No
[kudu-CR] [thirdparty] introduce chrony
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13915 ) Change subject: [thirdparty] introduce chrony .. Patch Set 1: Given chrony is gplv2 licensed are we able to include it in our build/project? See the Apache summary here: https://www.apache.org/licenses/GPL-compatibility.html -- To view, visit http://gerrit.cloudera.org:8080/13915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71ed12311b10979af8a12094881b6b8b47ef8008 Gerrit-Change-Number: 13915 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Grant Henke Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 25 Jul 2019 14:04:38 + Gerrit-HasComments: No
[kudu-CR] [thirdparty] introduce chrony
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13915 Change subject: [thirdparty] introduce chrony .. [thirdparty] introduce chrony Added chrony into the thirdparty: a set of follow-up patches use the chronyd NTP implementation and its chronyc CLI to provide the functionality of reference NTP servers for test scenarios involving Kudu built-in NTP client. One nice feature that chronyd has is the ability to run in server-only mode, i.e. not driving the system clock: 'man chronyd', the '-x' option. Also, it's possible to chronyd NTP server using the system clock as a source instead of a physical device (GPS, oscillator, etc.). In addition, it's possible to manually set the reference time for chrony NTP server running in server-only local mode. The chrony suite has 'chronyc' CLI tool to send control commands to chronyd NTP daemon. As of now, the latest version 3.5 is used with not-yet-upstream patch to drop the requirements of being run under superuser UID when driving the system clock is not required (e.g., when running in server-only mode, see '-x' command-line flag). Change-Id: I71ed12311b10979af8a12094881b6b8b47ef8008 --- M thirdparty/build-definitions.sh M thirdparty/build-thirdparty.sh M thirdparty/download-thirdparty.sh A thirdparty/patches/chrony-no-superuser.patch M thirdparty/vars.sh 5 files changed, 72 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/13915/1 -- To view, visit http://gerrit.cloudera.org:8080/13915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I71ed12311b10979af8a12094881b6b8b47ef8008 Gerrit-Change-Number: 13915 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin
