[kudu-CR] Remove tcmalloc spinlock contention metric
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9595 ) Change subject: Remove tcmalloc_spinlock_contention metric .. Remove tcmalloc_spinlock_contention metric Spinlock contention was removed from tcmalloc upstream, so this metric has been set to 0 since we upgraded to tcmalloc 2.6. I looked briefly at reverting its removal upstream, but the revert would be fairly large, so I think it's best to just accept the loss of this instrumentation. Change-Id: I2c29b81a2c692d5d876d2dd5381ba2c295684324 Reviewed-on: http://gerrit.cloudera.org:8080/9595 Tested-by: Todd Lipcon Reviewed-by: Adar Dembo --- M docs/release_notes.adoc M src/kudu/scripts/parse_metrics_log.py M src/kudu/util/spinlock_profiling-test.cc M src/kudu/util/spinlock_profiling.cc M src/kudu/util/spinlock_profiling.h M src/kudu/util/trace.h M src/kudu/util/trace_metrics.h 7 files changed, 7 insertions(+), 103 deletions(-) Approvals: Todd Lipcon: Verified Adar Dembo: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/9595 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2c29b81a2c692d5d876d2dd5381ba2c295684324 Gerrit-Change-Number: 9595 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Remove tcmalloc spinlock contention metric
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9595 ) Change subject: Remove tcmalloc_spinlock_contention metric .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9595 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c29b81a2c692d5d876d2dd5381ba2c295684324 Gerrit-Change-Number: 9595 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 13 Mar 2018 17:15:24 + Gerrit-HasComments: No
[kudu-CR] Remove tcmalloc spinlock contention metric
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9595 ) Change subject: Remove tcmalloc_spinlock_contention metric .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/9595 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c29b81a2c692d5d876d2dd5381ba2c295684324 Gerrit-Change-Number: 9595 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: Todd Lipcon Gerrit-Comment-Date: Tue, 13 Mar 2018 01:34:56 + Gerrit-HasComments: No
[kudu-CR] Remove tcmalloc spinlock contention metric
Todd Lipcon has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/9595 ) Change subject: Remove tcmalloc_spinlock_contention metric .. Removed reviewer Kudu Jenkins with the following votes: * Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/9595 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: deleteReviewer Gerrit-Change-Id: I2c29b81a2c692d5d876d2dd5381ba2c295684324 Gerrit-Change-Number: 9595 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin
[kudu-CR] Remove tcmalloc spinlock contention metric
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9595 to review the following change. Change subject: Remove tcmalloc_spinlock_contention metric .. Remove tcmalloc_spinlock_contention metric Spinlock contention was removed from tcmalloc upstream, so this metric has been set to 0 since we upgraded to tcmalloc 2.6. I looked briefly at reverting its removal upstream, but the revert would be fairly large, so I think it's best to just accept the loss of this instrumentation. Change-Id: I2c29b81a2c692d5d876d2dd5381ba2c295684324 --- M docs/release_notes.adoc M src/kudu/scripts/parse_metrics_log.py M src/kudu/util/spinlock_profiling-test.cc M src/kudu/util/spinlock_profiling.cc M src/kudu/util/spinlock_profiling.h M src/kudu/util/trace.h M src/kudu/util/trace_metrics.h 7 files changed, 7 insertions(+), 103 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/9595/1 -- To view, visit http://gerrit.cloudera.org:8080/9595 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2c29b81a2c692d5d876d2dd5381ba2c295684324 Gerrit-Change-Number: 9595 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alexey Serbin
