[kudu-CR] rw semaphore: dont include debug-util.h when not necessary
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9328 ) Change subject: rw_semaphore: dont include debug-util.h when not necessary .. rw_semaphore: dont include debug-util.h when not necessary Just avoids an unnecessary include which was making my compilation slow down every time I modified debug-util.h. Change-Id: I8a194bbffbe413eaffe0449639e3b4aa35a89900 Reviewed-on: http://gerrit.cloudera.org:8080/9328 Reviewed-by: Mike Percy Tested-by: Kudu Jenkins --- M src/kudu/util/rw_semaphore.h 1 file changed, 8 insertions(+), 5 deletions(-) Approvals: Mike Percy: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8a194bbffbe413eaffe0449639e3b4aa35a89900 Gerrit-Change-Number: 9328 Gerrit-PatchSet: 10 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley
[kudu-CR] rw semaphore: dont include debug-util.h when not necessary
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9328 ) Change subject: rw_semaphore: dont include debug-util.h when not necessary .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a194bbffbe413eaffe0449639e3b4aa35a89900 Gerrit-Change-Number: 9328 Gerrit-PatchSet: 9 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 23 Feb 2018 01:45:40 + Gerrit-HasComments: No
[kudu-CR] rw semaphore: dont include debug-util.h when not necessary
Hello Will Berkeley, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9328 to look at the new patch set (#9). Change subject: rw_semaphore: dont include debug-util.h when not necessary .. rw_semaphore: dont include debug-util.h when not necessary Just avoids an unnecessary include which was making my compilation slow down every time I modified debug-util.h. Change-Id: I8a194bbffbe413eaffe0449639e3b4aa35a89900 --- M src/kudu/util/rw_semaphore.h 1 file changed, 8 insertions(+), 5 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/9328/9 -- To view, visit http://gerrit.cloudera.org:8080/9328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8a194bbffbe413eaffe0449639e3b4aa35a89900 Gerrit-Change-Number: 9328 Gerrit-PatchSet: 9 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley
[kudu-CR] rw semaphore: dont include debug-util.h when not necessary
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9328 ) Change subject: rw_semaphore: dont include debug-util.h when not necessary .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/9328/6/src/kudu/util/rw_semaphore.h File src/kudu/util/rw_semaphore.h: http://gerrit.cloudera.org:8080/#/c/9328/6/src/kudu/util/rw_semaphore.h@54 PS6, Line 54: // : // In order to support easier debugging of leaked locks, this class can track : // the stack trace of the last thread to lock it in write mode. To do so, : // uncomment the following define: : // #define RW_SEMAPHORE_TRACK_HOLDER 1 > this is out of order from the define above and wouldn't actually work this Done -- To view, visit http://gerrit.cloudera.org:8080/9328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a194bbffbe413eaffe0449639e3b4aa35a89900 Gerrit-Change-Number: 9328 Gerrit-PatchSet: 6 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Fri, 23 Feb 2018 01:24:41 + Gerrit-HasComments: Yes
[kudu-CR] rw semaphore: dont include debug-util.h when not necessary
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9328 ) Change subject: rw_semaphore: dont include debug-util.h when not necessary .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/9328/6/src/kudu/util/rw_semaphore.h File src/kudu/util/rw_semaphore.h: http://gerrit.cloudera.org:8080/#/c/9328/6/src/kudu/util/rw_semaphore.h@54 PS6, Line 54: // : // In order to support easier debugging of leaked locks, this class can track : // the stack trace of the last thread to lock it in write mode. To do so, : // uncomment the following define: : // #define RW_SEMAPHORE_TRACK_HOLDER 1 this is out of order from the define above and wouldn't actually work this way... perhaps move this up above the include? -- To view, visit http://gerrit.cloudera.org:8080/9328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a194bbffbe413eaffe0449639e3b4aa35a89900 Gerrit-Change-Number: 9328 Gerrit-PatchSet: 6 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Will Berkeley Gerrit-Comment-Date: Wed, 21 Feb 2018 08:04:04 + Gerrit-HasComments: Yes
[kudu-CR] rw semaphore: dont include debug-util.h when not necessary
Hello Will Berkeley, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9328 to review the following change. Change subject: rw_semaphore: dont include debug-util.h when not necessary .. rw_semaphore: dont include debug-util.h when not necessary Just avoids an unnecessary include which was making my compilation slow down every time I modified debug-util.h. Change-Id: I8a194bbffbe413eaffe0449639e3b4aa35a89900 --- M src/kudu/util/rw_semaphore.h 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/9328/1 -- To view, visit http://gerrit.cloudera.org:8080/9328 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I8a194bbffbe413eaffe0449639e3b4aa35a89900 Gerrit-Change-Number: 9328 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Will Berkeley
