[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 1: https://github.com/google/googletest/issues/533 has some discussion here --

[kudu-CR](gh-pages) No default partitioning blog post

2016-06-03 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: No default partitioning blog post .. No default partitioning blog post Change-Id: I14ace416b3eb5b61bb522a388e564be2e7dce3a9 Reviewed-on:

[kudu-CR] KUDU-1446 Consider data types in predicate evaluation order

2016-06-03 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3298 to look at the new patch set (#3). Change subject: KUDU-1446 Consider data types in predicate evaluation order ..

[kudu-CR] KUDU-1446 Consider data types in predicate evaluation order

2016-06-03 Thread Will Berkeley (Code Review)
Will Berkeley has abandoned this change. Change subject: KUDU-1446 Consider data types in predicate evaluation order .. Abandoned unintentional dupe -- To view, visit http://gerrit.cloudera.org:8080/3300 To unsubscribe,

[kudu-CR](branch-0.9.x) Document advice about max columns and record size

2016-06-03 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Document advice about max columns and record size .. Patch Set 1: I missed this patch when creating 0.9.0 RC1. We can keep it open in case we do RC2 since

[kudu-CR](gh-pages) No default partitioning blog post

2016-06-03 Thread Dan Burkert (Code Review)
Hello Misty Stanley-Jones, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3277 to look at the new patch set (#5). Change subject: No default partitioning blog post .. No default

[kudu-CR] Update Java client for new master GetTableLocations semantics

2016-06-03 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Update Java client for new master GetTableLocations semantics .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/1737/ -- To view, visit

[kudu-CR] Update Java client for new master GetTableLocations semantics

2016-06-03 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3303 to review the following change. Change subject: Update Java client for new master GetTableLocations semantics

[kudu-CR] KUDU-1308 [c++-client]: support tables with non-covering range partitions

2016-06-03 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1308 [c++-client]: support tables with non-covering range partitions .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/1738/ -- To

[kudu-CR] Improve tpch usability

2016-06-03 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Improve tpch usability .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3279 To unsubscribe, visit

[kudu-CR] KUDU-1363: Add in-list predicates for extracting a set of equalities.

2016-06-03 Thread Sameer Abhyankar (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2986 to look at the new patch set (#5). Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities.

[kudu-CR] [WIP] KUDU-1398 CFile index blocks can store shortest separating prefix

2016-06-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [WIP] KUDU-1398 CFile index blocks can store shortest separating prefix .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3304/2//COMMIT_MSG

[kudu-CR] [WIP] KUDU-1398 CFile index blocks can store shortest separating prefix

2016-06-03 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [WIP] KUDU-1398 CFile index blocks can store shortest separating prefix .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/1741/ -- To view,

[kudu-CR] [WIP] KUDU-1398 CFile index blocks can store shortest separating prefix

2016-06-03 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3304 to look at the new patch set (#2). Change subject: [WIP] KUDU-1398 CFile index blocks can store shortest separating prefix

[kudu-CR] KUDU-1363: Add in-list predicates for extracting a set of equalities.

2016-06-03 Thread Sameer Abhyankar (Code Review)
Sameer Abhyankar has posted comments on this change. Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. .. Patch Set 5: (28 comments) Hey folks - I believe most of the changes that Adar had

[kudu-CR] [java client] Fix GetTableLocations error handling

2016-06-03 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Fix GetTableLocations error handling .. Patch Set 2: (7 comments)

[kudu-CR] Update Java client for new master GetTableLocations semantics

2016-06-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Update Java client for new master GetTableLocations semantics .. Patch Set 1: This change will cause a 1.0 Java client to misinterpret an empty GetTableLocations

[kudu-CR] KUDU-1363: Add in-list predicates for extracting a set of equalities.

2016-06-03 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1363: Add in-list predicates for extracting a set of equalities. .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/1742/ -- To view,

[kudu-CR] KUDU-1446 Consider data types in predicate evaluation order

2016-06-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1446 Consider data types in predicate evaluation order .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3298 To unsubscribe,

[kudu-CR] kudu-1475: set is is initialized to false in log pre-allocated case

2016-06-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: kudu-1475: set is is_initialized_ to false in log pre-allocated case .. Patch Set 3: (1 comment) BTW, your tests are failing because this patch is based on one

[kudu-CR] KUDU-1473: fix some tablet lock usage in CatalogManager

2016-06-03 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/1745/ -- To view, visit

[kudu-CR] KUDU-1473: fix some tablet lock usage in CatalogManager

2016-06-03 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3309 to review the following change. Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager .. KUDU-1473:

[kudu-CR] ts itest-base.h: wait for bootstrapping to finish when waiting for replicas

2016-06-03 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: ts_itest-base.h: wait for bootstrapping to finish when waiting for replicas .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/1744/ -- To

[kudu-CR] KUDU-1353: remove per-tablet replica locations cache

2016-06-03 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1353: remove per-tablet replica locations cache .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/1743/ -- To view, visit

[kudu-CR] KUDU-1353: remove per-tablet replica locations cache

2016-06-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1353: remove per-tablet replica locations cache .. Patch Set 7: I've rebased this on top of a new patch that should fix the test failures I mentioned

[kudu-CR] Update Java client for new master GetTableLocations semantics

2016-06-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Update Java client for new master GetTableLocations semantics .. Patch Set 1: (1 comment) It would be great if we could test the modified code paths.

[kudu-CR] Update Java client for new master GetTableLocations semantics

2016-06-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Update Java client for new master GetTableLocations semantics .. Patch Set 1: I think this may be a breaking change. Still thinking about how to do it backwards

[kudu-CR] KUDU-1385 Part 1: Modify documentation landing page

2016-06-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1385 Part 1: Modify documentation landing page .. KUDU-1385 Part 1: Modify documentation landing page Rename introduction.html to index.html and get

[kudu-CR] KUDU-1446 Consider data types in predicate evaluation order

2016-06-03 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/3298 Change subject: KUDU-1446 Consider data types in predicate evaluation order .. KUDU-1446 Consider data types in predicate evaluation

[kudu-CR] KUDU-1446 Consider data types in predicate evaluation order

2016-06-03 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1446 Consider data types in predicate evaluation order .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/1733/ -- To view, visit