[kudu-CR] Always write last known addr into ConsensusMetadata

2016-06-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Always write last_known_addr into ConsensusMetadata .. Patch Set 1: I'm actually not quite sure about this solution. It works for now but it may not work well for

[kudu-CR] Use RaftConsensus instead of LocalConsensus in tests

2016-06-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Use RaftConsensus instead of LocalConsensus in tests .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/1790/ -- To view, visit

[kudu-CR] Add WaitUntilLeader() to Consensus interface

2016-06-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add WaitUntilLeader() to Consensus interface .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/1789/ -- To view, visit

[kudu-CR] Remove the LocalConsensus implementation

2016-06-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Remove the LocalConsensus implementation .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/1794/ -- To view, visit

[kudu-CR] RaftConsensus: Trigger election at startup if single node

2016-06-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: RaftConsensus: Trigger election at startup if single node .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/1788/ -- To view, visit

[kudu-CR] Add WaitUntilLeader() to Consensus interface

2016-06-08 Thread Mike Percy (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3345 to review the following change. Change subject: Add WaitUntilLeader() to Consensus interface .. Add

[kudu-CR] Use RaftConsensus instead of LocalConsensus in tests

2016-06-08 Thread Mike Percy (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3346 to review the following change. Change subject: Use RaftConsensus instead of LocalConsensus in tests .. Use

[kudu-CR] Convert alter table-test to use RaftConsensus

2016-06-08 Thread Mike Percy (Code Review)
Hello David Ribeiro Alves, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3347 to review the following change. Change subject: Convert alter_table-test to use RaftConsensus .. Convert

[kudu-CR] KUDU-1398 CFile index blocks can store shortest separating prefix

2016-06-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1398 CFile index blocks can store shortest separating prefix .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/1787/ -- To view, visit

[kudu-CR] KUDU-1398 CFile index blocks can store shortest separating prefix

2016-06-08 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3304 to look at the new patch set (#6). Change subject: KUDU-1398 CFile index blocks can store shortest separating prefix

[kudu-CR] KUDU-1398 CFile index blocks can store shortest separating prefix

2016-06-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1398 CFile index blocks can store shortest separating prefix .. Patch Set 4: (15 comments) http://gerrit.cloudera.org:8080/#/c/3304/4//COMMIT_MSG Commit

[kudu-CR] KUDU-1398 CFile index blocks can store shortest separating prefix

2016-06-08 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3304 to look at the new patch set (#5). Change subject: KUDU-1398 CFile index blocks can store shortest separating prefix

[kudu-CR] KUDU-1398 CFile index blocks can store shortest separating prefix

2016-06-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1398 CFile index blocks can store shortest separating prefix .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/1786/ -- To view, visit

[kudu-CR] [java client] Fix a race in TabletClient cleanup

2016-06-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [java client] Fix a race in TabletClient cleanup .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/1785/ -- To view, visit

[kudu-CR] [java client] Fix a race in TabletClient cleanup

2016-06-08 Thread Jean-Daniel Cryans (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3340 to look at the new patch set (#2). Change subject: [java client] Fix a race in TabletClient cleanup ..

[kudu-CR] [java client] Fix a race in TabletClient cleanup

2016-06-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Fix a race in TabletClient cleanup .. Patch Set 1: (1 comment)

[kudu-CR] [java client] Fix a race in TabletClient cleanup

2016-06-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java client] Fix a race in TabletClient cleanup .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] KUDU-1473: fix some tablet lock usage in CatalogManager

2016-06-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3309 To

[kudu-CR] KUDU-1353: remove per-tablet replica locations cache

2016-06-08 Thread Adar Dembo (Code Review)
Hello Jean-Daniel Cryans, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2887 to look at the new patch set (#11). Change subject: KUDU-1353: remove per-tablet replica locations cache ..

[kudu-CR] KUDU-1353: remove per-tablet replica locations cache

2016-06-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1353: remove per-tablet replica locations cache .. Patch Set 11: Build Started http://104.196.14.100/job/kudu-gerrit/1783/ -- To view, visit

[kudu-CR] KUDU-1473: fix some tablet lock usage in CatalogManager

2016-06-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/1784/ -- To view, visit

[kudu-CR] KUDU-1473: fix some tablet lock usage in CatalogManager

2016-06-08 Thread Adar Dembo (Code Review)
Adar Dembo has uploaded a new patch set (#6). Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager .. KUDU-1473: fix some tablet lock usage in CatalogManager This was probably due to the refactoring done in

[kudu-CR] KUDU-1473: fix some tablet lock usage in CatalogManager

2016-06-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3309/5//COMMIT_MSG Commit Message: PS5,

[kudu-CR] KUDU-1353: remove per-tablet replica locations cache

2016-06-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1353: remove per-tablet replica locations cache .. Patch Set 10: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/2887 To unsubscribe,

[kudu-CR] [java client] Fix a race in TabletClient cleanup

2016-06-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [java client] Fix a race in TabletClient cleanup .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/1782/ -- To view, visit

[kudu-CR] [java client] Fix a race in TabletClient cleanup

2016-06-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/3340 Change subject: [java client] Fix a race in TabletClient cleanup .. [java client] Fix a race in TabletClient cleanup Dan noticed

[kudu-CR] KUDU-1469. Fix handling of fully-deduped requests after a leader change

2016-06-08 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1469. Fix handling of fully-deduped requests after a leader change .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] ts itest-base.h: wait for bootstrapping to finish when waiting for replicas

2016-06-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: ts_itest-base.h: wait for bootstrapping to finish when waiting for replicas .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] ts itest-base.h: wait for bootstrapping to finish when waiting for replicas

2016-06-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: ts_itest-base.h: wait for bootstrapping to finish when waiting for replicas .. ts_itest-base.h: wait for bootstrapping to finish when waiting for

[kudu-CR] ts itest-base.h: wait for bootstrapping to finish when waiting for replicas

2016-06-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: ts_itest-base.h: wait for bootstrapping to finish when waiting for replicas .. Patch Set 3: Todd was also +2 on PS2. -- To view, visit

[kudu-CR] KUDU-1473: fix some tablet lock usage in CatalogManager

2016-06-08 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1473: fix some tablet lock usage in CatalogManager .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3309/5//COMMIT_MSG Commit Message:

[kudu-CR] Update documentation and build helper script

2016-06-08 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Update documentation and build helper script .. Patch Set 1: (1 comment) In order to pass validation, this patch will need to be rebased over the latest changes

[kudu-CR] Update documentation and build helper script

2016-06-08 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Update documentation and build helper script .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/1781/ -- To view, visit

[kudu-CR] Update documentation and build helper script

2016-06-08 Thread Cenk Uyan (Code Review)
Cenk Uyan has uploaded a new change for review. http://gerrit.cloudera.org:8080/3336 Change subject: Update documentation and build helper script .. Update documentation and build helper script Added 'unzip' pkg among