[kudu-CR] KUDU-1358 (part 1): master should accept heartbeat even if follower

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: KUDU-1358 (part 1): master should accept heartbeat even if 
follower
..


Patch Set 12:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/3609/12//COMMIT_MSG
Commit Message:

Line 20: possible; the only way a master can "lose" a cached TSDescriptor is if 
the
> what about when a tserver restarts? is it still going to do a proper full T
If the tserver restarts, it always issues a full TR as its first heartbeat. And 
if that heartbeat fails, it'll get retried until the server acknowledges it.

That's always been the case; the subsequent patch just adds "if you see your 
master go from not_leader to leader, send a full TR".


http://gerrit.cloudera.org:8080/#/c/3609/12/src/kudu/integration-tests/mini_cluster.cc
File src/kudu/integration-tests/mini_cluster.cc:

Line 289: auto ts = mini_tablet_server->server();
> should this verify that the TS process is running? (there's a getter for th
I'm inclined to keep it the way it is. This is old code; my goal was to add the 
DO_NOT_MATCH_TSERVERS mode so I could use it in my integration test.

I'll document that the tservers may not be running, though.


Line 299:   }
> else LOG(FATAL) perhaps? or use a switch() so that you get a compilation er
I'll use a switch. Note that the downside of using enum classes is that you 
can't use operator<< on the value (it doesn't implicit cast to an int).


http://gerrit.cloudera.org:8080/#/c/3609/12/src/kudu/integration-tests/mini_cluster.h
File src/kudu/integration-tests/mini_cluster.h:

Line 145: // Match the tservers retrieved from each master against the 
tservers in
> not sure what 'Match' means here. Is this a verification? (i.e that the cou
OK, will elaborate in the comment.


-- 
To view, visit http://gerrit.cloudera.org:8080/3609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I578674927b65b4171e8437de8515130e4a0ed139
Gerrit-PatchSet: 12
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1374: send full tablet report when new leader master is detected

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: KUDU-1374: send full tablet report when new leader master is 
detected
..


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3643/8/src/kudu/tserver/heartbeater.cc
File src/kudu/tserver/heartbeater.cc:

Line 405:   resp.leader_master()) {
nit: dont really need to check has_leader_master() in either of these cases -- 
it'll just default to false


-- 
To view, visit http://gerrit.cloudera.org:8080/3643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic16fc46736476dba39616e79ecfe79eee48b3d7f
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1358 (part 3): new multi-master stress test

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: KUDU-1358 (part 3): new multi-master stress test
..


Patch Set 12: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/3611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40b5b78c100a7b427b2f4aac3a54665e82a9618c
Gerrit-PatchSet: 12
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-1358 (part 2): heartbeat to every master

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: KUDU-1358 (part 2): heartbeat to every master
..


Patch Set 12: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic85ac4193462d21c989dbd7874b451e8eaab8e3e
Gerrit-PatchSet: 12
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-1358 (part 1): master should accept heartbeat even if follower

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: KUDU-1358 (part 1): master should accept heartbeat even if 
follower
..


Patch Set 12:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/3609/12//COMMIT_MSG
Commit Message:

Line 20: possible; the only way a master can "lose" a cached TSDescriptor is if 
the
what about when a tserver restarts? is it still going to do a proper full TR 
after the restart, due to some tserver-side logic? are we waiting on the later 
patch in this series to make sure that the tserver logic ensures a full TR 
after a leader change?


http://gerrit.cloudera.org:8080/#/c/3609/12/src/kudu/integration-tests/mini_cluster.cc
File src/kudu/integration-tests/mini_cluster.cc:

Line 289: auto ts = mini_tablet_server->server();
should this verify that the TS process is running? (there's a getter for that). 
Worth documenting either way


Line 299:   }
else LOG(FATAL) perhaps? or use a switch() so that you get a compilation error 
if you were to add a new matchmode


http://gerrit.cloudera.org:8080/#/c/3609/12/src/kudu/integration-tests/mini_cluster.h
File src/kudu/integration-tests/mini_cluster.h:

Line 145: // Match the tservers retrieved from each master against the 
tservers in
not sure what 'Match' means here. Is this a verification? (i.e that the count 
and uuids match, and otherwise a bad Status will return?) Could be more clear.


-- 
To view, visit http://gerrit.cloudera.org:8080/3609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I578674927b65b4171e8437de8515130e4a0ed139
Gerrit-PatchSet: 12
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] Doxygen for C++ client API

[Alexey Serbin (Code Review)]

Hello Adar Dembo, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3619

to look at the new patch set (#13).

Change subject: Doxygen for C++ client API
..

Doxygen for C++ client API

If doxygen is available, build 'doxygen' taget to generate
Doxygen docs from client.h and other Kudu C++ client API files,
After the target is built, open
${CMAKE_CURRENT_BINARY_DIR}/docs/doxygen/client_api/html/index.html
in your favorite browser to see the generated documentation.

If doxygen is available, the 'docs' target generates
doxygen documentaion as well since it depends on the 'doxygen' target.

Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02
---
M CMakeLists.txt
A docs/support/doxygen/client_api.doxy.in
M src/kudu/client/client.h
M src/kudu/util/CMakeLists.txt
M thirdparty/download-thirdparty.sh
5 files changed, 1,298 insertions(+), 721 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/3619/13
-- 
To view, visit http://gerrit.cloudera.org:8080/3619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02
Gerrit-PatchSet: 13
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Misty Stanley-Jones 

[kudu-CR] Doxygen for C++ client API

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: Doxygen for C++ client API
..


Patch Set 13:

Build Started http://104.196.14.100/job/kudu-gerrit/2614/

-- 
To view, visit http://gerrit.cloudera.org:8080/3619
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7d42fb1c90b83074e357dcecf42489ed9fc4f02
Gerrit-PatchSet: 13
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Misty Stanley-Jones 
Gerrit-HasComments: No

[kudu-CR] Doxygen for C++ client API

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: Doxygen for C++ client API
..


Patch Set 12:

(42 comments)

http://gerrit.cloudera.org:8080/#/c/3619/12/src/kudu/client/client.h
File src/kudu/client/client.h:

Line 92: /// Only the first invocation has effect; subsequent invocations are
> This needs to be 'any effect' or preferably 'an effect'
Done


Line 103: /// Only the first invocation has any effect; subsequent invocations 
are
> whatever you decide about 'an effect' above should probably be mirrored her
Done


Line 145: /// @brief A "factory" for the KuduClient objects.
> s/for the/for
Done


Line 147: /// This class is used to create instances of KuduClient class
> s/of/of the
Done


Line 162:   ///   RPC addresses of masterts to add.
> s/masterts/masters
Done


Line 175:   /// Set default timeout for administrative operations.
> s/default/the default
Done


Line 195:   /// Create client object.
> s/client/a client
Done


Line 200:   ///   The newly created instance wrapped into a shared pointer.
> s/into/in
Done


Line 233: /// In order to actually access data on the cluster, callers must 
first
> s/actually access data on/write data to
Done


Line 239: /// @todo Cluster administration functions are likely to be in this 
class
> I'm not sure we actually want to change our TODO syntax; it's pretty consis
@todo is also easy to grep, right?  Using @todo gives benefits of easy tracking 
those even in the generated documentation; e.g., see 
https://alexeyserbin.github.io/todo.html

I prefer to keep @todo for the external-facing APIs like this to allow better 
visibility.


Line 247:   /// @return Pointer to newly created instance; it's the caller's
> For consistency you should probably drop the contraction here and below.
Done


Line 251:   /// Check whether CreateTable operation is in-progress.
> s/CreateTable/ a create table
Done


Line 269:   /// Create a KuduTableAlterer object.
> It's probably best to be consistent about object vs. instance, for example 
Done


Line 272:   ///   Name of the table to watch for.
> s/watch for/alter
Done


Line 280:   ///   Name of the table in question.
> remove 'in question' here and below, I don't think it adds any clarity.
Done


Line 310:   ///   Substring filter to use; empty sub-string filter matches any 
tables
> s/any tables/all tables.
Done


Line 326:   /// If the table has not been opened before, then open the table
> I think this paragraph can be entirely removed, the first sentence is misle
Done


Line 359:   /// @return @c true iff client was configured to talk to multiple
> s/was/is
Done


Line 373:   /// Get highest HybridTime timestamp observed by the client.
> s/highest/the highest
Done


Line 388:   /// To use this the user must obtain the HybridTime encoded 
timestamp from
> The HybridTime encoded timestamp should be obtained from another client's K
Done


Line 442:   ///   Name of the target table -- it is copied.
> I would get rid of the note about the copy, it really shouldn't matter to c
Done


Line 443:   /// @return Reference to the modified object.
> s/object/table creator
Done


Line 445:   /// @remark Calling this method and setting name for the table-to-be
> s/name/the name
Done


Line 469:   /// For each set of hash partitions added to the table, the total 
number of
> s/table partitions/tablets
Done


Line 472:   /// with 4 and 5 buckets respectively, the total number of table 
partitions
> s/table partitions/tablets
Done


Line 505:   /// call this method with an empty vector and set no split rows an 
no hash
> s/an/and
Done


Line 517:   /// If no range split rows are added, no range pre-splitting is 
performed.
> Remove this sentence; it's not true anymore since it can be done via range 
Done


Line 559:   /// Set the number of replicas for each tablet in the table.
> Referring to tablets in this is probably going to cause confusion.  I think
Done


Line 567:   /// Set the timeout for the operation.
> s/operation/table creation operation/
Done


Line 622: /// This class is also a factory for write operation for on the table.
> s/for on/on
Done


Line 675:   /// This method creates new instance of comparison predicate which
> s/of/of a
Done


Line 700:   /// @return The KuduClient object associated with the table.
> add a note that the caller should not free the client.
Done


Line 725: /// Create a new instance of alterer using 
KuduClient::NewTableAlterer().
> s/of alterer/of a table alterer
Done


Line 756:   /// Alter an existing column.
> Add a note that the column may not be in the primary key.
Done


Line 764:   /// Drops an existing column from the table.
> Add a note that they column may not be in the primary key.
Done


Line 771:   /// Set timeout for the alteration operation.
> s/timeout/a timeout
Done


Line 814: /// @brief This class represents an error which occurred in a given 
operation.
> s/operation/write operation
Done


Line 

[kudu-CR] c++ client: use operation timeout as deadline for finding new leader master

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: c++ client: use operation timeout as deadline for finding new 
leader master
..


Patch Set 2:

Seems reasonable enough. The only potential concern is that I sort of recall 
picking the 'default RPC timeout' rather than the 'operation timeout' so that, 
if the master was actually down, the user would get an error quicker than their 
timeout, rather than a bunch of retries. If you try to contact a cluster which 
is just down, does it now hang for the full timeout? Or if we get 'connection 
refused' from all masters, does it bail out relatively quickly?

I suppose an argument could be made either way, but 'fast fail' seems to make 
sense at least for command-line interactive things if the cluster is actually 
down (not just a transient restart/failure)

-- 
To view, visit http://gerrit.cloudera.org:8080/3718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d770875bbf4703444abac11dbc232d7e382165e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] async background flush provision for C++ client

[Alexey Serbin (Code Review)]

Alexey Serbin has posted comments on this change.

Change subject: async background flush provision for C++ client
..


Patch Set 2:

(59 comments)

Thank you for review.

I addressed most of the comments, and I'm working on testing the change more 
thoroughly by all means (more tests will follow) and also looking at the other 
option of implementing background flushing.  Adar recommended to look at the 
option to utilize one of the reactor threads for that purpose.

I'll post an update on this change, but more changes are expected to appear 
soon.

http://gerrit.cloudera.org:8080/#/c/3668/2//COMMIT_MSG
Commit Message:

PS2, Line 7: provision
> nit: remove provision
Done


Line 7: async background flush provision for C++ client
> nit: capitalize (Async)
Done


PS2, Line 10: is
> nit: avoid using the passive voice. i.e. "KuduSession starts a background f
Done


PS2, Line 13: virtual
> what's a virtual buffer?
There isn't a single buffer as is, there is a set of buffers used by multiple 
batchers.  Will add clarification comment.


Line 16: The flush criteria is based on buffer size for not-yet-scheduled
> I'm having trouble parsing this sentence.
Done


PS2, Line 17: operatations
> nit: type
Done


PS2, Line 20: operatations
> nit: typo
Done


PS2, Line 23: KUDU
> Mention this issue in the commit message title.
Done


http://gerrit.cloudera.org:8080/#/c/3668/2/src/kudu/client/batcher.cc
File src/kudu/client/batcher.cc:

Line 267: #ifndef NDEBUG
> spurious change
It's not spurious, it fixes compilation warning of unused variables for debug 
builds.


Line 383: 
> spurious change
Done


Line 553:   //since the other time it's called in KuduSession::Apply()
> nit: rephrase. How about:
Done


http://gerrit.cloudera.org:8080/#/c/3668/2/src/kudu/client/batcher.h
File src/kudu/client/batcher.h:

Line 109:   // Return number of bytes used for batcher buffer
> nit: "Returns the"
I see most of comments in this file does not use third person singular form.  
The only exception is external_consistency_mode().  Are you sure it should be 
'Returns the number', but not 'Return the number'?


PS2, Line 216: //
> no need for this comment
Done


http://gerrit.cloudera.org:8080/#/c/3668/2/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

Line 1991: // return an error with session running in any supported flush mode
> nit: period
Done


PS2, Line 1993: static
> not need for static.
Done


PS2, Line 1993: buffer_space_bytes_limit
> style: kBufferSpaceBytesLimit or BUFFER_SPACE_BYTES_LIMIT
Done


PS2, Line 1994: static
> same
Done


Line 1995:   static const KuduSession::FlushMode modes[] = {
> same
Done


Line 2001:   for (const auto mode: modes) {
> isn't 'auto' already const ?
Done


Line 2007: ASSERT_TRUE(s.IsIncomplete()) << "got unexpected status: " << 
s.ToString();
> nit: capitalize Got
Done


Line 2014:   // Applying a bunch of small rows without a flush should not 
result in
> this sentence is huge and hard to read. please break it down.
Done


Line 2016:   // since there is a flow control which makes Session::Apply() 
block and wait
> what: "a flow control"?
Done


Line 2018:   {
> no need for the extra { scope
Done


Line 2023:   ASSERT_OK(ApplyInsertToSession(session.get(), client_table_, 
1, 1, "x"));
> How this testing that Apply() is eventually blocking, or making sure that t
This test is to verify that there isn't an error about overrunning the buffer.  
Yes, it's not an explicit test to verify that Apply() is blocking.  Will 
address that separately.


Line 2029: // operations are put into the queue flushed after some time.
> you mean : "into the queue and flushed" right?
Done


Line 2030: // The exact timeout interval is implementation-dependent,
> which timeout interval?
Done


Line 2031: // but 100 ms is a good upper limit anyways.
> s/anyways/anyway
Done


Line 2033:   {
> no need for the extra {
Done


Line 2041: SleepFor(MonoDelta::FromMilliseconds(100));
> loop instead of wait, otherwise this will be brittle in jenkins
Done


http://gerrit.cloudera.org:8080/#/c/3668/2/src/kudu/client/client.cc
File src/kudu/client/client.cc:

Line 705:   "Cannot change flush mode when writes are buffered");
> nit period
Done


Line 707:   data_->SetFlushMode(m);
> would it simplify things to now allow the flush mode to change if there is 
I think we can allow the flush mode to change regardless presence of 
buffered/pending write operations, but it requires proper design and some 
additional logic to be implemented.  I would try to address this in a separate 
patch/change-list.


Line 728:   return data_->SetBufferBytesLimit(size);
> why not use the same method name?
Because from internal perspective there is no context of any mutation.  It's 
just a buffer that accommodates byte representation of write operations.

>From the other hand, the outer (API-facing) name cannot be changes now without 
>braking 

[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: KUDU-1311 [master] support adding and dropping range partitions
..


Patch Set 12:

Build Started http://104.196.14.100/job/kudu-gerrit/2612/

-- 
To view, visit http://gerrit.cloudera.org:8080/3648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be
Gerrit-PatchSet: 12
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions

[Dan Burkert (Code Review)]

Hello Adar Dembo, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3648

to look at the new patch set (#12).

Change subject: KUDU-1311 [master] support adding and dropping range partitions
..

KUDU-1311 [master] support adding and dropping range partitions

Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/meta_cache.cc
M src/kudu/client/meta_cache.h
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/table_alterer-internal.h
M src/kudu/common/partition.cc
M src/kudu/integration-tests/alter_table-randomized-test.cc
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/integration-tests/external_mini_cluster.h
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master.proto
M src/kudu/master/master_service.cc
M src/kudu/tools/ksck.cc
19 files changed, 1,180 insertions(+), 208 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/3648/12
-- 
To view, visit http://gerrit.cloudera.org:8080/3648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be
Gerrit-PatchSet: 12
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] KUDU-1358 (part 1): master should accept heartbeat even if follower

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: KUDU-1358 (part 1): master should accept heartbeat even if 
follower
..


Patch Set 12: -Verified

Build Started http://104.196.14.100/job/kudu-gerrit/2611/

-- 
To view, visit http://gerrit.cloudera.org:8080/3609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I578674927b65b4171e8437de8515130e4a0ed139
Gerrit-PatchSet: 12
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] c++ client: use operation timeout as deadline for finding new leader master

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: c++ client: use operation timeout as deadline for finding new 
leader master
..


Patch Set 2: -Verified

Build Started http://104.196.14.100/job/kudu-gerrit/2609/

-- 
To view, visit http://gerrit.cloudera.org:8080/3718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d770875bbf4703444abac11dbc232d7e382165e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] master: additional leader lock assertions in catalog manager

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: master: additional leader lock assertions in catalog manager
..


Patch Set 3:

Build Started http://104.196.14.100/job/kudu-gerrit/2608/

-- 
To view, visit http://gerrit.cloudera.org:8080/3684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bb2f5067cdbdd93900a80255def65a26216f6ea
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-1358 (part 3): new multi-master stress test

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: KUDU-1358 (part 3): new multi-master stress test
..


Patch Set 12:

Build Started http://104.196.14.100/job/kudu-gerrit/2606/

-- 
To view, visit http://gerrit.cloudera.org:8080/3611
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40b5b78c100a7b427b2f4aac3a54665e82a9618c
Gerrit-PatchSet: 12
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-1358 (part 1): master should accept heartbeat even if follower

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: KUDU-1358 (part 1): master should accept heartbeat even if 
follower
..


Patch Set 12:

Build Started http://104.196.14.100/job/kudu-gerrit/2605/

-- 
To view, visit http://gerrit.cloudera.org:8080/3609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I578674927b65b4171e8437de8515130e4a0ed139
Gerrit-PatchSet: 12
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-1358 (part 2): heartbeat to every master

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: KUDU-1358 (part 2): heartbeat to every master
..


Patch Set 12:

Build Started http://104.196.14.100/job/kudu-gerrit/2607/

-- 
To view, visit http://gerrit.cloudera.org:8080/3610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic85ac4193462d21c989dbd7874b451e8eaab8e3e
Gerrit-PatchSet: 12
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] master: do not delete unknown tablets

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: master: do not delete unknown tablets
..


Patch Set 9:

Build Started http://104.196.14.100/job/kudu-gerrit/2602/

-- 
To view, visit http://gerrit.cloudera.org:8080/3645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I331f2d5bb06c38daa7b09854dbb24a7881723551
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] c++ client: use operation timeout as deadline for finding new leader master

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: c++ client: use operation timeout as deadline for finding new 
leader master
..


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/2603/

-- 
To view, visit http://gerrit.cloudera.org:8080/3718
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0d770875bbf4703444abac11dbc232d7e382165e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-1374: send full tablet report when new leader master is detected

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: KUDU-1374: send full tablet report when new leader master is 
detected
..


Patch Set 8:

Build Started http://104.196.14.100/job/kudu-gerrit/2604/

-- 
To view, visit http://gerrit.cloudera.org:8080/3643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic16fc46736476dba39616e79ecfe79eee48b3d7f
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No