[kudu-CR] KUDU-1416 Upsert support for Flume sink

2016-07-20 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1416 Upsert support for Flume sink .. Patch Set 2: > What's the story on this one? Needs another rev, right? Also needed a little bit of cleanup so it

[kudu-CR] KUDU-1516 ksck should check for more raft-related status issues (partial)

2016-07-19 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1516 ksck should check for more raft-related status issues (partial) .. Patch Set 1: > BTW, I tried this on a cluster with a bad table: > WARNING: Unable

[kudu-CR] Make block manager-test work on systems without hole-punching

2016-07-18 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Make block_manager-test work on systems without hole-punching .. Patch Set 3: (1 comment)

[kudu-CR] Make block manager-test work on systems without hole-punching

2016-07-18 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3636 to look at the new patch set (#3). Change subject: Make block_manager-test work on systems without hole-punching ..

[kudu-CR] Fix encoding-test on OS X

2016-07-13 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: Fix encoding-test on OS X .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3640/1/src/kudu/cfile/encoding-test.cc File

[kudu-CR] Fix encoding-test on OS X

2016-07-13 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3640 to look at the new patch set (#2). Change subject: Fix encoding-test on OS X .. Fix encoding-test on OS X A

[kudu-CR] Fix encoding-test on OS X

2016-07-13 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/3640 Change subject: Fix encoding-test on OS X .. Fix encoding-test on OS X A recent change caused encoding-test to fail on OS X. This

[kudu-CR] KUDU-1516 ksck should check for more raft-related status issues (partial)

2016-07-13 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/3632 Change subject: KUDU-1516 ksck should check for more raft-related status issues (partial) .. KUDU-1516 ksck should check for more

[kudu-CR] KUDU-763 consensus queue metrics on followers are messed up

2016-07-08 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-763 consensus queue metrics on followers are messed up .. Patch Set 5: (3 comments)

[kudu-CR] KUDU-763 consensus queue metrics on followers are messed up

2016-07-08 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3501 to look at the new patch set (#6). Change subject: KUDU-763 consensus queue metrics on followers are messed up ..

[kudu-CR] KUDU-763 consensus queue metrics on followers are messed up

2016-07-06 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3501 to look at the new patch set (#5). Change subject: KUDU-763 consensus queue metrics on followers are messed up ..

[kudu-CR] KUDU-763 consensus queue metrics on followers are messed up

2016-07-06 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-763 consensus queue metrics on followers are messed up .. Patch Set 3: (2 comments) > did you see my note about a test? Whoops. I'll add one soon.

[kudu-CR] Add port in web ui tables, add role and table name to /tablet page

2016-07-01 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/3553 Change subject: Add port in web ui tables, add role and table name to /tablet page .. Add port in web ui tables, add role and table

[kudu-CR] KUDU-763 consensus queue metrics on followers are messed up

2016-07-01 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3501 to look at the new patch set (#3). Change subject: KUDU-763 consensus queue metrics on followers are messed up ..

[kudu-CR] KUDU-1386 NaN float and double values are not handled correctly

2016-06-28 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3142 to look at the new patch set (#4). Change subject: KUDU-1386 NaN float and double values are not handled correctly

[kudu-CR] KUDU-1398 CFile index blocks can store shortest separating prefix

2016-06-22 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3304 to look at the new patch set (#10). Change subject: KUDU-1398 CFile index blocks can store shortest separating prefix

[kudu-CR] KUDU-1398 CFile index blocks can store shortest separating prefix

2016-06-22 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3304 to look at the new patch set (#9). Change subject: KUDU-1398 CFile index blocks can store shortest separating prefix

[kudu-CR] KUDU-1398 CFile index blocks can store shortest separating prefix

2016-06-20 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1398 CFile index blocks can store shortest separating prefix .. Patch Set 6: > Sorry for the delay on this, Will. I was on PTO the last couple of >

[kudu-CR] KUDU-1398 CFile index blocks can store shortest separating prefix

2016-06-08 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3304 to look at the new patch set (#5). Change subject: KUDU-1398 CFile index blocks can store shortest separating prefix

[kudu-CR] [WIP] KUDU-1398 CFile index blocks can store shortest separating prefix

2016-06-04 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3304 to look at the new patch set (#3). Change subject: [WIP] KUDU-1398 CFile index blocks can store shortest separating prefix

[kudu-CR] [WIP] KUDU-1398 CFile index blocks can store shortest separating prefix

2016-06-03 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3304 to look at the new patch set (#2). Change subject: [WIP] KUDU-1398 CFile index blocks can store shortest separating prefix

[kudu-CR] KUDU-1446 Consider data types in predicate evaluation order

2016-06-03 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3298 to look at the new patch set (#3). Change subject: KUDU-1446 Consider data types in predicate evaluation order ..

[kudu-CR] KUDU-1446 Consider data types in predicate evaluation order

2016-06-03 Thread Will Berkeley (Code Review)
Will Berkeley has abandoned this change. Change subject: KUDU-1446 Consider data types in predicate evaluation order .. Abandoned unintentional dupe -- To view, visit http://gerrit.cloudera.org:8080/3300 To unsubscribe,

[kudu-CR] KUDU-1446 Consider data types in predicate evaluation order

2016-06-03 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/3298 Change subject: KUDU-1446 Consider data types in predicate evaluation order .. KUDU-1446 Consider data types in predicate evaluation

[kudu-CR] Dependency on Hadoop test classes causes impertinent Javadoc warnings

2016-05-24 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/3199 Change subject: Dependency on Hadoop test classes causes impertinent Javadoc warnings .. Dependency on Hadoop test classes causes

[kudu-CR] KUDU-1386 NaN float and double values are not handled correctly

2016-05-24 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1386 NaN float and double values are not handled correctly .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3142/2/src/kudu/common/types.h