[kudu-CR] Add a way to dump ResultTracker state

2016-07-12 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: Add a way to dump ResultTracker state
..


Patch Set 10:

Build Started http://104.196.14.100/job/kudu-gerrit/2373/

-- 
To view, visit http://gerrit.cloudera.org:8080/3569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1
Gerrit-PatchSet: 10
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Add a way to dump ResultTracker state

2016-07-12 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: Add a way to dump ResultTracker state
..


Patch Set 7:

Build Started http://104.196.14.100/job/kudu-gerrit/2342/

-- 
To view, visit http://gerrit.cloudera.org:8080/3569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Add a way to dump ResultTracker state

2016-07-12 Thread David Ribeiro Alves (Code Review) 
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3569

to look at the new patch set (#7).

Change subject: Add a way to dump ResultTracker state
..

Add a way to dump ResultTracker state

This adds a way to dump result tracker state and makes sure we use it when
FATAling out on CHECK failures.

Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1
---
M src/kudu/rpc/result_tracker.cc
M src/kudu/rpc/result_tracker.h
2 files changed, 69 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/3569/7
-- 
To view, visit http://gerrit.cloudera.org:8080/3569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Add a way to dump ResultTracker state

2016-07-08 Thread David Ribeiro Alves (Code Review) 
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3569

to look at the new patch set (#6).

Change subject: Add a way to dump ResultTracker state
..

Add a way to dump ResultTracker state

This adds a way to dump result tracker state and makes sure we use it when
FATAling out on CHECK failures.

Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1
---
M src/kudu/rpc/result_tracker.cc
M src/kudu/rpc/result_tracker.h
2 files changed, 70 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/3569/6
-- 
To view, visit http://gerrit.cloudera.org:8080/3569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Add a way to dump ResultTracker state

2016-07-08 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: Add a way to dump ResultTracker state
..


Patch Set 6:

Build Started http://104.196.14.100/job/kudu-gerrit/2290/

-- 
To view, visit http://gerrit.cloudera.org:8080/3569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Add a way to dump ResultTracker state

2016-07-08 Thread David Ribeiro Alves (Code Review) 
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3569

to look at the new patch set (#5).

Change subject: Add a way to dump ResultTracker state
..

Add a way to dump ResultTracker state

This adds a way to dump result tracker state and makes sure we use it when
FATAling out on CHECK failures.

Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1
---
M src/kudu/rpc/result_tracker.cc
M src/kudu/rpc/result_tracker.h
2 files changed, 70 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/3569/5
-- 
To view, visit http://gerrit.cloudera.org:8080/3569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Add a way to dump ResultTracker state

2016-07-08 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: Add a way to dump ResultTracker state
..


Patch Set 5:

Build Started http://104.196.14.100/job/kudu-gerrit/2288/

-- 
To view, visit http://gerrit.cloudera.org:8080/3569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Add a way to dump ResultTracker state

2016-07-08 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: Add a way to dump ResultTracker state
..


Patch Set 4:

Build Started http://104.196.14.100/job/kudu-gerrit/2287/

-- 
To view, visit http://gerrit.cloudera.org:8080/3569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Add a way to dump ResultTracker state

2016-07-08 Thread David Ribeiro Alves (Code Review) 
David Ribeiro Alves has uploaded a new patch set (#3).

Change subject: Add a way to dump ResultTracker state
..

Add a way to dump ResultTracker state

This adds a way to dump result tracker state and makes sure we use it when
FATAling out on CHECK failures.

Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1
---
M src/kudu/rpc/result_tracker.cc
M src/kudu/rpc/result_tracker.h
2 files changed, 70 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/3569/3
-- 
To view, visit http://gerrit.cloudera.org:8080/3569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Add a way to dump ResultTracker state

2016-07-08 Thread David Ribeiro Alves (Code Review) 
David Ribeiro Alves has posted comments on this change.

Change subject: Add a way to dump ResultTracker state
..


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/3569/2/src/kudu/rpc/result_tracker.cc
File src/kudu/rpc/result_tracker.cc:

Line 329: string ResultTracker::DumpStateToString() {
> rename to 'ToStringUnlocked'?
Done


Line 333: result.append(Substitute("\n\tClient: $0, $1", cs.first, 
cs.second->ToString()));
> can use SubstituteAndAppend
Done


Line 344: result.append(Substitute("\n\tCompletion Record: $0, $1", 
completion_record.first,
> same
Done


Line 356: result.append(Substitute("\n\t$0", orpc.ToString()));
> same
Done


http://gerrit.cloudera.org:8080/#/c/3569/2/src/kudu/rpc/result_tracker.h
File src/kudu/rpc/result_tracker.h:

Line 217: std::string ToString();
> should this (and probably others) be const?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] Add a way to dump ResultTracker state

2016-07-06 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: Add a way to dump ResultTracker state
..


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/2192/

-- 
To view, visit http://gerrit.cloudera.org:8080/3569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Add a way to dump ResultTracker state

2016-07-05 Thread David Ribeiro Alves (Code Review) 
David Ribeiro Alves has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3569

Change subject: Add a way to dump ResultTracker state
..

Add a way to dump ResultTracker state

This adds a way to dump result tracker state and makes sure we use it when
FATAling out on CHECK failures.

Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1
---
M src/kudu/rpc/result_tracker.cc
M src/kudu/rpc/result_tracker.h
2 files changed, 60 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/3569/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves

[kudu-CR] Add a way to dump ResultTracker state

2016-07-05 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: Add a way to dump ResultTracker state
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2167/

-- 
To view, visit http://gerrit.cloudera.org:8080/3569
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No