[kudu-CR] Migrate from boost::optional to kudu::optional

[Mike Percy (Code Review)]

Mike Percy has abandoned this change.

Change subject: Migrate from boost::optional to kudu::optional
..


Abandoned

-- 
To view, visit http://gerrit.cloudera.org:8080/3513
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia46ba817d507af8b26add764dc3859364d15e0da
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 

[kudu-CR] Migrate from boost::optional to kudu::optional

[Mike Percy (Code Review)]

Mike Percy has posted comments on this change.

Change subject: Migrate from boost::optional to kudu::optional
..


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3513/1/src/kudu/tablet/memrowset.cc
File src/kudu/tablet/memrowset.cc:

Line 411: exclusive_upper_bound_ = 
spec->exclusive_upper_bound_key()->encoded_key();
Need to check w/ Todd on this but I think it should be fine to do it.


http://gerrit.cloudera.org:8080/#/c/3513/1/src/kudu/tserver/tablet_service.cc
File src/kudu/tserver/tablet_service.cc:

Line 670: return; }
Oops, inadvertent change, need to restore the newline before this brace.


http://gerrit.cloudera.org:8080/#/c/3513/1/src/kudu/tserver/ts_tablet_manager.cc
File src/kudu/tserver/ts_tablet_manager.cc:

Line 993:   Status delete_status = DeleteTabletData(meta, 
TABLET_DATA_TOMBSTONED, optional());
This should probably be replaced with nullopt


-- 
To view, visit http://gerrit.cloudera.org:8080/3513
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia46ba817d507af8b26add764dc3859364d15e0da
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: Yes

[kudu-CR] Migrate from boost::optional to kudu::optional

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: Migrate from boost::optional to kudu::optional
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2053/

-- 
To view, visit http://gerrit.cloudera.org:8080/3513
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia46ba817d507af8b26add764dc3859364d15e0da
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Migrate from boost::optional to kudu::optional

[Mike Percy (Code Review)]

Hello Adar Dembo,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/3513

to review the following change.

Change subject: Migrate from boost::optional to kudu::optional
..

Migrate from boost::optional to kudu::optional

Change-Id: Ia46ba817d507af8b26add764dc3859364d15e0da
---
M src/kudu/client/client.cc
M src/kudu/client/scan_predicate.cc
M src/kudu/client/scan_token-internal.cc
M src/kudu/client/table_alterer-internal.cc
M src/kudu/client/table_alterer-internal.h
M src/kudu/common/column_predicate.cc
M src/kudu/common/column_predicate.h
M src/kudu/common/partition-test.cc
M src/kudu/common/partition_pruner-test.cc
M src/kudu/common/partition_pruner.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/common/wire_protocol.h
M src/kudu/consensus/consensus.h
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/integration-tests/client_failover-itest.cc
M src/kudu/integration-tests/cluster_itest_util.cc
M src/kudu/integration-tests/cluster_itest_util.h
M src/kudu/integration-tests/delete_table-test.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/integration-tests/remote_bootstrap-itest.cc
M src/kudu/integration-tests/tablet_replacement-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/rpc/service_pool.cc
M src/kudu/rpc/service_queue-test.cc
M src/kudu/rpc/service_queue.cc
M src/kudu/rpc/service_queue.h
M src/kudu/tablet/composite-pushdown-test.cc
M src/kudu/tablet/memrowset.cc
M src/kudu/tablet/memrowset.h
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tablet/tablet_metadata.h
M src/kudu/tools/kudu-admin.cc
M src/kudu/tserver/tablet_peer_lookup.h
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/ts_tablet_manager.cc
M src/kudu/tserver/ts_tablet_manager.h
38 files changed, 168 insertions(+), 173 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/3513/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3513
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia46ba817d507af8b26add764dc3859364d15e0da
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Adar Dembo