---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33296/#review81308
---
include/mesos/mesos.proto
On April 23, 2015, 1:48 p.m., Michael Park wrote:
As of now, the tests seem to take a long time to complete. We should
investigate what the issue is before committing this patch.
I suspect this is due to the default allocation interval (1 secs by default).
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33295/#review81329
---
Please move the `*` for pointers to the left as per our style
On April 20, 2015, 6:56 p.m., Niklas Nielsen wrote:
docs/mesos-roadmap.md, line 11
https://reviews.apache.org/r/32996/diff/1/?file=921209#file921209line11
It sounds a bit hostile (it may just be me), how about something like
For comments and suggestions for the Mesos roadmap,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33491/
---
Review request for mesos.
Bugs: MESOS-719
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33490/#review81379
---
Bad patch!
Reviews applied: [33490]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33490/
---
(Updated April 23, 2015, 8:03 p.m.)
Review request for mesos, Adam B and Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32140/
---
(Updated April 23, 2015, 8:25 p.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33491/#review81407
---
Patch looks great!
Reviews applied: [33491]
All tests passed.
-
On April 23, 2015, 9:16 p.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 730
https://reviews.apache.org/r/33491/diff/1/?file=940552#file940552line730
I'm curious why you look at EPERM here, but not in the call to
`::setgid` above and
On April 9, 2015, 12:51 a.m., Adam B wrote:
docs/committing.md, line 18
https://reviews.apache.org/r/32998/diff/1/?file=921213#file921213line18
Would like to formalize what kinds of changes you don't worry about
going through a review cycle. I'd propose that typo/comment/doc
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33452/#review81282
---
Ship it!
Ship It!
- Alexander Rojas
On April 22, 2015, 11:53
On April 15, 2015, 5:36 p.m., Alexander Rukletsov wrote:
src/common/resources.cpp, lines 93-105
https://reviews.apache.org/r/32140/diff/5/?file=920081#file920081line93
Can we replace it by
```
if !addable(left, right) {
return false;
}
```
? Or
13 matches
Mail list logo
