> On April 9, 2015, 12:51 a.m., Adam B wrote: > > docs/committing.md, line 18 > > <https://reviews.apache.org/r/32998/diff/1/?file=921213#file921213line18> > > > > Would like to formalize what kinds of changes you "don't worry about > > going through a review cycle". I'd propose that typo/comment/doc changes > > under 5 lines, or obvious build fixes are immune. Anything more complex > > than that deserves at least a cursory review.
I'm with you, although it will be tough to define the criteria for this, let alone enforce it. Use your judgement for now. :) > On April 9, 2015, 12:51 a.m., Adam B wrote: > > docs/effective-code-reviewing.md, line 13 > > <https://reviews.apache.org/r/32998/diff/1/?file=921214#file921214line13> > > > > Keep in mind that the review Summary + Description gets used as the > > commit message, so don't put unnecessary fluff in there. > > The testing message doesn't go into the commit section, so it can be > > used for notes to the reviewers. > > Also, please provide details about the testing done and new tests > > added; hopefully more than just `make check`. Added a new bullet related to self-review before publishing, that captures some of this. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32998/#review79457 ----------------------------------------------------------- On April 9, 2015, 12:30 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32998/ > ----------------------------------------------------------- > > (Updated April 9, 2015, 12:30 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Jie Yu, Niklas Nielsen, > and Vinod Kone. > > > Bugs: MESOS-2581 > https://issues.apache.org/jira/browse/MESOS-2581 > > > Repository: mesos > > > Description > ------- > > "Committer's Guide" was too generic. This names the documents after "what" > the reader is looking for: doing effective reviews, and how to commit changes > (for committers only). > > > Diffs > ----- > > docs/committers-guide.md c016ee9cb3290d7788ed258904547b59bbea4f11 > docs/committing.md PRE-CREATION > docs/effective-code-reviewing.md PRE-CREATION > docs/home.md 6ab61f85aa7d62e0f19267b886dffb4e0aa826ea > > Diff: https://reviews.apache.org/r/32998/diff/ > > > Testing > ------- > > N/A > > > Thanks, > > Ben Mahler > >