---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36048/
---
(Updated July 3, 2015, 3:15 p.m.)
Review request for mesos and Till Toenshoff.
On July 2, 2015, 11:32 p.m., Ben Mahler wrote:
src/linux/cgroups.cpp, lines 2014-2027
https://reviews.apache.org/r/36106/diff/1/?file=997647#file997647line2014
Any reason you're not just re-using cgroups::stat here? I'd suggest
just calling cgroups::stat for now, should simplify
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36049/
---
(Updated July 3, 2015, 3:17 p.m.)
Review request for mesos and Till Toenshoff.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34646/
---
(Updated July 3, 2015, 2:24 p.m.)
Review request for mesos and Adam B.
Bugs:
On July 3, 2015, 10:29 a.m., Till Toenshoff wrote:
src/authorizer/authorizer.cpp, lines 17-28
https://reviews.apache.org/r/36049/diff/5/?file=998603#file998603line17
Great update! But it seems the comment is not applying, no?
The built-in authorizer factory
On July 2, 2015, 5:04 p.m., Marco Massenzio wrote:
CHANGELOG, line 11
https://reviews.apache.org/r/36152/diff/2/?file=998642#file998642line11
how about `beta` instead of `experimental`?
or should we functionally distinguish between `alpha` (which is what
experimental sounds
On July 3, 2015, 12:29 a.m., Ben Mahler wrote:
I chatted with Isabel on IRC and asked her to break apart this change into
more bite-sized chunks, so that we can do smaller reviews and get things
committed incrementally:
(1) Dummy /call handler on the master.
(2) Validation.
(3)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36152/#review90368
---
Ship it!
CHANGELOG (line 9)
On July 2, 2015, 11:44 p.m., Ben Mahler wrote:
src/linux/perf.cpp, line 496
https://reviews.apache.org/r/36114/diff/2/?file=998617#file998617line496
Sorry for the drive-by comment, but why not just have a single
'extract' that based on the 'Version' performs the necessary
On July 2, 2015, 11:32 p.m., Ben Mahler wrote:
src/linux/cgroups.cpp, lines 2014-2027
https://reviews.apache.org/r/36106/diff/1/?file=997647#file997647line2014
Any reason you're not just re-using cgroups::stat here? I'd suggest
just calling cgroups::stat for now, should simplify
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36173/
---
Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36048/
---
(Updated July 3, 2015, 9:49 a.m.)
Review request for mesos and Till Toenshoff.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36152/#review90325
---
Ship it!
Thanks Adam!
- Jie Yu
On July 2, 2015, 11:47 p.m.,
On July 3, 2015, 8:29 a.m., Till Toenshoff wrote:
Let's also update the description of this RR;
```
Adds and integrates helper classes needed to support an Authorizer
module. Also adds a flag to the master, allowing the selection of
an Authorizer module.
```
or maybe better `.. Authorizer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36048/
---
(Updated July 3, 2015, 9:56 a.m.)
Review request for mesos and Till Toenshoff.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36152/#review90319
---
Ship it!
Ship It!
- Bernd Mathiske
On July 2, 2015, 4:47 p.m.,
On July 2, 2015, 12:51 p.m., Alexander Rukletsov wrote:
src/tests/authorization_tests.cpp, lines 43-45
https://reviews.apache.org/r/36050/diff/4/?file=998232#file998232line43
Let's format it according to `clang-format`:
```
typedef ::testing::TypesLocalAuthorizer,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36152/#review90329
---
Ship it!
Ship It!
- Till Toenshoff
On July 2, 2015, 11:47 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36049/#review90341
---
src/master/flags.cpp (line 422)
19 matches
Mail list logo
