Review Request 36422: Fix incorrect glog link.

2015-07-11 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36422/ --- Review request for mesos and Adam B. Bugs: MESOS-2493

Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.

2015-07-11 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/ --- (Updated July 11, 2015, 8:45 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.

2015-07-11 Thread haosdent huang
On July 10, 2015, 11:20 p.m., Timothy Chen wrote: src/tests/docker_containerizer_tests.cpp, line 3114 https://reviews.apache.org/r/36185/diff/3/?file=1002346#file1002346line3114 What you suggested sounds fine. I think we need to comment on the top of the test what this tests

Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.

2015-07-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/#review91389 --- Patch looks great! Reviews applied: [36185] All tests passed. -

Re: Review Request 36181: Port CFS support to Docker Containerizer

2015-07-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36181/#review91391 --- Patch looks great! Reviews applied: [36181] All tests passed. -

Re: Review Request 35687: Added capabilities to state.json

2015-07-11 Thread Aditi Dixit
On July 9, 2015, 4:26 p.m., Vinod Kone wrote: src/master/http.cpp, lines 124-125 https://reviews.apache.org/r/35687/diff/2/?file=1003411#file1003411line124 were you not able to use 'foreach' here? foreach(FrameworkInfo::Capability capability,

Re: Review Request 34136: Add ContainerImage protobuf.

2015-07-11 Thread Ian Downes
On June 25, 2015, 3:32 p.m., Paul Brett wrote: include/mesos/mesos.proto, line 1221 https://reviews.apache.org/r/34136/diff/2/?file=989752#file989752line1221 Mesos info is optional, but if present can optionally contain an image? So what does a mesos present with a MesosInfo

Re: Review Request 34136: Add ContainerImage protobuf.

2015-07-11 Thread Ian Downes
On June 26, 2015, 2:57 p.m., Jiang Yan Xu wrote: include/mesos/mesos.proto, lines 1212-1214 https://reviews.apache.org/r/34136/diff/2/?file=989752#file989752line1212 Is it the intention that Image type is **defined** outside MesosInfo because DockerInfo can later reference it?

Re: Review Request 34135: Add filesystem/ isolators for persistent volumes.

2015-07-11 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34135/ --- (Updated July 11, 2015, 9:42 p.m.) Review request for mesos, Chi Zhang, Paul

Review Request 36428: Remove erroneous code for isolator modules.

2015-07-11 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36428/ --- Review request for mesos, Ben Mahler, Kapil Arya, and Timothy Chen.

Review Request 36429: Add filesystem/linux isolator for persistent volumes.

2015-07-11 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36429/ --- Review request for mesos, Jie Yu, Timothy Chen, and Vinod Kone. Repository:

Re: Review Request 34135: Add filesystem/ isolators for persistent volumes.

2015-07-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34135/#review91401 --- Bad patch! Reviews applied: [34908, 34136, 34137] Failed command:

Re: Review Request 36428: Remove erroneous code for isolator modules.

2015-07-11 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36428/#review91402 --- It looks like it was introduced in f511395e instead (unless I am

Re: Review Request 36428: Remove erroneous code for isolator modules.

2015-07-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36428/#review91403 --- Patch looks great! Reviews applied: [36428] All tests passed. -