Re: Review Request 39220: CMake: Added `slave/state.cpp` to Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39220/ --- (Updated Oct. 13, 2015, 6:36 p.m.) Review request for mesos, Artem

Re: Review Request 39262: Windows:[1/3] Moved `os::environ` -> `os::raw::environment`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39262/ --- (Updated Oct. 13, 2015, 6:36 p.m.) Review request for mesos, Artem

Re: Review Request 39218: Windows: Added support for `process/address.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39218/ --- (Updated Oct. 13, 2015, 6:35 p.m.) Review request for mesos, Artem

Re: Review Request 39202: CMake: Moved libevent, gmock, http-parser to CMake on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39202/#review102508 --- Ship it!

Re: Review Request 39037: Allow description empty in help information.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39037/#review102533 --- Ship it! Will get this committed shortly.

Re: Review Request 39096: CMake:[1/2] Moved `__WINDOWS__` flag definition to CompilationConfigure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39096/#review102541 --- cmake/CompilationConfigure.cmake (line 69)

Re: Review Request 38443: Added layerid information to ManifestResponse

> On Oct. 13, 2015, 12:27 a.m., Timothy Chen wrote: > > Ship It! Tim if this looks good to you can you commit? I'd like to work through the cleanup chain that follows this :) - Ben --- This is an automatically generated e-mail. To

Re: Review Request 37023: Add an endpoint that exposes component flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37023/#review102534 --- Ship it! Looks great, I made some minor comments about keeping

Re: Review Request 39018: Added JSON parsing for Resources.

> On Oct. 13, 2015, 5 p.m., Michael Park wrote: > > src/common/resources.cpp, line 361 > > > > > > I think it would be better to only support one way of doing things > > here. I would opt for the array format. Is

Re: Review Request 39300: Fixed flaky ReservationEndpointsTest.AvailableResources test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39300/#review102565 --- Ship it! Really appreciate the follow up, thanks Michael!

Re: Review Request 39250: Puller refactor: moved untar to a common place

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39250/ --- (Updated Oct. 14, 2015, 12:45 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 39097: CMake:[2/2] remove `__WINDOWS__` flag definition from Stout config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39097/#review102549 --- LGTM. - Artem Harutyunyan On Oct. 13, 2015, 11:26 a.m., Alex

Re: Review Request 39180: Windows: Added support for `stout/os/open.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39180/#review102557 --- LGTM.

Review Request 39300: Fixed flaky ReservationEndpointsTest.AvailableResources test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39300/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-3411

Re: Review Request 38874: Refactored executor struct in Agent for the Executor HTTP API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38874/ --- (Updated Oct. 14, 2015, 12:08 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 38874: Refactored executor struct in Agent for the Executor HTTP API

> On Oct. 7, 2015, 11:31 p.m., Ben Mahler wrote: > > src/slave/slave.hpp, line 583 > > > > > > Could you add the closed() method here to make this consistent with the > > scheduler's HttpConnection struct in the

Re: Review Request 38876: Added functionality to store a marker file to denote HTTP based executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38876/ --- (Updated Oct. 14, 2015, 12:08 a.m.) Review request for mesos, Ben Mahler,

Review Request 39297: Added support for recovering RunState for HTTP based executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39297/ --- Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.

Re: Review Request 39300: Fixed flaky ReservationEndpointsTest.AvailableResources test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39300/#review102568 --- Patch looks great! Reviews applied: [39300] All tests passed. -

Re: Review Request 37023: Add an endpoint that exposes component flags.

> On Oct. 13, 2015, 9:32 p.m., Ben Mahler wrote: > > Looks great, I made some minor comments about keeping the HELP constants > > consistent. But since the existing help strings are static PODs, I've > > updated them to become static functions and I've updated your patch to > > follow the

Re: Review Request 39018: Added JSON parsing for Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/#review102573 --- Patch looks great! Reviews applied: [39211, 39018] All tests

<    1   2