Re: Review Request 39102: Added documentation for JSON resources.

2015-10-17 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/ --- (Updated Oct. 17, 2015, 11:05 p.m.) Review request for mesos, Adam B and Neil

Re: Review Request 39202: CMake: Moved libevent, gmock, http-parser to CMake on Windows.

2015-10-17 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39202/#review103033 --- Ship it!

Re: Review Request 39209: Windows: Move ::UUID to stout::UUID to avoid namespace collision.

2015-10-17 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39209/#review103038 --- Ship it! Changing the summary to reflect the code change. -

Re: Review Request 39207: Windows: Move `write` to its own file, `stout/os/write.hpp`.

2015-10-17 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39207/#review103036 --- Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp

Re: Review Request 39182: Windows: Enable ip_tests.

2015-10-17 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39182/#review102170 --- Ship it!

Re: Review Request 39203: CMake: fixed typo in agent include directory configuration.

2015-10-17 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39203/#review103034 --- Ship it! - Joris Van Remoortere On Oct. 13, 2015, 6:29 p.m.,

Re: Review Request 39204: Windows: Added support for `stout/os/read.hpp`.

2015-10-17 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39204/#review103035 --- Ship it! - Joris Van Remoortere On Oct. 13, 2015, 6:29 p.m.,

Re: Review Request 39388: Explicitly set the `LIBPROCESS_IP` env variable for docker containers.

2015-10-17 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39388/ --- (Updated Oct. 17, 2015, 11:18 p.m.) Review request for mesos and Niklas

Re: Review Request 39210: Windows: Moved `realpath` to its own file, `stout/os/realpath.hpp`.

2015-10-17 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39210/#review103039 --- Ship it!

Re: Review Request 39102: Added documentation for JSON resources.

2015-10-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review103043 --- Patch looks great! Reviews applied: [39211, 39018, 39102] All

Re: Review Request 39384: Added docs for how developers should split their work into Git commits.

2015-10-17 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39384/#review103015 --- Ship it! Ship It! - Guangya Liu On 十月 16, 2015, 9:25 p.m.,

Re: Review Request 39398: Sync TaskStatus::Reason enumerations in v1 API.

2015-10-17 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39398/#review103016 --- Ship it! Ship It! - Guangya Liu On 十月 16, 2015, 4:43 p.m.,

Re: Review Request 39018: Added JSON parsing for Resources.

2015-10-17 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39018/#review103018 --- src/common/resources.cpp (line 274)

Re: Review Request 39102: Added documentation for JSON resources.

2015-10-17 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39102/#review103019 --- Looks good. But we need first make sure the backend code merged

Re: Review Request 39353: Fixed and added tests for docker image name parsing.

2015-10-17 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39353/#review103020 --- Thanks for adding this! Are you looking to also work on docker

Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39382/#review103024 --- Bad patch! Reviews applied: [39076, 39091, 39092, 39093, 39096,

Re: Review Request 39380: Windows: Added support for `stout/flags/flags.hpp`.

2015-10-17 Thread Alex Clemmer
> On Oct. 16, 2015, 8:15 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/parse.hpp, line 20 > > > > > > Is this addition related? > > > > (It's good to have nevertheless.)

Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39382/ --- (Updated Oct. 17, 2015, 6:54 p.m.) Review request for mesos, Artem

Re: Review Request 29551: Added "tests" target for make.

2015-10-17 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29551/#review103027 --- Ship it! Ship It! - Joris Van Remoortere On Oct. 14, 2015,

Re: Review Request 29550: Libprocess: Added "tests" target for make.

2015-10-17 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29550/#review103026 --- Ship it! Ship It! - Joris Van Remoortere On Oct. 14, 2015,

Re: Review Request 39398: Sync TaskStatus::Reason enumerations in v1 API.

2015-10-17 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39398/#review103029 --- Ship it! Ship It! - Joris Van Remoortere On Oct. 16, 2015,

Re: Review Request 39201: Included `stout/check.hpp` in `future.hpp`.

2015-10-17 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39201/#review103032 --- Ship it! - Joris Van Remoortere On Oct. 13, 2015, 6:28 p.m.,