Re: Review Request 41715: Support parsing url in libprocess.

2015-12-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41715/#review111887 --- Patch looks great! Reviews applied: [41715] Passed command:

Review Request 41715: Support parsing url in libprocess.

2015-12-25 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41715/ --- Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese. Repository:

Re: Review Request 41704: WIP: Added support for checking whether a given path is absolute.

2015-12-25 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41704/ --- (Updated Dec. 25, 2015, 6:13 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 41705: WIP: Added support for enforcing quota on (persistent) volumes (MESOS-4198).

2015-12-25 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41705/ --- (Updated Dec. 25, 2015, 6:15 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

2015-12-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review111904 --- Patch looks great! Reviews applied: [41597, 41681] Passed

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-25 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 26, 2015, 2:20 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

2015-12-25 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Dec. 26, 2015, 2:22 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41586: Partially enforced commit message guidelines with a hook.

2015-12-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41586/#review111901 --- Patch looks great! Reviews applied: [41584, 41586] Passed

Re: Review Request 41586: Partially enforced commit message guidelines with a hook.

2015-12-25 Thread Artem Harutyunyan
> On Dec. 24, 2015, 2:27 a.m., Adam B wrote: > > bootstrap, lines 22-23 > > > > > > Our general policy in C++ variable names is to avoid abbreviations, and > > I imagine that could apply to shell scripts too. > >

Re: Review Request 41584: Added commit message guidelines to docs.

2015-12-25 Thread Artem Harutyunyan
> On Dec. 19, 2015, 6:34 a.m., Till Toenshoff wrote: > > docs/submitting-a-patch.md, line 52 > > > > > > We actually do it a bit more differentiated. > > > > The `Summary` should be past tense, start with a

Re: Review Request 41586: Partially enforced commit message guidelines with a hook.

2015-12-25 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41586/ --- (Updated Dec. 25, 2015, 6:05 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 41705: WIP: Added support for enforcing quota on (persistent) volumes (MESOS-4198).

2015-12-25 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41705/#review111902 --- src/slave/containerizer/mesos/isolators/posix/disk.cpp (line 171)

Re: Review Request 41715: Support parsing url in libprocess.

2015-12-25 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41715/#review111903 --- Ship it! Verified that the parse method handles some conner cases