Review Request 42784: Allocator Benchmark: Pull resource parsing out of for loop.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42784/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 42789: Added support file to autogenerate docs from endpoint help strings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42789/ --- Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway. Repository:

Review Request 42790: Added documentation for all http endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42790/ --- Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway. Repository:

Review Request 42788: Fixed whitespace errors in help strings for 3rdparty/libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42788/ --- Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway. Repository:

Review Request 42787: Fixed whitespace errors in help strings for mesos/src.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42787/ --- Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway. Repository:

Re: Review Request 42791: Added link to Http Endpoints doc in home.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42791/ --- (Updated Jan. 26, 2016, 7:49 a.m.) Review request for mesos, Ben Mahler, Greg

Re: Review Request 42783: Fixed error message style in 'roles::validate'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42783/#review116280 --- Ship it! Ship It! - Guangya Liu On 一月 26, 2016, 5:39 a.m.,

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

> On Jan. 25, 2016, 8:43 a.m., Bernd Mathiske wrote: > > src/tests/health_check_tests.cpp, line 351 > > > > > > Instead of naked strings we should reuse a constant that we can change > > in one place. I think I'll

Re: Review Request 42784: Allocator Benchmark: Pull resource parsing out of for loop.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42784/#review116285 --- Ship it! Ship It! - Guangya Liu On 一月 26, 2016, 5:47 a.m.,

Re: Review Request 41772: Added helper function to flatten resources.

> On Jan. 20, 2016, 6:18 a.m., Joseph Wu wrote: > > src/common/resources.cpp, line 880 > > > > > > It should be fine to just name this `flatten`. > > > > You should also consider changing the parameter type

Review Request 42791: Added link to Http Endpoints doc in home.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42791/ --- Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway. Repository:

Re: Review Request 42594: Introduced framework registry operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42594/ --- (Updated Jan. 26, 2016, 7:54 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 42588: Added unit-test for `NetClsHandleMgr`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42588/ --- (Updated Jan. 26, 2016, 6:32 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 42783: Fixed error message style in 'roles::validate'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42783/#review116284 --- Patch looks great! Reviews applied: [42761, 42762, 42783]

Re: Review Request 42047: Specified the CgroupsNetClsIsolatorProcess class. This adds the ability to isolate a mesos container using the net_cls cgroup subsystem.

> On Jan. 15, 2016, 6 a.m., Cong Wang wrote: > > Why do we need netcls to regulate framework traffic on a per-container > > basis? Given the fact that a) the port range based filters already work and > > the code (see egress fq_codel) already exists b) we only have port range > > based

Re: Review Request 42490: Updated Presentaions.md and fixed two typos in support/hooks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42490/#review116300 --- Ship it! Ship It! - Guangya Liu On 一月 19, 2016, 8:51 a.m.,

Re: Review Request 42762: Improved performance of 'roles::validate'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42762/#review116269 --- Patch looks great! Reviews applied: [42761, 42762] Passed

Re: Review Request 41491: Exposed docker image manifest to mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/ --- (Updated Jan. 25, 2016, 9 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 42761: Resource Math: Substituted DeleteSubrange with Swap + RemoveLast.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42761/ --- (Updated Jan. 26, 2016, 5:38 a.m.) Review request for mesos and Michael Park.

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42288/#review116274 --- Ship it! Ship It! - Guangya Liu On 一月 26, 2016, 1:16 a.m.,

Re: Review Request 42586: Defined the NetClsHandleMgr class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/ --- (Updated Jan. 26, 2016, 6:11 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 42278: Fixed volume paths for command tasks with image.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42278/ --- (Updated Jan. 26, 2016, 6:37 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 42762: Improved performance of 'roles::validate'.

> On Jan. 26, 2016, 2:14 a.m., Anand Mazumdar wrote: > > src/common/roles.cpp, line 62 > > > > > > Not yours: Can we remove the period at the end of each of the error > > messages? > > > > We dump them with

Review Request 42783: Fixed error message style in 'roles::validate'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42783/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 42587: Implemented the `NetClsHandleMgr` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42587/ --- (Updated Jan. 26, 2016, 6:31 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 42784: Allocator Benchmark: Pull resource parsing out of for loop.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42784/#review116303 --- Patch looks great! Reviews applied: [42761, 42762, 42783, 42784]

Re: Review Request 42783: Fixed error message style in 'roles::validate'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42783/#review116276 --- Ship it! Ship It! - Anand Mazumdar On Jan. 26, 2016, 5:39

Re: Review Request 42761: Resource Math: Substituted DeleteSubrange with Swap + RemoveLast.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42761/#review116277 --- Ship it! Ship It! - Neil Conway On Jan. 26, 2016, 5:38

Re: Review Request 42784: Allocator Benchmark: Pull resource parsing out of for loop.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42784/#review116279 --- Ship it! Ship It! - Anand Mazumdar On Jan. 26, 2016, 5:47

Review Request 42786: Exposed the global 'help' process and added getter functions to it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42786/ --- Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway. Repository:

Re: Review Request 41772: Added helper function to flatten resources.

> On Jan. 19, 2016, 10:18 p.m., Joseph Wu wrote: > > src/common/resources.cpp, line 880 > > > > > > It should be fine to just name this `flatten`. > > > > You should also consider changing the parameter

Review Request 42780: Changed the NetClsIsolatorTest to check for net_cls handles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42780/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4345

Re: Review Request 42618: Modified the `cgroups/net_cls` isolator to use the `NetClsHandleMgr`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42618/ --- (Updated Jan. 26, 2016, 6:35 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 42751: Tweaked some resource test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42751/#review116289 --- src/tests/resources_tests.cpp (line 1603)

Re: Review Request 42603: Added an http::Authenticator factory.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42603/ --- (Updated Jan. 25, 2016, 1:44 p.m.) Review request for mesos, Alexander

Re: Review Request 42247: Made sure the container launcher terminated before we leave the test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42247/#review116093 --- Ship it! Ship It! - Guangya Liu On 一月 25, 2016, 2:35 p.m.,

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 25, 2016, 3:06 p.m.) Review request for mesos, Adam B, Neil

Re: Review Request 42247: Made sure the container launcher terminated before we leave the test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42247/ --- (Updated Jan. 25, 2016, 3:35 p.m.) Review request for mesos, Jan Schlicht and

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 25, 2016, 3:23 p.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41789: Expose the http::internal::request function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/ --- (Updated Jan. 25, 2016, 3:26 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 42648: Moved http authenticator initialization to main.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42648/ --- (Updated Jan. 25, 2016, 1:57 p.m.) Review request for mesos, Alexander

Review Request 42719: Add doc for weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/ --- Review request for mesos and Adam B. Bugs: MESOS-3945

Re: Review Request 42458: Made links to .md files consistent across documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42458/ --- (Updated Jan. 25, 2016, 1:50 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 42016: Windows: Apply patch.exe without elevation prompt

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42016/#review116138 --- 3rdparty/CMakeLists.txt (line 45)

Review Request 42735: Make commit-msg hook portable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42735/ --- Review request for mesos, Artem Harutyunyan and Ian Downes. Bugs: MESOS-4502

Re: Review Request 41772: Added helper function to flatten resources.

> On Jan. 19, 2016, 2:18 p.m., Joseph Wu wrote: > > src/common/resources.cpp, line 880 > > > > > > It should be fine to just name this `flatten`. > > > > You should also consider changing the parameter type

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42674/#review116149 --- Ship it! Ship It! - Jie Yu On Jan. 25, 2016, 7:18 p.m.,

Re: Review Request 42728: Changed code to add text description when Http call returns Forbidden.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42728/#review116153 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 41790: Add tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Jan. 25, 2016, 3:47 p.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41959: Statically initializing fetcher plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41959/#review116115 --- I am wondering if you do see performance issue regarding this? We

Re: Review Request 42719: Add doc for weights.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42719/#review116114 --- Patch looks great! Reviews applied: [42719] Passed command:

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 25, 2016, 3:36 p.m.) Review request for mesos, Adam B, Neil

Re: Review Request 42247: Made sure the container launcher terminated before we leave the test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42247/#review116097 --- Patch looks great! Reviews applied: [42247] Passed command:

Re: Review Request 42690: Moved ExecutorInfo and Option TaskInfo into ContainerConfig.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42690/ --- (Updated Jan. 25, 2016, 9:20 a.m.) Review request for mesos, Jie Yu and

Re: Review Request 42016: Windows: Apply patch.exe without elevation prompt

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42016/#review116126 --- Ship it! Ship It! - Yi Sun On Jan. 14, 2016, 12:43 a.m., M

Re: Review Request 41790: Add tests for /weights endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review116141 --- Patch looks great! Reviews applied: [41597, 41681, 41789, 41790]

Re: Review Request 41959: Statically initializing fetcher plugins.

> On Jan. 25, 2016, 5:12 p.m., Jie Yu wrote: > > I am wondering if you do see performance issue regarding this? We typically > > don't optimize the code too much until it becomes a problem. Also, we try > > to avoid global variable dependencies (i.e., static bool isCreateError in > > this

Review Request 42728: Changed code to add text description when Http call returns Forbidden.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42728/ --- Review request for mesos. Bugs: MESOS-4448

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42288/#review116139 --- Fix it, then Ship it! Ship It!

Re: Review Request 41959: Statically initializing fetcher plugins.

> On Jan. 25, 2016, 5:12 p.m., Jie Yu wrote: > > I am wondering if you do see performance issue regarding this? We typically > > don't optimize the code too much until it becomes a problem. Also, we try > > to avoid global variable dependencies (i.e., static bool isCreateError in > > this

Re: Review Request 42735: Make commit-msg hook portable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42735/#review116174 --- Patch looks great! Reviews applied: [42735] Passed command:

Re: Review Request 41959: Statically initializing fetcher plugins.

> On Jan. 25, 2016, 5:12 p.m., Jie Yu wrote: > > I am wondering if you do see performance issue regarding this? We typically > > don't optimize the code too much until it becomes a problem. Also, we try > > to avoid global variable dependencies (i.e., static bool isCreateError in > > this

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42674/#review116162 --- Ship it! Ship It! - Isabel Jimenez On Jan. 25, 2016, 7:18

Re: Review Request 41959: Statically initializing fetcher plugins.

> On Jan. 25, 2016, 5:12 p.m., Jie Yu wrote: > > I am wondering if you do see performance issue regarding this? We typically > > don't optimize the code too much until it becomes a problem. Also, we try > > to avoid global variable dependencies (i.e., static bool isCreateError in > > this

Re: Review Request 42733: Added checks for presence of `ReservationInfo.principal`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42733/#review116166 --- src/common/resources.cpp (line 66)

Re: Review Request 41959: Statically initializing fetcher plugins.

> On Jan. 25, 2016, 5:12 p.m., Jie Yu wrote: > > I am wondering if you do see performance issue regarding this? We typically > > don't optimize the code too much until it becomes a problem. Also, we try > > to avoid global variable dependencies (i.e., static bool isCreateError in > > this

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/#review116179 --- src/executor/executor.cpp (line 274)

Re: Review Request 42735: Make commit-msg hook portable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42735/#review116182 --- Can you please fix the other bash Linux-isms in this patch while

Review Request 42739: Accounted for reserved resources in the quota guarantee check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42739/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Review Request 42733: Added checks for presence of `ReservationInfo.principal`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42733/ --- Review request for mesos, Jie Yu, Michael Park, and Neil Conway. Repository:

Re: Review Request 41959: Statically initializing fetcher plugins.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41959/ --- (Updated Jan. 25, 2016, 9:19 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 41959: Statically initializing fetcher plugins.

> On Jan. 25, 2016, 5:12 p.m., Jie Yu wrote: > > I am wondering if you do see performance issue regarding this? We typically > > don't optimize the code too much until it becomes a problem. Also, we try > > to avoid global variable dependencies (i.e., static bool isCreateError in > > this

Re: Review Request 42662: Added common command utils file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42662/#review116116 --- Haven't looked at the tests yet. Will do another pass once the

Re: Review Request 42733: Added checks for presence of `ReservationInfo.principal`.

> On Jan. 25, 2016, 9:05 p.m., Neil Conway wrote: > > src/common/resources.cpp, line 66 > > > > > > This is actually correct as written, no? i.e., if principal isn't set, > > `principal()` will return the empty

Re: Review Request 42746: Updated the allocator to offer revocable resources beyond quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42746/ --- (Updated Jan. 25, 2016, 10:08 p.m.) Review request for mesos and Joris Van

Re: Review Request 42662: Added common command utils file.

> On Jan. 25, 2016, 9:45 p.m., Jie Yu wrote: > > src/common/command_utils.cpp, line 46 > > > > > > We try to avoid using Option> since the semantics is not > > clear between None() and an empty vector. >

Re: Review Request 42662: Added common command utils file.

> On Jan. 25, 2016, 9:45 p.m., Jie Yu wrote: > > src/common/command_utils.cpp, line 46 > > > > > > We try to avoid using Option> since the semantics is not > > clear between None() and an empty vector. >

Review Request 42750: Used `std::any_of` instead of `std::count_if` when validating IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42750/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 42751: Tweaked some resource test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42751/ --- Review request for mesos. Repository: mesos Description --- We should

Re: Review Request 42662: Added common command utils file.

> On Jan. 25, 2016, 9:45 p.m., Jie Yu wrote: > > src/common/command_utils.cpp, line 46 > > > > > > We try to avoid using Option> since the semantics is not > > clear between None() and an empty vector. >

Re: Review Request 42662: Added common command utils file.

> On Jan. 25, 2016, 9:45 p.m., Jie Yu wrote: > > src/common/command_utils.cpp, lines 153-162 > > > > > > I don't think this check is necessary. We are basically checking what > > 'tar' will check later. Can you

Re: Review Request 42662: Added common command utils file.

> On Jan. 25, 2016, 9:45 p.m., Jie Yu wrote: > > src/common/command_utils.cpp, lines 153-162 > > > > > > I don't think this check is necessary. We are basically checking what > > 'tar' will check later. Can you

Re: Review Request 42662: Added common command utils file.

> On Jan. 25, 2016, 9:45 p.m., Jie Yu wrote: > > src/common/command_utils.cpp, line 46 > > > > > > We try to avoid using Option> since the semantics is not > > clear between None() and an empty vector. >

Re: Review Request 42662: Added common command utils file.

> On Jan. 25, 2016, 9:45 p.m., Jie Yu wrote: > > src/common/command_utils.cpp, line 46 > > > > > > We try to avoid using Option> since the semantics is not > > clear between None() and an empty vector. >

Re: Review Request 41911: Added a test case for corrupt packets.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41911/ --- (Updated Jan. 25, 2016, 11:01 p.m.) Review request for mesos, Ian Downes and

Re: Review Request 42754: Added support for labels to resource reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42754/ --- (Updated Jan. 25, 2016, 11:02 p.m.) Review request for mesos and Michael Park.

Review Request 42755: Added documentation for labeled reserved resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42755/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 42754: Added support for labels to resource reservations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42754/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 40851: Windows:[1/2] Updated zookeeper-3.4.5.patch to fix VS2015 build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40851/ --- (Updated Jan. 25, 2016, 11:21 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 42750: Used `std::any_of` instead of `std::count_if` when validating IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42750/#review116215 --- Patch looks great! Reviews applied: [42750] Passed command:

Re: Review Request 42662: Added common command utils file.

> On Jan. 25, 2016, 9:45 p.m., Jie Yu wrote: > > src/common/command_utils.cpp, line 46 > > > > > > We try to avoid using Option> since the semantics is not > > clear between None() and an empty vector. >

Re: Review Request 41911: Added a test case for corrupt packets

> On Jan. 20, 2016, 6:12 p.m., Ian Downes wrote: > > src/tests/containerizer/port_mapping_tests.cpp, line 1027 > > > > > > This function is doing a lot, both constructing the packet, opening a > > socket and

Re: Review Request 42662: Added common command utils file.

> On Jan. 25, 2016, 9:45 p.m., Jie Yu wrote: > > src/common/command_utils.cpp, line 46 > > > > > > We try to avoid using Option> since the semantics is not > > clear between None() and an empty vector. >

Re: Review Request 42733: Added checks for presence of `ReservationInfo.principal`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42733/#review116196 --- Patch looks great! Reviews applied: [42733] Passed command:

Re: Review Request 42662: Added common command utils file.

> On Jan. 25, 2016, 9:45 p.m., Jie Yu wrote: > > src/common/command_utils.cpp, line 46 > > > > > > We try to avoid using Option> since the semantics is not > > clear between None() and an empty vector. >

Re: Review Request 42751: Tweaked some resource test cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42751/ --- (Updated Jan. 25, 2016, 10:59 p.m.) Review request for mesos and Michael Park.

Review Request 42752: Fixed some typos in test case comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42752/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 42753: Allowed `createLabel` to take an optional "value".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42753/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 42757: Split os::memory() out into platform specific files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42757/ --- Review request for mesos and Ian Downes. Bugs: MESOS-4504

Re: Review Request 42674: Replaced busybox with alpine in docker tests.

> On Jan. 23, 2016, 5:40 p.m., Jie Yu wrote: > > Can you add more context in the description? Is that because there are too > > many links in busybox, causing issues with docker with brfts backend snce > > brfts backend has a limit on links? > > > > Also, can you do a sweep in the code base

  1   2   >