Re: Review Request 44314: Added authentication to http master endpoint tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44314/ --- (Updated March 3, 2016, 7:31 a.m.) Review request for mesos, Adam B and

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

> On March 3, 2016, 12:07 a.m., Avinash sridharan wrote: > > src/slave/flags.cpp, line 690 > > > > > > Maybe s/Directory path/Location ? I just followed the existing convention, please see the help message of

Re: Review Request 44186: Added authentication to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/#review121811 --- Ship it! Ship It! - Alexander Rojas On March 3, 2016, 8:22

Re: Review Request 44186: Added authentication to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/ --- (Updated March 3, 2016, 7:22 a.m.) Review request for mesos, Adam B and

Re: Review Request 44315: Do not traverse offer list if there is only one offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44315/ --- (Updated 三月 3, 2016, 7:01 a.m.) Review request for mesos, Anand Mazumdar,

Review Request 44315: Do not traverse offer list if there is only one offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44315/ --- Review request for mesos, Anand Mazumdar, Joris Van Remoortere, and Joseph Wu.

Review Request 44314: Added authentication to http master endpoint tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44314/ --- Review request for mesos, Adam B and Alexander Rojas. Repository: mesos

Re: Review Request 44186: Added authenticated to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/ --- (Updated March 3, 2016, 6:52 a.m.) Review request for mesos, Adam B and

Re: Review Request 44266: Rename event_call_framework.cpp to test_http_framework.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44266/ --- (Updated March 3, 2016, 6:49 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 44200: Add agent flags for specifying CNI plugin and config directories.

> On March 2, 2016, 1:03 a.m., Gilbert Song wrote: > > src/slave/flags.hpp, lines 132-133 > > > > > > Thinking about a proper naming. Consider remove `_dir`? I see there are already a couple of flags named with

Re: Review Request 44186: Added authentication to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44186/ --- (Updated March 2, 2016, 10:22 p.m.) Review request for mesos, Adam B and

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

> On March 2, 2016, 10:43 p.m., Klaus Ma wrote: > > src/master/http.cpp, lines 1999-2000 > > > > > > I think we can just remove `master->updateUnavailability(id, > > updated[id]);` here, so other machine will `UP`

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/ --- (Updated 三月 3, 2016, 6:05 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 44257: Upgrade protobuf to 2.6.1 to support PowerPC LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44257/#review121797 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

> On 三月 2, 2016, 7:40 p.m., Greg Mann wrote: > > Thanks Fan! I'm having a look at this now. Regarding the problems with > > review board not wanting to update your previous RR, it's probably because > > it didn't find the review URL in the commit message. In order to determine > > which RR it

Review Request 44313: Described "/maintanence/schedule" GET/POST in the two paragraph.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44313/ --- Review request for mesos, Joris Van Remoortere and Joseph Wu. Repository:

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/ --- (Updated 三月 3, 2016, 5:40 a.m.) Review request for mesos, Greg Mann, Guangya

Re: Review Request 44071: Added documentation for new libprocess environment variable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44071/#review121779 --- Ship it! docs/configuration.md (lines 1694 - 1700)

Re: Review Request 44073: Disabled metrics endpoint rate limiting in mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44073/#review121780 --- This patch should also remove any remnants of advancing the clock

Re: Review Request 44070: Allowed disabling metrics endpoint rate limiting via the environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44070/#review121768 --- Thanks for the patience, I left some comments for some issues

Review Request 44257: Upgrade protobuf to 2.6.1 to support PowerPC LE platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44257/ --- Review request for mesos. Bugs: MESOS-4804

Re: Review Request 44266: Rename event_call_framework.cpp to test_http_framework.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44266/#review121789 --- src/tests/event_call_framework_test.sh (line 42)

Re: Review Request 44266: Rename event_call_framework.cpp to test_http_framework.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44266/#review121788 --- Fix it, then Ship it! src/tests/examples_tests.cpp (line 27)

Re: Review Request 44266: Rename event_call_framework.cpp to test_http_framework.cpp.

> On March 3, 2016, 1 a.m., Vinod Kone wrote: > > Looks great. > > > > Can you also rename the class name in test_http_framework.cpp? > > s/EventCallScheduler/HTTPScheduler/ > > Yong Tang wrote: > Thanks Vinod. Will update the review request shortly. Just updated the review request. Let

Re: Review Request 44266: Rename event_call_framework.cpp to test_http_framework.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44266/ --- (Updated March 3, 2016, 4:27 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review121781 --- Bad patch! Reviews applied: [43615, 43630, 43629, 43614, 43613]

Re: Review Request 44266: Rename event_call_framework.cpp to test_http_framework.cpp.

> On March 3, 2016, 1 a.m., Vinod Kone wrote: > > Looks great. > > > > Can you also rename the class name in test_http_framework.cpp? > > s/EventCallScheduler/HTTPScheduler/ Thanks Vinod. Will update the review request shortly. - Yong

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44258/#review121770 --- src/master/http.cpp (lines 1999 - 2000)

Re: Review Request 44258: Fixed http endpoint trigger two inverse offer calls.

> On March 2, 2016, 6:43 a.m., Klaus Ma wrote: > > src/master/http.cpp, lines 1999-2000 > > > > > > I think we can just remove `master->updateUnavailability(id, > > updated[id]);` here, so other machine will `UP`

Re: Review Request 41632: Windows: Forked signal handling in `signalhandler.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41632/ --- (Updated March 3, 2016, 3 a.m.) Review request for mesos, Alex Naparu, Daniel

Re: Review Request 44239: Introduced copy fetcher plugin for file URIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44239/ --- (Updated March 3, 2016, 2:02 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 43969: Added test for Appc image fetcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43969/#review121769 --- Ship it! Ship It! - Jie Yu On March 2, 2016, 9:47 p.m.,

Re: Review Request 44239: Introduced copy fetcher plugin for file URIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44239/ --- (Updated March 3, 2016, 1:47 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 44275: Fixed flakiness in tests using the scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44275/#review121767 --- Patch looks great! Reviews applied: [44273, 44274, 44275]

Re: Review Request 44278: Added HTTP scheduler stream IDs.

> On March 3, 2016, 1:37 a.m., Vinod Kone wrote: > > src/master/http.cpp, lines 458-462 > > > > > > should these be BadRequest as well? I think `Forbidden` is more apt here. _There is nothing wrong with the request

Re: Review Request 44279: Added stream IDs to the HTTP API docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44279/#review121766 --- Ship it! Ship It! - Vinod Kone On March 2, 2016, 8:59 p.m.,

Re: Review Request 44290: Added tests involving HTTP scheduler stream IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44290/#review121764 --- Fix it, then Ship it! src/tests/scheduler_http_api_tests.cpp

Re: Review Request 44278: Added HTTP scheduler stream IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44278/#review121756 --- src/master/http.cpp (line 440)

Re: Review Request 44275: Fixed flakiness in tests using the scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44275/ --- (Updated March 3, 2016, 1:31 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 44275: Fixed flakiness in tests using the scheduler library.

> On March 3, 2016, 1:10 a.m., Vinod Kone wrote: > > src/tests/mesos.hpp, lines 992-994 > > > > > > MESOS-4029 is talking about a bunch of issues. The final thing it says > > is to use a shared_ptr. There is

Re: Review Request 44274: Added the ability to stop running the scheduler library process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44274/ --- (Updated March 3, 2016, 1:30 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 44274: Added the ability to stop running the scheduler library process.

> On March 2, 2016, 11:59 p.m., Vinod Kone wrote: > > src/scheduler/scheduler.cpp, line 463 > > > > > > don't you need to guard this with !running.load() check? To be more precise, I moved all the `running.load()`

Re: Review Request 44273: Modified scheduler tests to use the callback interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44273/ --- (Updated March 3, 2016, 1:29 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 44298: Added support for file URI in Appc fetcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44298/#review121760 --- Ship it! Ship It! - Jie Yu On March 2, 2016, 9:47 p.m.,

Re: Review Request 44239: Introduced copy fetcher plugin for file URIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44239/#review121758 --- Fix it, then Ship it! src/uri/fetchers/copy.cpp (line 85)

Re: Review Request 44251: Improved allocator perf for labeled reservations and volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44251/#review121757 --- Ship it! Ship It! - Joris Van Remoortere On March 2, 2016,

Re: Review Request 44275: Fixed flakiness in tests using the scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44275/#review121754 --- src/tests/mesos.hpp (lines 992 - 994)

Re: Review Request 44266: Rename event_call_framework.cpp to test_http_framework.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44266/#review121753 --- Looks great. Can you also rename the class name in

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/ --- (Updated March 2, 2016, 4:05 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 44274: Added the ability to stop running the scheduler library process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44274/#review121747 --- include/mesos/v1/scheduler.hpp (line 86)

Re: Review Request 44273: Modified scheduler tests to use the callback interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44273/#review121745 --- Fix it, then Ship it! Thanks for the cleanup.

Re: Review Request 44070: Allowed disabling metrics endpoint rate limiting via the environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44070/#review121743 --- 3rdparty/libprocess/src/metrics/metrics.cpp (lines 197 - 199)

Re: Review Request 44286: Unified/Added Future checks for http methods in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44286/#review121742 --- Patch looks great! Reviews applied: [44286] Passed command:

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review121707 --- Looks good! A couple small comments. docs/monitoring.md (line

Re: Review Request 44278: Added HTTP scheduler stream IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44278/ --- (Updated March 2, 2016, 10:36 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 44290: Added tests involving HTTP scheduler stream IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44290/ --- (Updated March 2, 2016, 10:20 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 44278: Added HTTP scheduler stream IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44278/#review121728 --- Looks good. Mostly comments around having explicit `CHECK`'s if

Review Request 44299: Added unit test for file URI fetcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44299/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 43969: Added test for Appc image fetcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43969/ --- (Updated March 2, 2016, 9:47 p.m.) Review request for mesos and Jie Yu.

Review Request 44298: Added support for file URI in Appc fetcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44298/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4822

Re: Review Request 43629: Especially updated tests to use the updated MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43629/ --- (Updated March 2, 2016, 1:45 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

> On March 1, 2016, 5:56 a.m., Bernd Mathiske wrote: > > src/tests/cluster.cpp, line 97 > > > > > > The local assertions here do not stop the test outside the factory > > method from progressing. This hazard creates

Re: Review Request 43630: Especially updated scheduler tests to use the updated MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43630/ --- (Updated March 2, 2016, 1:45 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 44239: Introduced copy fetcher plugin for file URIs.

> On March 2, 2016, 3:26 p.m., Guangya Liu wrote: > > src/uri/fetchers/copy.cpp, line 72 > > > > > > Printing the `uri` in the failure may help improve the debug ability? The pattern is same as all other fetchers.

Re: Review Request 44280: Removed `FLAGS_v` assignment in test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44280/#review121727 --- Patch looks great! Reviews applied: [43684, 43685, 43686, 44250,

Re: Review Request 44239: Introduced copy fetcher plugin for file URIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44239/ --- (Updated March 2, 2016, 9:44 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 44290: Added tests involving HTTP scheduler stream IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44290/#review121721 --- Looks good. Just some minor cleanup comments.

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- (Updated March 2, 2016, 9:30 p.m.) Review request for mesos. Bugs:

Re: Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- (Updated March 2, 2016, 9:30 p.m.) Review request for mesos. Bugs:

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

> On March 2, 2016, 9:20 p.m., Joseph Wu wrote: > > Are you working with @mcavage? (See https://reviews.apache.org/r/43269/) > > > > Also, you might want to add this ticket to your reviews: > > https://issues.apache.org/jira/browse/MESOS-4610 That's correct. I'll update this with the ticket.

Re: Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/#review121719 --- Are you working with @mcavage? (See

Review Request 44289: Added support for contender and detector modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44289/ --- Review request for mesos. Repository: mesos Description --- Added

Review Request 44287: Added MasterContender and MasterDetector abstract classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44287/ --- Review request for mesos. Repository: mesos Description ---

Review Request 44288: Changed MasterDetector/Contender namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44288/ --- Review request for mesos. Repository: mesos Description --- Also

Re: Review Request 44275: Fixed flakiness in tests using the scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44275/ --- (Updated March 2, 2016, 9:08 p.m.) Review request for mesos and Vinod Kone.

Review Request 44290: Added tests involving HTTP scheduler stream IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44290/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-3583

Re: Review Request 44279: Added stream IDs to the HTTP API docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44279/ --- (Updated March 2, 2016, 8:59 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 44278: Added HTTP scheduler stream IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44278/ --- (Updated March 2, 2016, 8:58 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 44286: Unified/Added Future checks for http methods in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44286/ --- (Updated March 2, 2016, 8:53 p.m.) Review request for mesos, Adam B and

Re: Review Request 44273: Modified scheduler tests to use the callback interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44273/ --- (Updated March 2, 2016, 8:28 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 44269: Added the framework of 'network/cni' isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44269/#review121706 --- Patch looks great! Reviews applied: [44200, 44269] Passed

Re: Review Request 44255: Add metrics for {RESERVE, UNRESERVE, CREATE, DESTROY} offer operation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44255/#review121705 --- Thanks Fan! I'm having a look at this now. Regarding the problems

Re: Review Request 44279: Added stream IDs to the HTTP API docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44279/ --- (Updated March 2, 2016, 7:30 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 44220: Updated the CHANGELOG and doc about 'subscribe.force' field removal.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44220/#review121559 --- docs/scheduler-http-api.md (line 117)

Re: Review Request 44243: Updated master to ignore 'Subscribe.force' for HTTP framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44243/#review121697 --- Ship it! Ship It! - Greg Mann On March 2, 2016, 1:10 a.m.,

Re: Review Request 44251: Improved allocator perf for labeled reservations and volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44251/ --- (Updated March 2, 2016, 7:17 p.m.) Review request for mesos and Joris Van

Re: Review Request 44251: Improved allocator perf for labeled reservations and volumes.

> On March 2, 2016, 1:11 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1421 > > > > > > One suggestion is that does it make sense to update all variables > > including `scalar` to

Re: Review Request 44251: Improved allocator perf for labeled reservations and volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44251/ --- (Updated March 2, 2016, 7:15 p.m.) Review request for mesos and Joris Van

Re: Review Request 44278: Added HTTP scheduler stream IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44278/ --- (Updated March 2, 2016, 7:14 p.m.) Review request for mesos, Anand Mazumdar

Review Request 44278: Added HTTP scheduler stream IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44278/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-3583

Re: Review Request 43884: Added allocator metrics for used quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43884/#review121685 --- Patch looks great! Reviews applied: [44070, 44071, 44073, 44260,

Review Request 44280: Removed `FLAGS_v` assignment in test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44280/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Re: Review Request 44250: Added `Resources::createStrippedScalarQuantity()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44250/ --- (Updated March 2, 2016, 6:27 p.m.) Review request for mesos and Joris Van

Review Request 44275: Fixed flakiness in tests using the scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44275/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4029

Review Request 44274: Added the ability to stop running the scheduler library process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44274/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4029

Review Request 44273: Modified scheduler tests to use the callback interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44273/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4798

Re: Review Request 43614: Refactor MesosTest and remove cleanup logic.

> On March 2, 2016, 7:28 a.m., Bernd Mathiske wrote: > > src/tests/mesos.hpp, line 135 > > > > > > So this injection is allowed to be a shared_ptr and the others are not? > > This makes me wonder if it would not be

Re: Review Request 44260: Moved metrics of the hierarchical allocator to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44260/ --- (Updated March 2, 2016, 6:49 p.m.) Review request for mesos, Alexander

Re: Review Request 44070: Allowed disabling metrics endpoint rate limiting via the environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44070/ --- (Updated March 2, 2016, 6:48 p.m.) Review request for mesos, Alexander

Re: Review Request 43615: Update test suite to use the reworked MesosTest helpers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43615/#review121673 --- Bad patch! Reviews applied: [43615, 43630, 43629, 43614, 43613]

  1   2   >