Re: Review Request 45057: Made `unzip` overwrite existing files without prompting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45057/#review124442 --- Patch looks great! Reviews applied: [45057] Passed command:

Re: Review Request 45010: Fixed newlines for include directives.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45010/#review124440 --- Ship it! Ship It! - Jie Yu On March 18, 2016, 12:44 a.m.,

Re: Review Request 45057: Made `unzip` overwrite existing files without prompting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45057/#review124439 --- Fix it, then Ship it! Ship It! src/tests/fetcher_tests.cpp

Re: Review Request 44669: Added createFromModule methods to MasterContender and MasterDetector.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44669/ --- (Updated March 18, 2016, 12:29 a.m.) Review request for mesos and Benjamin

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

> On March 17, 2016, 4:09 p.m., Michael Park wrote: > > The patch looks good to me. Would you like to send an announcement email to > > the dev list about this upgrade? I can do it if you'd rather not. > > Yong Tang wrote: > Hi Michael, Thanks a lot for the help! I will send out the email

Re: Review Request 44082: Stout: Un-commented out functions and marked them as deleted instead.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44082/#review124263 --- Is this the right approach for all of them?

Re: Review Request 44944: Handled chunked responses in docker URI fetcher.

> On March 17, 2016, 3:44 p.m., James Peach wrote: > > Ship It! Verified that this patch fixes the chunked response parsing. - James --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 44851: Renamed an allocator metric.

> On March 18, 2016, 3:59 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/metrics.hpp, lines 40-42 > > > > > > Can you please file a JIRA to desribe the problem? Not quite catch why > > do we need to add a

Re: Review Request 44703: Added Doxygen docs for basic HTTP authenticator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44703/#review124154 --- Please be careful how you use "should" vs. "must" vs. "may". See

Re: Review Request 44949: Add XFS disk isolator tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44949/ --- (Updated March 18, 2016, 3:46 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44948: Add XFS disk resource isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44948/ --- (Updated March 17, 2016, 10:42 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 44874: Added support for FTS_SLNONE in rmdir.

> On March 16, 2016, 12:29 a.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp, line 222 > > > > > > Why is this a `string&` and `newDirectory` is a `string`? I'd think > > both

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/ --- (Updated March 20, 2016, 4:19 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 45002: Added FTS_PHYSICAL option to fts_open for rmdir.

> On March 20, 2016, 2:36 a.m., Neil Conway wrote: > > Per discussion in https://reviews.apache.org/r/45003/, if we can actually > > run into `FTS_SLNONE`, we should have a test-case for it. I dont think with FTS_PHYSICAL (and without FTW_COMFOLLOW) we will get FTS_SLNONE. I could be wrong

Re: Review Request 45003: Fixed rmdir comment for FTS_SLNONE as per coding guidelines.

> On March 20, 2016, 2:33 a.m., Neil Conway wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp, line 71 > > > > > > This comment seems incorrect: > > > > (1) The relevant

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45046/#review124436 --- Patch looks great! Reviews applied: [45046] Passed command:

Re: Review Request 44661: Deprecated the `docker_stop_timeout` flag.

> On March 15, 2016, 11:34 p.m., Ben Mahler wrote: > > Looking pretty good. Would be great to have a CHANGELOG update here that > > outlines the deprecation and what we're advising users to do in each > > version. I'll update the changelog in the next patch, hope this is fine. > On March

Re: Review Request 44421: Added support for "overlay" keyword.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/#review124206 --- src/linux/fs.hpp (lines 160 - 161)

Re: Review Request 44766: Enabled Authentication information in endpoint HELP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44766/#review124165 --- Ship it! Ship It! - Adam B On March 17, 2016, 10:32 a.m.,

Re: Review Request 44996: Fixed how we detect C++11 compiler support in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44996/#review124131 --- Ship it! Ship It! - Joris Van Remoortere On March 17, 2016,

Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-4828

Review Request 45013: Removed un-needed methods from command scheduler.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45013/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3559

Re: Review Request 43935: Allow setting role in mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43935/#review124007 --- Patch looks great! Reviews applied: [43935] Passed command:

Re: Review Request 45002: Added FTS_PHYSICAL option to fts_open for rmdir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45002/#review124434 --- Per discussion in https://reviews.apache.org/r/45003/, if we can

Re: Review Request 45078: MESOS-3902: Fix location header in redirect from non-leader.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45078/#review124435 --- Patch looks great! Reviews applied: [45078] Passed command:

Re: Review Request 45003: Fixed rmdir comment for FTS_SLNONE as per coding guidelines.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45003/#review124433 ---

Re: Review Request 44954: Regenerated master endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44954/ --- (Updated March 17, 2016, 5:33 p.m.) Review request for mesos, Adam B and Greg

Re: Review Request 44672: Added normalize method to registry puller.

> On 三月 19, 2016, 6:54 a.m., Shuai Lin wrote: > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp, line > > 182 > > > > > > I would suggest to add a new test for the `normalize` function. I

Re: Review Request 44892: Remove `Fetcher` in `Containerizer::create`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44892/ --- (Updated March 16, 2016, 5:56 p.m.) Review request for mesos and Till

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/#review124151 --- Needs more const references, but otherwise in nearly-shippable

Re: Review Request 44514: Implemented prepare() method of "network/cni" isolator.

> On March 17, 2016, 5:35 a.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.hpp, line 88 > > > > > > Should this be a `Result` instead of an `Option` ? Since either the > >

Re: Review Request 44549: Introduced a protobuf message "NetworkConfig".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44549/ --- (Updated March 17, 2016, 4:56 p.m.) Review request for mesos, Avinash

Re: Review Request 45033: Add a commit hook for checking non-ascii characters (MESOS-4033).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45033/#review124430 --- Patch looks great! Reviews applied: [45033] Passed command:

Re: Review Request 45057: Made `unzip` overwrite existing files without prompting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45057/ --- (Updated March 20, 2016, 12:05 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 44975: Updated cgroups test cases for cgroups device support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44975/#review124104 --- src/tests/containerizer/cgroups_tests.cpp (lines 1347 - 1349)

Re: Review Request 44909: Update containerizer construction in docker_containerizer_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44909/ --- (Updated March 16, 2016, 5:57 p.m.) Review request for mesos and Till

Review Request 45009: Transition `filesystem_tests.cpp` to use `path::join`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45009/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris

Re: Review Request 44421: Added support for "overlay" keyword.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44421/#review124214 --- Ship it! Ship It! - Gilbert Song On March 18, 2016, 9:22

Re: Review Request 44974: Added device support in cgroups abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44974/#review124265 --- src/linux/cgroups.hpp (line 629)

Re: Review Request 44653: Cleaned up formatting in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44653/ --- (Updated March 17, 2016, 11:28 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44853: Added benchmark test for the allocator metrics endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44853/ --- (Updated March 17, 2016, 3:49 p.m.) Review request for mesos, Alexander

Re: Review Request 44989: Fixed a race in the resource offers tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44989/#review124159 --- "The test is slowed considerably" - Can you provide some stats on

Re: Review Request 44883: Fix the mis-leading URI fetcher error message (MESOS-4954).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44883/#review123971 --- Ship it! Ship It! - Jie Yu On March 17, 2016, 1:52 a.m.,

Re: Review Request 43884: Added allocator metrics for used quotas.

> On March 17, 2016, 9:07 p.m., Ben Mahler wrote: > > docs/monitoring.md, lines 876-883 > > > > > > Thanks! How about: > > > > ``` > > > > > > allocator/mesos/quota//_allocated > >

Re: Review Request 44883: Fix the mis-leading URI fetcher error message (MESOS-4954).

> On March 16, 2016, 7:57 p.m., Anand Mazumdar wrote: > > LGTM. Thanks for putting out a patch for this. > > > > Can you also add Jie as a reviewer and as a shepherd to the JIRA? Thanks a lot Anand! Just updated the review request and also added Jie as the reviewer. Let me know if there is

Review Request 45039: Updated the scheduler `launchTasks()` comment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45039/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 37168: Add an example framework using dynamic reservation.

> On March 17, 2016, 2:27 a.m., Greg Mann wrote: > > src/examples/dynamic_reservation_framework.cpp, line 119 > > > > > > Could you clarify for me how the slave gets into the RESERVED state the > > first time? It

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44945/#review124239 --- configure.ac (line 923)

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/ --- (Updated March 18, 2016, 12:29 a.m.) Review request for mesos and Benjamin

Re: Review Request 44748: Stout: Added implementation of `read` that works on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44748/ --- (Updated March 17, 2016, 7:34 p.m.) Review request for mesos, Alex Naparu,

Review Request 45000: MESOS-3902: Fix in location header during redirect from non-leader.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45000/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 44767: Added authentication information to master endpoints.

> On March 14, 2016, 3:51 p.m., Greg Mann wrote: > > docs/endpoints/master/create-volumes.md, line 24 > > > > > > I wonder if the shorthand "iff" might be a bit too esoteric for these > > help strings? > > Joerg

Re: Review Request 44992: Reordered function declarations in `TestContainerizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44992/#review124294 --- Fix it, then Ship it! src/tests/containerizer.hpp (line 74)

Review Request 44911: Fix the issue related to --disable-optimize (MESOS-4621).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44911/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-4621

Re: Review Request 44922: Fixed the port mapping tests compile errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44922/#review123899 --- Ship it! Thanks! Didn't realize this file was not being built

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated March 17, 2016, 10:43 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 44766: Enabled Authentication information in endpoint HELP.

> On March 14, 2016, 8:28 a.m., Adam B wrote: > > 3rdparty/libprocess/src/help.cpp, line 43 > > > > > > What if this was a bool instead of a string? How many values do you > > expect? > > Greg Mann wrote: > I

Review Request 44992: Reordered function declarations in `TestContainerizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44992/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 45073: Restructured authentication.md to group common flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45073/#review124429 --- Patch looks great! Reviews applied: [44678, 44703, 44515, 44523,

Re: Review Request 44545: Separated standalone and zookeeper classes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44545/ --- (Updated March 18, 2016, 12:29 a.m.) Review request for mesos and Benjamin

Re: Review Request 44435: Fixed a bug that causes the task stuck in staging state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44435/#review124145 --- Fix it, then Ship it! Ship It!

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/#review124427 --- src/linux/xfs.cpp (line 17)

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45046/ --- (Updated March 19, 2016, 10:03 p.m.) Review request for mesos, Vinod Kone and

Re: Review Request 45046: Created URI.filename to name fetched files in sandbox where appropriate.

> On March 19, 2016, 10:07 a.m., Guangya Liu wrote: > > src/tests/fetcher_cache_tests.cpp, lines 690-691 > > > > > > blank line here I'd like to push back against this one -- I think adding a line break here (I

Review Request 45078: MESOS-3902: Fix location header in redirect from non-leader.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45078/ --- Review request for mesos, Ben Whitehead, Joris Van Remoortere, and Vinod Kone.

Review Request 44974: Added device support in cgroups abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44974/ --- Review request for mesos, Ben Mahler, Felix Abecassis, Kevin Klues, and Niklas

Review Request 44909: Update containerizer construction in docker_containerizer_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44909/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 44554: Added agent HTTP authentication to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44554/ --- (Updated March 17, 2016, 7:43 p.m.) Review request for mesos, Adam B,

Re: Review Request 33174: Fix for docker not configuring CFS quotas correctly

> On March 2, 2016, 2:55 p.m., Steve Niemitz wrote: > > @jieyu ping? Sorry about the delay. Just saw this. Will get to it today. Can you ping me using email directly next time. The volume of emails from rb is too large so I tend to ignore them. - Jie

Re: Review Request 44934: Updated mesos-execute to add support for Appc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44934/#review123991 --- src/cli/execute.cpp (line 241)

Re: Review Request 44767: Added authentication information to master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44767/#review124166 --- Ship it! Ship It! - Adam B On March 17, 2016, 4:57 a.m.,

Re: Review Request 44622: Introduced a protobuf message "NetworkResult".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44622/#review123974 --- Fix it, then Ship it!

Re: Review Request 44678: Modified basic HTTP authenticator creator to accept realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44678/ --- (Updated March 17, 2016, 7:39 p.m.) Review request for mesos, Adam B,

Re: Review Request 44906: Update containerizer construction in fetcher_cache_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44906/ --- (Updated March 16, 2016, 5:57 p.m.) Review request for mesos and Till

Re: Review Request 44945: Add autoconf tests for XFS project quotas.

> On March 18, 2016, 6:36 p.m., Jiang Yan Xu wrote: > > configure.ac, line 923 > > > > > > Sorry this should have been a continued discussion on > > https://reviews.apache.org/r/44342/#comment184051 but anyways: >

Re: Review Request 45067: Updated the long-lived-framework example.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45067/#review124425 --- Patch looks great! Reviews applied: [45067] Passed command:

Re: Review Request 44989: Fixed a race in the resource offers tests.

> On March 17, 2016, 11:16 p.m., Neil Conway wrote: > > src/tests/resource_offers_tests.cpp, line 63 > > > > > > Style-wise, do we want all tests to resume if they initially pause it? > > I think we do a mix of

Re: Review Request 44606: Returning `202` (Accepted) for /reserve and related endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44606/#review124249 --- Looks good to me. Couple of things before this can get committed.

Re: Review Request 44546: Moved functions in promises to a common header file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44546/ --- (Updated March 18, 2016, 12:29 a.m.) Review request for mesos and Benjamin

Re: Review Request 45057: Made `unzip` overwrite existing files without prompting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45057/#review124422 --- Fix it, then Ship it! Thanks for the patch! This looks great!

Re: Review Request 44823: Remove `SlaveState` in `DockerContainerizer` during recover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44823/ --- (Updated March 16, 2016, 11:26 a.m.) Review request for mesos and Till

Review Request 44991: Enabled mocking on `TestContainerizer::destroy`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44991/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 44946: Add utility functions to manipulate XFS project quotas.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44946/ --- (Updated March 18, 2016, 3:46 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 44975: Updated cgroups test cases for cgroups device support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44975/#review124110 --- Patch looks great! Reviews applied: [44974, 44975] Passed

Re: Review Request 44944: Handled chunked responses in docker URI fetcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44944/ --- (Updated March 17, 2016, 1:50 a.m.) Review request for mesos, Gilbert Song,

Review Request 44998: Fixed m4 macro to enable strict C++11 conformance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44998/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-4963

Re: Review Request 43613: Refactor cluster test helpers into self-contained objects.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43613/#review123785 --- Committed with the following formatting fixes.

Review Request 44893: Remove fetcher header file in containerizer.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44893/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 44767: Added authentication information to master endpoints.

> On March 14, 2016, 10:51 p.m., Greg Mann wrote: > > docs/endpoints/master/create-volumes.md, line 24 > > > > > > I wonder if the shorthand "iff" might be a bit too esoteric for these > > help strings? We actually

Re: Review Request 44707: Added validation for task's kill policy.

> On March 15, 2016, 8:35 p.m., Ben Mahler wrote: > > Could you add a corresponding test? Having it in the header should make > > this really easy :) Sure, but I'll write a more complex test than just unit testing the validation function. - Alexander

Re: Review Request 44379: Correctly parse perf stat format for non-vanilla 3.10 kernel.

Hey Fan, Left some comments, mostly I'm a bit confused by your comment that OS vendors can tweak the format. How did you know they only tweak it that particular way? Ben On Wed, Mar 9, 2016 at 11:53 PM, Mesos ReviewBot wrote: > This is an automatically generated

Re: Review Request 44547: Added functions in promises to the collect header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44547/ --- (Updated March 18, 2016, 12:29 a.m.) Review request for mesos and Benjamin

Re: Review Request 44543: Removed unnecessary MasterContender and MasterDetector definitions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44543/#review124284 --- src/master/contender.hpp (lines 16 - 17)

Re: Review Request 44555: Implemented the framework and create() method of "network/cni" isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44555/#review123973 --- Fix it, then Ship it!

Re: Review Request 44975: Updated cgroups test cases for cgroups device support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44975/#review124417 --- Patch looks great! Reviews applied: [44974, 44975] Passed

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/#review124207 --- src/slave/slave.cpp (line 677)

Review Request 44981: Marked some private `json` functions as `static`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44981/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 45006: Added `devolve` overloads for `v1::TaskStatus`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45006/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3559

Review Request 44897: Update containerizer construction in hook_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44897/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 44854: Added validation for executor's shutdown grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44854/ --- (Updated March 17, 2016, 11:34 p.m.) Review request for mesos and Ben Mahler.

  1   2   3   4   >