Re: Review Request 45951: Implemented http basic auth to get docker auth token.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45951/#review137104 --- Ship it! Ship It! - Jie Yu On June 11, 2016, 12:42 a.m.,

Re: Review Request 48570: Fixed docker fetcher plugin process indentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48570/#review137105 --- Ship it! Ship It! - Jie Yu On June 11, 2016, 12:42 a.m.,

Re: Review Request 47808: Added test for parsing docker config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47808/#review137103 --- Ship it! Ship It! - Jie Yu On June 11, 2016, 12:42 a.m.,

Re: Review Request 47806: Add docker config auth protobuf to docker spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47806/#review137101 --- Ship it! Ship It! - Jie Yu On June 11, 2016, 12:42 a.m.,

Re: Review Request 47807: Implemented parsing a docker config to a hashmap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47807/#review137102 --- Ship it! Ship It! - Jie Yu On June 11, 2016, 12:42 a.m.,

Re: Review Request 48062: Recalculated share when weight was updated.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48062/#review137100 --- Patch looks great! Reviews applied: [48579, 48062] Passed

Re: Review Request 48563: Fixed continuation logic in endpoint authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48563/ --- (Updated June 11, 2016, 4:28 a.m.) Review request for mesos and Adam B.

Re: Review Request 48566: Fixed continuation logic for sandbox authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48566/ --- (Updated June 11, 2016, 4:19 a.m.) Review request for mesos, Adam B and

Re: Review Request 48579: Reset "dirty" to false in sort().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48579/#review137099 --- src/master/allocator/sorter/drf/sorter.cpp (lines 137 - 142)

Review Request 48062: Recalculated share when weight was updated.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48062/ --- Review request for mesos, Benjamin Mahler and Klaus Ma. Bugs: MESOS-5601

Review Request 48579: Reset "dirty" to false in sort().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48579/ --- Review request for mesos, Benjamin Mahler and Klaus Ma. Bugs: MESOS-5600

Re: Review Request 48365: Bundled NVML headers for Nvidia GPU support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48365/ --- (Updated June 11, 2016, 3:37 a.m.) Review request for mesos and Benjamin

Re: Review Request 48376: Changed semantics for granting access to /dev/nvidiactl, etc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48376/#review137098 --- Bad patch! Reviews applied: [48376, 48375, 48374, 48373, 48372,

Re: Review Request 48364: Removed hard dependence on `libnvidia-ml.so` for Nvidia GPU support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48364/ --- (Updated June 11, 2016, 3:16 a.m.) Review request for mesos and Benjamin

Re: Review Request 48368: Changed major/minor device types for Nvidia GPUs to `unsigned int`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48368/ --- (Updated June 11, 2016, 3:06 a.m.) Review request for mesos and Benjamin

Re: Review Request 48366: Added auto-discovery of GPUs for Nvidia GPU support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48366/ --- (Updated June 11, 2016, 3:07 a.m.) Review request for mesos and Benjamin

Re: Review Request 48367: Added test to verify that GPU auto-discovery works.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48367/ --- (Updated June 11, 2016, 3:06 a.m.) Review request for mesos and Benjamin

Re: Review Request 48364: Removed hard dependence on `libnvidia-ml.so` for Nvidia GPU support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48364/ --- (Updated June 11, 2016, 3:07 a.m.) Review request for mesos and Benjamin

Re: Review Request 48369: Fixed comment in Nvidia GPU device isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48369/ --- (Updated June 11, 2016, 3:06 a.m.) Review request for mesos and Benjamin

Re: Review Request 48372: Updated `Containerizer::resources()` to use the `NvidiaGpuAllocator`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48372/ --- (Updated June 11, 2016, 3:05 a.m.) Review request for mesos and Benjamin

Re: Review Request 48365: Bundled NVML headers for Nvidia GPU support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48365/ --- (Updated June 11, 2016, 3:04 a.m.) Review request for mesos and Benjamin

Re: Review Request 48374: Added class to share Nvidia-specific components between containerizers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48374/ --- (Updated June 11, 2016, 3:05 a.m.) Review request for mesos and Benjamin

Re: Review Request 48373: Integrated the `NvidiaGpuAllocator` into the `NvidiaGpuIsolator`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48373/ --- (Updated June 11, 2016, 3:05 a.m.) Review request for mesos and Benjamin

Re: Review Request 48376: Changed semantics for granting access to /dev/nvidiactl, etc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48376/ --- (Updated June 11, 2016, 3:05 a.m.) Review request for mesos and Benjamin

Re: Review Request 48371: Added `NvidiaGpuAllocator` component.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48371/ --- (Updated June 11, 2016, 3:04 a.m.) Review request for mesos and Benjamin

Re: Review Request 48363: Moved 'isolators/cgroups/devices/gpus' to 'isolators/gpu'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48363/ --- (Updated June 11, 2016, 3:04 a.m.) Review request for mesos and Benjamin

Review Request 48578: Fixed bug with double destruction of cgroups devices subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48578/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-5582

Re: Review Request 48574: Added assertion for a write in CoordinatorTest.Elect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48574/#review137097 --- Patch looks great! Reviews applied: [48571, 48572, 48573, 48574]

Review Request 48572: Updated whitespace style in log replica tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48572/ --- Review request for mesos, Benjamin Mahler, Artem Harutyunyan, and Jie Yu.

Review Request 48574: Added assertion for a write in CoordinatorTest.Elect.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48574/ --- Review request for mesos, Benjamin Mahler, Artem Harutyunyan, and Jie Yu.

Review Request 48573: Added expectations for response types in log replica tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48573/ --- Review request for mesos, Benjamin Mahler, Artem Harutyunyan, and Jie Yu.

Review Request 48571: Added assertion for initialization success to the log replica tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48571/ --- Review request for mesos, Benjamin Mahler, Artem Harutyunyan, and Jie Yu.

Re: Review Request 47743: Supported private registry per-container in unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47743/#review137094 --- Bad patch! Reviews applied: [47743, 47742, 45952, 48570, 45951,

Re: Review Request 47743: Supported private registry per-container in unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47743/ --- (Updated June 10, 2016, 5:42 p.m.) Review request for mesos, Jie Yu and

Review Request 48570: Fixed docker fetcher plugin process indentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48570/ --- Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy

Re: Review Request 47742: Modified docker puller interface to pass credential.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47742/ --- (Updated June 10, 2016, 5:42 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 47808: Added test for parsing docker config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47808/ --- (Updated June 10, 2016, 5:42 p.m.) Review request for mesos, Artem

Re: Review Request 45952: Implemented support for passing agent default docker config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45952/ --- (Updated June 10, 2016, 5:42 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 47806: Add docker config auth protobuf to docker spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47806/ --- (Updated June 10, 2016, 5:42 p.m.) Review request for mesos, Artem

Re: Review Request 45951: Implemented http basic auth to get docker auth token.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45951/ --- (Updated June 10, 2016, 5:42 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 47807: Implemented parsing a docker config to a hashmap.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47807/ --- (Updated June 10, 2016, 5:42 p.m.) Review request for mesos, Artem

Re: Review Request 47668: Obtained uid/gids before changing filesystem root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47668/#review137088 --- src/launcher/executor.cpp (line 474)

Re: Review Request 47668: Obtained uid/gids before changing filesystem root.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47668/#review137092 --- Have you tested switch user on mac? - Jie Yu On May 26, 2016,

Re: Review Request 47374: Separated mesos test helpers into a separate library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47374/ --- (Updated June 10, 2016, 5:03 p.m.) Review request for mesos, Adam B, Artem

Re: Review Request 47667: Added stout functions to get and set supplementary groud ids.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47667/#review137083 --- 3rdparty/stout/include/stout/os/posix/su.hpp (line 177)

Re: Review Request 47666: Added stout functions to set uid and gid.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47666/#review137081 --- Ship it! Ship It! - Jie Yu On May 26, 2016, 8:55 p.m.,

Re: Review Request 47665: Passed image user to mesos containerizer launch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47665/#review137080 --- Container user is not supported for now. No need to do that

Re: Review Request 48566: Fixed continuation logic for sandbox authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48566/#review137078 --- Patch looks great! Reviews applied: [48563, 48566] Passed

Re: Review Request 48566: Fixed continuation logic for sandbox authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48566/#review137075 --- Fix it, then Ship it! LGTM! src/files/files.cpp (lines 723 -

Re: Review Request 48563: Fixed continuation logic in endpoint authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48563/#review137072 --- Fix it, then Ship it! Can you include the reason this

Re: Review Request 48566: Fixed continuation logic for sandbox authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48566/ --- (Updated June 10, 2016, 9:25 p.m.) Review request for mesos, Adam B and

Re: Review Request 48566: Fixed continuation logic for sandbox authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48566/ --- (Updated June 10, 2016, 9:22 p.m.) Review request for mesos, Adam B and

Re: Review Request 48563: Fixed continuation logic in endpoint authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48563/#review137071 --- Patch looks great! Reviews applied: [48563] Passed command:

Review Request 48563: Fixed continuation logic in endpoint authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48563/ --- Review request for mesos and Adam B. Bugs: MESOS-5587

Re: Review Request 47661: Improved the mesos containerizer windows related logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47661/#review137063 --- Ship it! Ship It! - Timothy Chen On May 26, 2016, 8:55

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review137062 --- Patch looks great! Reviews applied: [48094] Passed command:

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/ --- (Updated June 10, 2016, 7:13 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/ --- (Updated June 10, 2016, 6:45 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 48286: Implemented STOP_MAINTENANCE Call in v1 master API.

> On June 9, 2016, 10:56 p.m., Vinod Kone wrote: > > No tests for this and the previous review? Hi, @vinodkone. `START_MAINTENANCE` and `STOP_MAINTENANCE` are still in progress because I have some remain problems about api_tests.cpp as discussions in

Re: Review Request 45605: Introduced HTB class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45605/#review137040 --- Sorry about the long wait. I am now volunteer for shepherding

Re: Review Request 45605: Introduced HTB class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45605/ --- (Updated June 10, 2016, 5:57 p.m.) Review request for mesos, Ian Downes and

Re: Review Request 48257: Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.

> On June 9, 2016, 9:09 p.m., Joseph Wu wrote: > > src/master/http.cpp, line 662 > > > > > > Here it would make sense to use the `.then(serializer)`. As we discuss in http://search-hadoop.com/m/0Vlr6Uz9otVwkdv we

Re: Review Request 48552: Added the missed bracket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48552/#review137039 --- Ship it! Ship It! - Jie Yu On June 10, 2016, 1:24 p.m.,

Re: Review Request 48530: Moved working groups from wiki to page.

> On June 10, 2016, 4:25 p.m., Jie Yu wrote: > > In fact, for working groups, I would prefer adding that to the docs so that > > people can find/read it on github. It is also constantly changing, updating > > it in docs sounds easier than updating the website. What do you think? > > Tomasz

Re: Review Request 48438: Implement GET_AGENTS Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48438/#review137032 --- Ship it! Ship It! - haosdent huang On June 10, 2016, 1:16

Re: Review Request 48530: Moved working groups from wiki to page.

> On June 10, 2016, 4:25 p.m., Jie Yu wrote: > > In fact, for working groups, I would prefer adding that to the docs so that > > people can find/read it on github. It is also constantly changing, updating > > it in docs sounds easier than updating the website. What do you think? > > Tomasz

Re: Review Request 48530: Moved working groups from wiki to page.

> On Cze 10, 2016, 4:25 po południu, Jie Yu wrote: > > In fact, for working groups, I would prefer adding that to the docs so that > > people can find/read it on github. It is also constantly changing, updating > > it in docs sounds easier than updating the website. What do you think? So this

Re: Review Request 48530: Moved working groups from wiki to page.

> On Cze 10, 2016, 4:15 po południu, haosdent huang wrote: > > Verify this local and looks great for me. Another question, should we have > > a link to working-groups in community? Otherwise user could not find it > > except it remember the link 'http://mesos.apache.org/working-groups/'. I

Re: Review Request 48530: Moved working groups from wiki to page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48530/#review137027 --- In fact, for working groups, I would prefer adding that to the

Re: Review Request 48530: Moved working groups from wiki to page.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48530/#review137025 --- Verify this local and looks great for me. Another question,

Re: Review Request 48380: Updated CHANGELOG for libprocess HTTP authorization.

> On June 8, 2016, 8:34 p.m., Vinod Kone wrote: > > CHANGELOG, line 154 > > > > > > Is there an example in the user doc on what changes are specifically > > needed that can be linked here? There isn't such an

Re: Review Request 48380: Updated CHANGELOG for libprocess HTTP authorization.

> On June 8, 2016, 3:01 p.m., Joerg Schad wrote: > > CHANGELOG, line 149 > > > > > > Could you doublecheck that we added all newly authorized endpoints? I updated this with references to the other endpoints we

Re: Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

> On June 10, 2016, 5:47 a.m., Neil Conway wrote: > > Something else to consider here: this change means that frameworks will > > miss a `slaveLost()` signal that they care about in some circumstances. For > > example, suppose an agent has a persistent volume on an agent; the master > > fails

Re: Review Request 48380: Updated CHANGELOG for libprocess HTTP authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48380/ --- (Updated June 10, 2016, 4:04 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 48554: Fixed a GMock warning in scheduler failover test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48554/#review137004 --- Bad patch! Reviews applied: [48554] Failed command:

Re: Review Request 48552: Added the missed bracket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48552/#review136999 --- Patch looks great! Reviews applied: [48552] Passed command:

Re: Review Request 45574: Add `PerfEventSubsystem` for cgroups unified isolator.

> On June 6, 2016, 9:38 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 150-156 > > > > > > I see in this hashmap, the keys and values are exactly same, e.g., > >

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46158/#review136985 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp

Review Request 48554: Fixed a GMock warning in scheduler failover test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48554/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-5595

Review Request 48552: Added the missed bracket.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48552/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 47082: LostSlaveMessage should be sent to affected frameworks only.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47082/#review136992 --- Something else to consider here: this change means that