Re: Review Request 48610: Renamed docker spec helper functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48610/#review137233 --- Patch looks great! Reviews applied: [47806, 47807, 47808, 45951,

Review Request 48612: Removed conditional for of setting `--prefix=/`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48612/ --- Review request for mesos and Kapil Arya. Bugs: MESOS-5577

Re: Review Request 48594: Added bundled zookeeper to the module-dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48594/ --- (Updated June 13, 2016, 4:56 a.m.) Review request for mesos, Jie Yu and Kapil

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/#review137231 --- Patch looks great! Reviews applied: [45377, 36440] Passed

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/ --- (Updated 六月 13, 2016, 4:36 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 48604: Implemented docker spec helper to parse URL.

> On June 12, 2016, 8:25 p.m., Jie Yu wrote: > > Both are fixed by patch https://reviews.apache.org/r/48610/ - Gilbert --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48604/#review137218

Review Request 48610: Renamed docker spec helper functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48610/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 48593: Refactor Ranges Subtraction.

> On June 12, 2016, 9:32 a.m., Guangya Liu wrote: > > Hi Yanyan, can you please add some test cases for your code chage? You can > > refer to > > https://github.com/apache/mesos/blob/master/src/tests/values_tests.cpp for > > detail. > > > > You can take a look at > >

Re: Review Request 48593: Refactor Ranges Subtraction.

> On June 13, 2016, 3:40 a.m., Klaus Ma wrote: > > src/common/values.cpp, lines 411-419 > > > > > > Any data on performance improvement? Hi, Klaus, performance data is listed here:

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/ --- (Updated 六月 13, 2016, 3:43 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 48604: Implemented docker spec helper to parse URL.

> On June 12, 2016, 8:25 p.m., Jie Yu wrote: > > include/mesos/docker/spec.hpp, line 83 > > > > > > I would rename this to parseAuthConfig as well. Can you followup with a > > patch to do the renaming? Sure, I will

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

> On 六月 12, 2016, 7:10 p.m., Jie Yu wrote: > > src/docker/docker.cpp, lines 559-562 > > > > > > I don't get this check. if we end up here, has_host_path() is false and > > has_source() is false, why we bother

Re: Review Request 48593: Refactor Ranges Subtraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48593/#review137223 --- src/common/values.cpp (lines 401 - 409)

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/#review137222 --- Bad patch! Reviews applied: [47511] Failed command:

Re: Review Request 47396: Added aufs provisioning backend.

> On 六月 7, 2016, 2:09 a.m., Guangya Liu wrote: > > src/tests/environment.cpp, lines 492-495 > > > > > > I think that here also needs to be updated to use your new function > > `fs::aufs::supported()` to check

Re: Review Request 47396: Added aufs provisioning backend.

> On June 7, 2016, 2:09 a.m., Guangya Liu wrote: > > src/tests/environment.cpp, lines 492-495 > > > > > > I think that here also needs to be updated to use your new function > > `fs::aufs::supported()` to check

Re: Review Request 48605: Added docker spec test for parseUrl.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48605/#review137219 --- Ship it! Ship It! - Jie Yu On June 12, 2016, 7:08 p.m.,

Re: Review Request 48604: Implemented docker spec helper to parse URL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48604/#review137218 --- Fix it, then Ship it! include/mesos/docker/spec.hpp (line 83)

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/ --- (Updated 六月 13, 2016, 3:18 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 47396: Added aufs provisioning backend.

> On 六月 7, 2016, 2:09 a.m., Guangya Liu wrote: > > src/tests/environment.cpp, lines 492-495 > > > > > > I think that here also needs to be updated to use your new function > > `fs::aufs::supported()` to check

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/ --- (Updated 六月 13, 2016, 3:16 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

> On 六月 12, 2016, 6:57 p.m., Jie Yu wrote: > > docs/docker-volume-isolator.md, line 181 > > > > > > WHy operator? Updating to `framework developer` > On 六月 12, 2016, 6:57 p.m., Jie Yu wrote: > >

Re: Review Request 47396: Added aufs provisioning backend.

> On June 7, 2016, 2:09 a.m., Guangya Liu wrote: > > src/tests/environment.cpp, lines 492-495 > > > > > > I think that here also needs to be updated to use your new function > > `fs::aufs::supported()` to check

Re: Review Request 43561: Improve Ranges parsing to handle single values.

> On March 21, 2016, 10:02 p.m., Joris Van Remoortere wrote: > > src/common/values.cpp, lines 612-627 > > > > > > Should we add a benchmark here to understand the effect of now having 3 > > levels of `tokenize`? >

Re: Review Request 46375: Updated MACHINE_UP_HELP's comments.

> On April 20, 2016, 4:25 a.m., Joseph Wu wrote: > > Ship It! @Joseph, would you help to commit it? - Klaus --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46375/#review129614

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

> On June 11, 2016, 10:31 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 131 > > > > > > I think there is a special case that we need to handle: In the OS using > >

Re: Review Request 47743: Supported private registry per-container in unified containerizer.

> On June 12, 2016, 1:05 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [47743, 47742, 45952, 48605, 48604, 48570, 45951, 47808, > > 47807, 47806, 45950, 45949] > > > > Failed command: ./support/apply-review.sh -n -r 47807 > > > > Error: > > 2016-06-12 20:05:27

Re: Review Request 47806: Add docker config auth protobuf to docker spec.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47806/ --- (Updated June 12, 2016, 6:25 p.m.) Review request for mesos, Artem

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

> On June 2, 2016, 10:58 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, lines 105-106 > > > > > > Since this is a multiple lines code, I think you need to add a newline > >

Re: Review Request 45952: Implemented support for passing agent default docker config.

> On June 12, 2016, 6:08 p.m., Jie Yu wrote: > > src/uri/fetchers/docker.cpp, lines 647-649 > > > > > > I don't get this part. This is not what you're doing here, right? I > > think a request to authorization

Re: Review Request 47396: Added aufs provisioning backend.

> On 六月 7, 2016, 2:09 a.m., Guangya Liu wrote: > > src/tests/environment.cpp, lines 492-495 > > > > > > I think that here also needs to be updated to use your new function > > `fs::aufs::supported()` to check

Re: Review Request 47743: Supported private registry per-container in unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47743/#review137202 --- Bad patch! Reviews applied: [47743, 47742, 45952, 48605, 48604,

Re: Review Request 45952: Implemented support for passing agent default docker config.

> On June 12, 2016, 11:08 a.m., Jie Yu wrote: > > src/uri/fetchers/docker.cpp, lines 647-649 > > > > > > I don't get this part. This is not what you're doing here, right? I > > think a request to authorization

Re: Review Request 48580: Added test case `MasterAPITest.StartAndStopMaintenance`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48580/#review137200 --- Patch looks great! Reviews applied: [48115, 48116, 48257, 48084,

Re: Review Request 46762: Enabled volume support for mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46762/#review137199 --- src/cli/execute.cpp (line 239)

Re: Review Request 47743: Supported private registry per-container in unified containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47743/ --- (Updated June 12, 2016, 12:11 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 47742: Modified docker puller interface to pass credential.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47742/ --- (Updated June 12, 2016, 12:11 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 45952: Implemented support for passing agent default docker config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45952/ --- (Updated June 12, 2016, 12:11 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 36440: Enabled docker volume support for DockerContainerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36440/#review137198 --- include/mesos/mesos.proto (lines 1781 - 1783)

Review Request 48605: Added docker spec test for parseUrl.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48605/ --- Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy

Review Request 48604: Implemented docker spec helper to parse URL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48604/ --- Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, and Timothy

Re: Review Request 48570: Fixed docker fetcher plugin process indentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48570/ --- (Updated June 12, 2016, 12:06 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

> On June 11, 2016, 2:31 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 131 > > > > > > I think there is a special case that we need to handle: In the OS using > >

Re: Review Request 46428: Fixed the broken Docker Volume Rootfs Test on Centos7.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46428/#review137196 --- Ship it! Ship It! - Jie Yu On May 31, 2016, 12:49 a.m.,

Re: Review Request 45952: Implemented support for passing agent default docker config.

> On June 12, 2016, 6:08 p.m., Jie Yu wrote: > > src/uri/fetchers/docker.cpp, lines 647-649 > > > > > > I don't get this part. This is not what you're doing here, right? I > > think a request to authorization

Re: Review Request 47511: Added documentation for `docker/volume` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47511/#review137185 --- docs/docker-volume-isolator.md (line 2)

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

> On June 2, 2016, 2:58 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 97 > > > > > > Why make it a static variable? I think > > `CgroupsIsolatorProcess::create()` will

Re: Review Request 45952: Implemented support for passing agent default docker config.

> On June 12, 2016, 11:08 a.m., Jie Yu wrote: > > src/uri/fetchers/docker.cpp, lines 647-649 > > > > > > I don't get this part. This is not what you're doing here, right? I > > think a request to authorization

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48603/#review137187 --- Patch looks great! Reviews applied: [48583, 48584, 48585, 48587,

Re: Review Request 45952: Implemented support for passing agent default docker config.

> On June 12, 2016, 11:08 a.m., Jie Yu wrote: > > src/uri/fetchers/docker.cpp, lines 647-649 > > > > > > I don't get this part. This is not what you're doing here, right? I > > think a request to authorization

Re: Review Request 47396: Added aufs provisioning backend.

> On June 7, 2016, 2:09 a.m., Guangya Liu wrote: > > src/tests/environment.cpp, lines 492-495 > > > > > > I think that here also needs to be updated to use your new function > > `fs::aufs::supported()` to check

Re: Review Request 45952: Implemented support for passing agent default docker config.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45952/#review137183 --- Fix it, then Ship it! src/uri/fetchers/docker.cpp (lines 645

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48603/ --- (Updated June 12, 2016, 6:04 p.m.) Review request for mesos, Abhishek

Re: Review Request 48602: Implemented v1::master::Call::GET_METRICS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48602/ --- (Updated June 12, 2016, 6:04 p.m.) Review request for mesos, Abhishek

Re: Review Request 48601: Exposed metrics information via `process::metrics::snapshot`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48601/ --- (Updated June 12, 2016, 6:03 p.m.) Review request for mesos, Abhishek

Re: Review Request 48600: Used `DurationInfo` as `timeout` type in `GetMetrics` operation APIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48600/ --- (Updated June 12, 2016, 6:03 p.m.) Review request for mesos, Abhishek

Re: Review Request 48597: Implemented v1::agent::Call::SET_LOGGING_LEVEL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48597/ --- (Updated June 12, 2016, 6:02 p.m.) Review request for mesos, Abhishek

Re: Review Request 48595: Exposed the logging process `PID` in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48595/ --- (Updated June 12, 2016, 6:02 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48588: Devolved v1 operator protos to unversioned operator protos in Agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48588/ --- (Updated June 12, 2016, 6:01 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48596: Implemented v1::master::Call::SET_LOGGING_LEVEL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48596/ --- (Updated June 12, 2016, 6:02 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48587: Added unversioned protos for agent API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48587/ --- (Updated June 12, 2016, 6:01 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48583: Added `VersionInfo`, `Flag`, `Metrics` to unversioned mesos protos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48583/ --- (Updated June 12, 2016, 6 p.m.) Review request for mesos, Anand Mazumdar, zhou

Re: Review Request 48585: Devolved v1 operator protos to unversioned operator protos in Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48585/ --- (Updated June 12, 2016, 6:01 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48584: Added unversioned protos for master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48584/ --- (Updated June 12, 2016, 6:01 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 48084: Implemented v1::master::Call::GET_MAINTENANCE_STATUS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48084/ --- (Updated June 12, 2016, 5:57 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 48084: Implemented v1::master::Call::GET_MAINTENANCE_STATUS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48084/ --- (Updated June 12, 2016, 5:52 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 48259: Added test case `MasterAPITest.UpdateAndGetMaintenanceSchedule`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48259/ --- (Updated June 12, 2016, 5:52 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 48260: Added test case `MasterAPITest.GetMaintenanceStatus`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48260/ --- (Updated June 12, 2016, 5:52 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 48580: Added test case `MasterAPITest.StartAndStopMaintenance`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48580/ --- (Updated June 12, 2016, 5:47 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 48286: Implemented STOP_MAINTENANCE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48286/ --- (Updated June 12, 2016, 5:47 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 48259: Added test case `MasterAPITest.UpdateAndGetMaintenanceSchedule`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48259/ --- (Updated June 12, 2016, 5:46 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 48285: Implemented START_MAINTENANCE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48285/ --- (Updated June 12, 2016, 5:47 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 48084: Implemented v1::master::Call::GET_MAINTENANCE_STATUS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48084/ --- (Updated June 12, 2016, 5:46 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 48260: Added test case `MasterAPITest.GetMaintenanceStatus`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48260/ --- (Updated June 12, 2016, 5:47 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 48257: Implemented GET_MAINTENANCE_SCHEDULE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48257/ --- (Updated June 12, 2016, 5:46 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 48115: Added maintenance V1 header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48115/ --- (Updated June 12, 2016, 5:46 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 48116: Implemented UPDATE_MAINTENANCE_SCHEDULE Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48116/ --- (Updated June 12, 2016, 5:46 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 48084: Implemented v1::master::Call::GET_MAINTENANCE_STATUS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48084/ --- (Updated June 12, 2016, 5:44 p.m.) Review request for mesos, Joseph Wu and

Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48603/ --- Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.

Review Request 48602: Implemented v1::master::Call::GET_METRICS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48602/ --- Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.

Review Request 48601: Exposed metrics information via `process::metrics::snapshot`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48601/ --- Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.

Re: Review Request 48599: Fixed continuation logic in docker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48599/#review137179 --- Patch looks great! Reviews applied: [48598, 48599] Passed

Re: Review Request 48599: Fixed continuation logic in docker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48599/#review137178 --- Ship it! Ship It! - Joseph Wu On June 12, 2016, 9:05 a.m.,

Re: Review Request 48599: Fixed continuation logic in docker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48599/#review137177 --- Ship it! Ship It! - haosdent huang On June 12, 2016, 4:05

Re: Review Request 48599: Fixed continuation logic in docker.cpp.

> On June 12, 2016, 3:18 p.m., haosdent huang wrote: > > `src/files/files.cpp` have similar problems. > > > > In discription, `differen` shoud be `different`? > > Joerg Schad wrote: > If you mean > https://github.com/apache/mesos/blob/master/src/files/files.cpp#L591 that is > on my

Re: Review Request 48599: Fixed continuation logic in docker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48599/ --- (Updated June 12, 2016, 4:05 p.m.) Review request for mesos, Jie Yu and Joseph

Re: Review Request 48599: Fixed continuation logic in docker.cpp.

> On June 12, 2016, 3:18 p.m., haosdent huang wrote: > > `src/files/files.cpp` have similar problems. > > > > In discription, `differen` shoud be `different`? If you mean https://github.com/apache/mesos/blob/master/src/files/files.cpp#L591 that is on my investigation list, all other

Re: Review Request 48598: Added changes to upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48598/#review137173 --- Patch looks great! Reviews applied: [48598] Passed command:

Re: Review Request 48599: Fixed continuation logic in docker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48599/#review137172 --- `src/files/files.cpp` have similar problems. In discription,

Review Request 48599: Fixed continuation logic in docker.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48599/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5604

Re: Review Request 46158: Completed implementation of the cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46158/#review137145 --- src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp

Re: Review Request 48381: Updated CHANGELOG for 'work_dir' flag changes.

> On June 8, 2016, 1:10 p.m., Joerg Schad wrote: > > Should we add this as well to upgrades.md? > > Greg Mann wrote: > Yep, great idea! https://reviews.apache.org/r/48598/ - Joerg --- This is an automatically generated e-mail. To

Re: Review Request 48380: Updated CHANGELOG for libprocess HTTP authorization.

> On June 8, 2016, 1:10 p.m., Joerg Schad wrote: > > Should we add this as well to upgrades.md? > > Greg Mann wrote: > Yes! Thanks for thinking of this, Joerg! > > Joerg Schad wrote: > I will take care of that in another patch. https://reviews.apache.org/r/48598/ - Joerg

Review Request 48598: Added changes to upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48598/ --- Review request for mesos, Greg Mann and Vinod Kone. Repository: mesos

Re: Review Request 45363: Add `MemorySubsystem` for cgroups unified isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45363/#review137168 --- src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp

Re: Review Request 48595: Exposed the logging process `PID` in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48595/#review137163 --- Patch looks great! Reviews applied: [48583, 48584, 48585, 48587,

Review Request 48597: Implemented v1::agent::Call::SET_LOGGING_LEVEL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48597/ --- Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.

Review Request 48596: Implemented v1::master::Call::SET_LOGGING_LEVEL.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48596/ --- Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.

Re: Review Request 47374: Separated mesos test helpers into a separate library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47374/#review137162 --- src/Makefile.am (lines 1950 - 1951)

Review Request 48595: Exposed the logging process `PID` in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48595/ --- Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.

  1   2   >