Re: Review Request 46626: Added example framework for testing disk quota enforcement.

> On June 7, 2016, 2:10 p.m., Joseph Wu wrote: > > src/examples/disk_full_framework.cpp, lines 89-96 > > > > > > Looks like there are currently two scenarios: > > > > 1) Disk quota is enforced -> task fails.

Re: Review Request 46626: Added example framework for testing disk quota enforcement.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46626/ --- (Updated July 16, 2016, 8:30 p.m.) Review request for Joseph Wu. Bugs:

Re: Review Request 50108: Handled systems that miss /etc/hostname in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50108/#review142505 --- Fix it, then Ship it!

Re: Review Request 50107: Handled /etc/* file being dead links in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50107/#review142504 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 50102: Ignored /etc/* mounts to host filesystems if host network is used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50102/#review142503 --- Fix it, then Ship it! Ship It!

Re: Review Request 50108: Handled systems that miss /etc/hostname in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50108/#review142502 --- Ship it! Ship It! - Avinash sridharan On July 16, 2016,

Re: Review Request 50107: Handled /etc/* file being dead links in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50107/#review142501 --- Ship it! Ship It! - Avinash sridharan On July 16, 2016,

Re: Review Request 50108: Handled systems that miss /etc/hostname in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50108/#review142499 --- Ship it! Ship It! - Gilbert Song On July 16, 2016, 10:14

Re: Review Request 49921: Fixed mesos tests to run 723 test on Unix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49921/ --- (Updated July 16, 2016, 8:47 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49921: Fixed mesos tests to run 723 test on Unix.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49921/ --- (Updated July 16, 2016, 8:35 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49874: Added logrotate_container_logger for running mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49874/ --- (Updated July 16, 2016, 8:34 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50107: Handled /etc/* file being dead links in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50107/#review142498 --- Ship it! Ship It! - Gilbert Song On July 16, 2016, 10:13

Re: Review Request 49870: Added test executables required to run tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49870/ --- (Updated July 16, 2016, 8:34 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49863: Added Test Modules that are loaded by mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49863/ --- (Updated July 16, 2016, 8:34 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49862: Changed libmesos from static library to a shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/ --- (Updated July 16, 2016, 8:33 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49688: Added cmake build variables for mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/ --- (Updated July 16, 2016, 8:33 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49360: Supported TCP check in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/#review142497 --- Ship it! Ship It! - Tomasz Janiszewski On July 2, 2016,

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review142496 --- Ship it! Ship It! - Tomasz Janiszewski On July 2, 2016,

Re: Review Request 50108: Handled systems that miss /etc/hostname in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50108/#review142494 --- Patch looks great! Reviews applied: [50102, 50107, 50108]

Re: Review Request 49936: Added metric types in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49936/#review142492 --- Ship it! Ship It! - Abhishek Dasgupta On July 14, 2016,

Review Request 50107: Handled /etc/* file being dead links in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50107/ --- Review request for mesos, Avinash sridharan and Qian Zhang. Bugs: MESOS-5806

Review Request 50108: Handled systems that miss /etc/hostname in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50108/ --- Review request for mesos, Avinash sridharan and Qian Zhang. Bugs: MESOS-5806

Re: Review Request 49938: Updated Master::GET_METRICS call to return metrics grouped by types.

> On July 16, 2016, 4:11 a.m., Abhishek Dasgupta wrote: > > src/master/http.cpp, line 1947 > > > > > > We can't put UNREACHABLE() here.May be we have to write here: > > return Failure("Some Message"); > >

Re: Review Request 46298: Rejected relative path agent work_dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46298/#review142487 --- Patch looks great! Reviews applied: [46298] Passed command:

Re: Review Request 50072: Moved CreateMasterFlags() function definintion to 'tests/mesos.hpp'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50072/ --- (Updated July 16, 2016, 2:58 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 50103: Fixed the incomplete `TaskStatus` message of docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50103/#review142486 --- Patch looks great! Reviews applied: [50103] Passed command:

Re: Review Request 46298: Rejected relative path agent work_dir.

> On July 12, 2016, 4:23 a.m., Jie Yu wrote: > > src/slave/main.cpp, lines 175-179 > > > > > > Can we do that check in `add` function. `add` function supports an > > optional validate lambda to be passed in. > >

Re: Review Request 46298: Rejected relative path agent work_dir.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46298/ --- (Updated July 16, 2016, 9:33 p.m.) Review request for mesos, Alexander

Re: Review Request 50062: Updated makePortRanges for variable types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50062/#review142484 --- Patch looks great! Reviews applied: [49943, 49781, 50060, 50061,

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/#review142483 --- Patch looks great! Reviews applied: [49223] Passed command:

Re: Review Request 49938: Updated Master::GET_METRICS call to return metrics grouped by types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49938/#review142482 --- src/master/http.cpp (line 1947)

Re: Review Request 49938: Updated Master::GET_METRICS call to return metrics grouped by types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49938/#review142481 --- src/master/http.cpp (line 1948)

Re: Review Request 50102: Ignored /etc/* mounts to host filesystems if host network is used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50102/#review142480 --- Patch looks great! Reviews applied: [50102] Passed command:

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review142479 --- Patch looks great! Reviews applied: [50002, 50003] Passed

Re: Review Request 43477: Sped up GroupTest.* test cases by advance clock.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43477/#review142476 --- Bad patch! Reviews applied: [43477, 43475, 43474, 43473, 43472,