----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49936/#review142492 -----------------------------------------------------------
Ship it! Ship It! - Abhishek Dasgupta On July 14, 2016, 5:27 p.m., Tuan-Anh Hoang-Vu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49936/ > ----------------------------------------------------------- > > (Updated July 14, 2016, 5:27 p.m.) > > > Review request for mesos, Benjamin Mahler and Vinod Kone. > > > Bugs: MESOS-5731 > https://issues.apache.org/jira/browse/MESOS-5731 > > > Repository: mesos > > > Description > ------- > > Added metric types in libprocess. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/metrics/counter.hpp > a13cc7e18c8b23eae83c326d63874d9d2aaedc0d > 3rdparty/libprocess/include/process/metrics/gauge.hpp > c5bbeaf5d53c60f3636d1778db47cdb6cdda34e8 > 3rdparty/libprocess/include/process/metrics/metric.hpp > 21f162d5b7d9e56dc3289d65b6d86deb4c2fa721 > 3rdparty/libprocess/include/process/metrics/timer.hpp > 0a9c0227c457c6c81a59f65f901a5464ee00983d > 3rdparty/libprocess/src/tests/metrics_tests.cpp > 5a82f4f49aecd03d12687de629516be5b7895036 > > Diff: https://reviews.apache.org/r/49936/diff/ > > > Testing > ------- > > Modified MetricsTest.Counter, MetricsTest.Gauge and MetricsTest.Timer to make > sure we set metric types correctly when creating them. > > > Thanks, > > Tuan-Anh Hoang-Vu > >
