Re: Review Request 50277: Separate readonly and readwrite realms in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50277/#review143182 --- Ship it! Ship It! - Vinod Kone On July 22, 2016, 12:24

Re: Review Request 50313: Added Developer Community Status blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50313/#review143181 --- Patch looks great! Reviews applied: [50313] Passed command:

Re: Review Request 50223: Separate AuthN for readonly and readwrite endpoints in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50223/#review143179 --- src/slave/flags.cpp (lines 791 - 793)

Re: Review Request 50223: Separate AuthN for readonly and readwrite endpoints in Mesos.

> On July 22, 2016, 2:38 a.m., Adam B wrote: > > src/master/master.cpp, line 380 > > > > > > Rather than EXIT() inside this function, how about having it return a > > `Try` and have those EXIT lines return `Error("

Re: Review Request 50223: Separate AuthN for readonly and readwrite endpoints in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50223/ --- (Updated July 22, 2016, 4:38 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 50223: Separate AuthN for readonly and readwrite endpoints in Mesos.

> On July 22, 2016, 2:38 a.m., Adam B wrote: > > src/master/master.cpp, line 386 > > > > > > This now applies to `http_authenticators` and > > `http_framework_authenticators` > > Zhitao Li wrote: > In the

Re: Review Request 50223: Separate AuthN for readonly and readwrite endpoints in Mesos.

> On July 22, 2016, 2:38 a.m., Adam B wrote: > > src/master/master.cpp, line 386 > > > > > > This now applies to `http_authenticators` and > > `http_framework_authenticators` In the workgroup today, we decided to

Re: Review Request 50179: Added mesos-logrotate-logger utility executable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50179/#review143172 --- Patch looks great! Reviews applied: [50064, 50179] Passed

Re: Review Request 50223: Separate AuthN for readonly and readwrite endpoints in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50223/#review143153 --- Looking good. Thanks for the patch! Mostly just nits and some

Re: Review Request 50298: Removed backward compat code for old (< 0.15) Mesos agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50298/#review143170 --- Patch looks great! Reviews applied: [50298] Passed command:

Re: Review Request 50260: Documented the executor envirment variable 'MESOS_SANDBOX'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50260/#review143169 --- Ship it! Ship It! - Jie Yu On July 21, 2016, 12:58 a.m.,

Re: Review Request 50223: Separate AuthN for readonly and readwrite endpoints in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50223/#review143163 --- src/master/main.cpp (lines 278 - 281)

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49855/#review143166 --- Patch looks great! Reviews applied: [50038, 49814, 49817, 49819,

Re: Review Request 50266: Introduced linux capabilities API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50266/#review143038 --- Let me know if you want to chat about any of the feedback!

Re: Review Request 49955: Disabled the `--registry_strict` master flag.

> On July 22, 2016, 12:26 a.m., Vinod Kone wrote: > > Ship It! can you rebase? - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49955/#review143161

Re: Review Request 49955: Disabled the `--registry_strict` master flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49955/#review143161 --- Ship it! Ship It! - Vinod Kone On July 20, 2016, 1:01 p.m.,

Re: Review Request 50277: Separate readonly and readwrite realms in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50277/ --- (Updated July 22, 2016, 12:24 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 50313: Added Developer Community Status blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50313/#review143158 --- Fix it, then Ship it! site/source/assets/js/dev-community.js

Re: Review Request 50179: Added mesos-logrotate-logger utility executable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50179/ --- (Updated July 21, 2016, 11:56 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50064: Added setns and active user test binaries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50064/ --- (Updated July 21, 2016, 11:55 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 50223: Separate AuthN for readonly and readwrite endpoints in Mesos.

> On July 21, 2016, 8:05 p.m., Greg Mann wrote: > > src/tests/master_quota_tests.cpp, lines 1052-1053 > > > > > > Perhaps we can get away with just setting > > `masterFlags.authenticate_http_readwrite = false`,

Re: Review Request 50277: Separate readonly and readwrite realms in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50277/#review143155 --- 3rdparty/libprocess/src/tests/profiler_tests.cpp (lines 38 - 40)

Re: Review Request 50277: Separate readonly and readwrite realms in libprocess.

> On July 21, 2016, 3:24 p.m., Greg Mann wrote: > > 3rdparty/libprocess/src/tests/main.cpp, lines 54-57 > > > > > > indent 4 spaces when listing function arguments nice catch - Adam

Re: Review Request 50223: Separate AuthN for readonly and readwrite endpoints in Mesos.

> On July 21, 2016, 8:05 p.m., Greg Mann wrote: > > src/slave/slave.cpp, line 841 > > > > > > From the description in this RR it sound like you may have plans along > > these lines already: perhaps we could factor

Review Request 50313: Added Developer Community Status blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50313/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 50301: Reduced logging verbosity for replicated log operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50301/#review143150 --- Patch looks great! Reviews applied: [50301] Passed command:

Re: Review Request 50298: Removed backward compat code for old (< 0.15) Mesos agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50298/#review143147 --- Fix it, then Ship it! Thanks! Looks like our validation for

Re: Review Request 50277: Separate readonly and readwrite realms in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50277/#review143145 --- 3rdparty/libprocess/src/tests/main.cpp (lines 54 - 57)

Re: Review Request 50277: Separate readonly and readwrite realms in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50277/#review143144 --- Ship it! Ship It! - Adam B On July 21, 2016, 11:13 a.m.,

Re: Review Request 50223: Separate AuthN for readonly and readwrite endpoints in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50223/#review143110 --- src/master/main.cpp (lines 278 - 280)

Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review143133 --- Patch looks great! Reviews applied: [50280, 50285, 49223, 43561]

Re: Review Request 49828: Added default methods implementations for `Subsystem` base class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49828/ --- (Updated July 21, 2016, 7:07 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49824: Implemented `CgroupsIsolatorProcess::usage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49824/ --- (Updated July 21, 2016, 7:07 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50280: Simplificed removing whitspace by strings::replace().

> On July 21, 2016, 7:05 p.m., Benjamin Mahler wrote: > > Ship It! Note that you have some typos in the commit summary. - Benjamin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 49821: Implemented `CgroupsIsolatorProcess::watch`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49821/ --- (Updated July 21, 2016, 7:06 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49855/ --- (Updated July 21, 2016, 7:11 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49854: Implemented `DevicesSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49854/ --- (Updated July 21, 2016, 7:11 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49853: Implemented `PerfEventSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49853/ --- (Updated July 21, 2016, 7:11 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49852: Implemented `NetClsSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49852/ --- (Updated July 21, 2016, 7:11 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49827/ --- (Updated July 21, 2016, 7:11 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 45573: Add `PerfEventHandleManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45573/ --- (Updated July 21, 2016, 7:11 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated July 21, 2016, 7:10 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49849: Implemented `CpuSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49849/ --- (Updated July 21, 2016, 7:10 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49850: Implemented `CpuacctSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49850/ --- (Updated July 21, 2016, 7:10 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49827: Implemented `CgroupsIsolatorProcess::cleanup`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49827/ --- (Updated July 21, 2016, 7:07 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50285: Replaced boost::lexical_cast with numify when paring Value.

> On July 21, 2016, 7:05 p.m., Benjamin Mahler wrote: > > Ship It! Note that you have a typo in the commit summary. (paring -> parsing) - Benjamin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 49823: Implemented `CgroupsIsolatorProcess::update`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49823/ --- (Updated July 21, 2016, 7:06 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49825: Implemented `CgroupsIsolatorProcess::status`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49825/ --- (Updated July 21, 2016, 7:07 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49820: Implemented `CgroupsIsolatorProcess::isolate`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49820/ --- (Updated July 21, 2016, 7:06 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49819: Implemented `CgroupsIsolatorProcess::prepare`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49819/ --- (Updated July 21, 2016, 7:05 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50280: Simplificed removing whitspace by strings::replace().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50280/#review143127 --- Ship it! Ship It! - Benjamin Mahler On July 21, 2016, 4:13

Re: Review Request 50285: Replaced boost::lexical_cast with numify when paring Value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50285/#review143128 --- Ship it! Ship It! - Benjamin Mahler On July 21, 2016, 6:52

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49817/ --- (Updated July 21, 2016, 7:05 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49814: Implemented `CgroupsIsolatorProcess::create`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49814/ --- (Updated July 21, 2016, 7:04 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49239: Added logging when Offer::Operation::Launch has no tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49239/#review143118 --- Ship it! Ship It! - Anand Mazumdar On July 21, 2016, 4:04

Re: Review Request 50277: Separate readonly and readwrite realms in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50277/ --- (Updated July 21, 2016, 6:13 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 50000: Added test to simulate slow/unresponsive fetch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/#review142952 --- src/tests/slave_tests.cpp (line 269)

Re: Review Request 50223: Separate AuthN for readonly and readwrite endpoints in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50223/#review143099 --- Patch looks great! Reviews applied: [50277, 50223] Passed

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/ --- (Updated July 22, 2016, 12:34 a.m.) Review request for mesos and Benjamin

Review Request 50301: Reduced logging verbosity for replicated log operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50301/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description

Re: Review Request 48694: Optimized `UUID::fromString` and `UUID::toString` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48694/#review143094 --- Ship it! Ship It! - Anand Mazumdar On July 21, 2016, 4:17

Re: Review Request 48694: Optimized `UUID::fromString` and `UUID::toString` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48694/ --- (Updated July 21, 2016, 4:17 p.m.) Review request for mesos and Anand

Re: Review Request 50284: Updated upgrades.md with fetcher user changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50284/#review143092 --- Ship it! Ship It! - Jie Yu On July 21, 2016, 5:59 a.m.,

Re: Review Request 50283: Updated CHANGELOG with fetcher user changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50283/#review143091 --- Ship it! Ship It! - Jie Yu On July 21, 2016, 5:58 a.m.,

Re: Review Request 50277: Separate readonly and readwrite realms in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50277/#review143051 --- 3rdparty/libprocess/include/process/process.hpp (lines 486 -

Re: Review Request 50290: Did not put latest empty string in strings::split.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50290/ --- (Updated July 21, 2016, 11:44 p.m.) Review request for mesos and Benjamin

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/ --- (Updated July 21, 2016, 11:44 p.m.) Review request for mesos and Benjamin

Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/ --- (Updated July 21, 2016, 11:43 p.m.) Review request for mesos, Alexander

Re: Review Request 49239: Added logging when Offer::Operation::Launch has no tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49239/#review143083 --- Patch looks great! Reviews applied: [49239] Passed command:

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

> On July 21, 2016, 7:44 a.m., Benjamin Mahler wrote: > > src/common/values.cpp, lines 589-594 > > > > > > Do we still need this? Seems to me that we want to do the following: > > > > ``` > > // Ranges.

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/ --- (Updated July 21, 2016, 10:38 p.m.) Review request for mesos and Benjamin

Review Request 50295: Returned empty vector if string is empty.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50295/ --- Review request for mesos. Repository: mesos Description --- Returned

Re: Review Request 50290: Did not put latest empty string in strings::split.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50290/ --- (Updated July 21, 2016, 10:25 p.m.) Review request for mesos and Benjamin

Review Request 50290: Returned empty vector if string is empty.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50290/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 50062: Refactored `makePortRanges` for allocator benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50062/#review143080 --- Bad patch! Reviews applied: [50062, 50172] Failed command:

Re: Review Request 50186: Avoid a GMock warning in a reservation test case.

> On July 21, 2016, 12:08 p.m., Alexander Rukletsov wrote: > > If we are not interested in rescinding, can't we simply say something like > > ``` > > EXPECT_CALL(sched, offerRescinded(, _)) > > .WillRepeatedly(Return()); > > ``` We could -- I felt like there was value in being a bit more

Re: Review Request 50186: Avoid a GMock warning in a reservation test case.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50186/#review143077 --- If we are not interested in rescinding, can't we simply say

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review143076 --- Patch looks great! Reviews applied: [50002, 50003] Passed

Re: Review Request 50268: Target shutdownFramework to associated agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50268/#review143063 --- Looks good to me. Some high level thoughts: 1) This works under

Review Request 50285: Replaced boost::lexical_cast with numify when paring Value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50285/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description