Re: Review Request 49616: Add suppression benchmark.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/#review143308 --- Thanks Jacob! I left some comments here around style and

Re: Review Request 50341: Ensured actor ID references class name in StatusUpdateManager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50341/#review143309 --- Ship it! Ship It! - Qian Zhang On July 22, 2016, 11:26

Re: Review Request 50367: Updated 1.0 CHANGELOG about MESOS-5389.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50367/#review143305 --- Ship it! Ship It! - Gilbert Song On July 22, 2016, 4:47

Re: Review Request 50368: Updated 1.0 CHANGELOG about MESOS-5834.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50368/#review143304 --- Ship it! Ship It! - Vinod Kone On July 22, 2016, 11:48

Re: Review Request 50367: Updated 1.0 CHANGELOG about MESOS-5389.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50367/#review143303 --- Ship it! Ship It! - Vinod Kone On July 22, 2016, 11:47

Review Request 50368: Updated 1.0 CHANGELOG about MESOS-5834.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50368/ --- Review request for mesos, Gilbert Song and Vinod Kone. Repository: mesos

Re: Review Request 50365: Removed `C` framework support from framework developer guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50365/#review143302 --- Patch looks great! Reviews applied: [50365] Passed command:

Review Request 50367: Updated 1.0 CHANGELOG about MESOS-5389.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50367/ --- Review request for mesos, Gilbert Song and Vinod Kone. Repository: mesos

Re: Review Request 50366: Fixed a bug in docker volume driver generation code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50366/#review143300 --- Ship it! LGTM, thanks for catching the bug! - Gastón Kleiman

Re: Review Request 50366: Fixed a bug in docker volume driver generation code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50366/#review143301 --- Ship it! LGTM! Thanks! - Gilbert Song On July 22, 2016,

Re: Review Request 50366: Fixed a bug in docker volume driver generation code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50366/ --- (Updated July 22, 2016, 11:27 p.m.) Review request for mesos and Gilbert Song.

Review Request 50366: Fixed a bug in docker volume driver generation code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50366/ --- Review request for mesos and Gilbert Song. Repository: mesos Description

Review Request 50365: Removed `C` framework support from framework developer guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50365/ --- Review request for mesos and Anand Mazumdar. Repository: mesos Description

Re: Review Request 49348: Added implementation to Appc Runtime Isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49348/#review143292 --- Ship it! Ship It! - Jie Yu On July 19, 2016, 9:11 p.m.,

Re: Review Request 50357: Removed a redundant CLOEXEC from linux/ns.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50357/#review143284 --- Ship it! Ship It! - Jie Yu On July 22, 2016, 9:17 p.m.,

Re: Review Request 50357: Removed a redundant CLOEXEC from linux/ns.hpp.

> On July 22, 2016, 2:45 p.m., Avinash sridharan wrote: > > src/linux/ns.hpp, line 153 > > > > > > SO We don't need this because this is a no-op? > > > >

Re: Review Request 50357: Removed a redundant CLOEXEC from linux/ns.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50357/#review143279 --- src/linux/ns.hpp

Re: Review Request 50357: Removed a redundant CLOEXEC from linux/ns.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50357/#review143278 --- Ship it! Good catch! - Gilbert Song On July 22, 2016, 2:17

Review Request 50357: Removed a redundant CLOEXEC from linux/ns.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50357/ --- Review request for mesos, Avinash sridharan, Gilbert Song, Artem Harutyunyan,

Re: Review Request 48573: Added expectations for response types in log replica tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48573/#review143265 --- Ship it! Ship It! - Benjamin Mahler On June 15, 2016, 9:03

Re: Review Request 48572: Updated whitespace style in log replica tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48572/#review143264 --- Ship it! Ship It! - Benjamin Mahler On June 15, 2016, 9:03

Re: Review Request 50062: Refactored `makePortRanges` for allocator benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50062/#review143254 --- Ship it! Modulo similar feedback from:

Re: Review Request 50172: Made `ports` resource configurable in sorter benchmark test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50172/#review143251 --- Ship it! The commit summary and description seem to not

Re: Review Request 50346: Ensured actor ID references class name in log/Network.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50346/#review143250 --- Patch looks great! Reviews applied: [50341, 50342, 50343, 50344,

Re: Review Request 50313: Added Developer Community Status blog post.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50313/#review143241 --- Patch looks great! Reviews applied: [50313] Passed command:

Re: Review Request 50346: Ensured actor ID references class name in log/Network.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50346/#review143238 --- Ship it! Ship It! - Vinod Kone On July 22, 2016, 3:29 p.m.,

Re: Review Request 50344: Ensured actor ID references class name in HealthChecker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50344/#review143236 --- Ship it! Ship It! - Vinod Kone On July 22, 2016, 3:27 p.m.,

Re: Review Request 50345: Ensured actor ID references class name in CommandExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50345/#review143237 --- Ship it! Ship It! - Vinod Kone On July 22, 2016, 3:28 p.m.,

Review Request 50346: Ensured actor ID references class name in log/Network.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50346/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 50345: Ensured actor ID references class name in CommandExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50345/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 50344: Ensured actor ID references class name in HealthChecker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50344/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 50343: Ensured actor ID references class name in DockerExecutor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50343/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Review Request 50342: Tweaked LocalAuthorizerProcess actor ID for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50342/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 50332: Updated CHANGELOG for new HTTP authentication flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50332/#review143206 --- Ship it! Ship It! - Adam B On July 22, 2016, 12:55 a.m.,

Re: Review Request 50333: Updated upgrades.md for new HTTP authentication flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50333/#review143204 --- Fix it, then Ship it! docs/upgrades.md (line 283)

Re: Review Request 50223: Separate AuthN for readonly and readwrite endpoints in Mesos.

> On July 21, 2016, 7:38 p.m., Adam B wrote: > > src/slave/slave.cpp, lines 443-451 > > > > > > This logic seems to be missing from your new patch. > > Zhitao Li wrote: > This is because I aligned this logic

Re: Review Request 50322: Added readonly/readwrite auth flags to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50322/#review143199 --- Patch looks great! Reviews applied: [50277, 50223, 50322]

Re: Review Request 50333: Updated upgrades.md for new HTTP authentication flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50333/ --- (Updated July 22, 2016, 8:10 a.m.) Review request for mesos, Adam B and Zhitao

Review Request 50332: Updated CHANGELOG for new HTTP authentication flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50332/ --- Review request for mesos, Adam B and Zhitao Li. Bugs: MESOS-5851

Re: Review Request 50320: Refactor common HTTP authenticator initialize into helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50320/ --- (Updated July 22, 2016, 7:55 a.m.) Review request for mesos, Adam B and Greg

Review Request 50331: Regenerated endpoint documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50331/ --- Review request for mesos, Adam B and Zhitao Li. Bugs: MESOS-5851

Review Request 50330: Updated authentication callsites in endpoint help.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50330/ --- Review request for mesos, Adam B and Zhitao Li. Bugs: MESOS-5851

Re: Review Request 50327: Added scripts to build sample framework executables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50327/ --- (Updated July 22, 2016, 7:45 a.m.) Review request for mesos, Alex Clemmer and

Review Request 50327: Added scripts to build sample framework executables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50327/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792

Review Request 50326: Added script to build mesos-resolve.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50326/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792

Review Request 50325: Added script to build mesos-log tool.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50325/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792

Review Request 50324: Added script to build mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50324/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792

Review Request 50323: Added build script for mesos-local executable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50323/ --- Review request for mesos, Alex Clemmer and Joseph Wu. Bugs: MESOS-5792

Re: Review Request 50320: Refactor common HTTP authenticator initialize into helper function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50320/#review143188 --- Good progress, but let's get rid of the ostringstream and move

Re: Review Request 50223: Separate AuthN for readonly and readwrite endpoints in Mesos.

> On July 21, 2016, 7:38 p.m., Adam B wrote: > > src/slave/slave.cpp, lines 410-415 > > > > > > This error is gone? > > Zhitao Li wrote: > Yes, because I refactored the code to be aligned with master side. This

Review Request 50322: Added readonly/readwrite auth flags to the docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50322/ --- Review request for mesos and Adam B. Bugs: MESOS-5851

Re: Review Request 50223: Separate AuthN for readonly and readwrite endpoints in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50223/ --- (Updated July 22, 2016, 6:21 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 49955: Disabled the `--registry_strict` master flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49955/#review143187 --- Bad patch! Reviews applied: [49955] Failed command:

Re: Review Request 50223: Separate AuthN for readonly and readwrite endpoints in Mesos.

> On July 22, 2016, 5:07 a.m., Greg Mann wrote: > > src/slave/flags.cpp, lines 791-793 > > > > > > I think the word "authenticatable" throws me off a bit. > > > > Maybe something like: > > "If `true`,

Re: Review Request 50223: Separate AuthN for readonly and readwrite endpoints in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50223/#review143184 --- src/master/flags.cpp (line 237)