Re: Review Request 50713: Documented behavior of content-type header in presence of errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50713/#review144584 --- Patch looks great! Reviews applied: [50626, 50713] Passed

Re: Review Request 50732: Check for shared count and scalar values in subtraction of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50732/#review144580 --- Ship it! Committed it with the suggested fix. Thanks! - Jiang

Re: Review Request 50732: Check for shared count and scalar values in subtraction of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50732/#review144576 --- Thanks for the fix! src/common/resources.cpp (lines 1631 -

Review Request 50733: Removed CgroupsCpushareIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50733/ --- Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha.

Re: Review Request 50732: Check for shared count and scalar values in subtraction of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50732/ --- (Updated Aug. 3, 2016, 1:50 a.m.) Review request for mesos, Benjamin Mahler

Review Request 50732: Check for shared count and scalar values in subtraction of resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50732/ --- Review request for mesos, Benjamin Mahler and Jiang Yan Xu. Bugs: MESOS-5972

Re: Review Request 50728: Added MESOS-5927 to 1.0.1 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50728/#review144565 --- Ship it! Ship It! - Jie Yu On Aug. 2, 2016, 11:53 p.m.,

Review Request 50729: Added MESOS-5927 to 0.28.3 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50729/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Review Request 50728: Added MESOS-5927 to 1.0.1 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50728/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 50727: Added a unit test for scratch based docker images.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50727/#review144563 --- Ship it! Ship It! - Jie Yu On Aug. 2, 2016, 11:46 p.m.,

Review Request 50727: Added a unit test for scratch based docker images.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50727/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, Phil Winder, and Timothy

Re: Review Request 50719: Supported scratch containers in Unified Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50719/ --- (Updated Aug. 2, 2016, 4:44 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 50721: Fixed the bind backend document in container-image.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50721/ --- (Updated Aug. 2, 2016, 4:44 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 50718: Deprecated the 'rootfs' proto field in ContainerLaunchInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50718/ --- (Updated Aug. 2, 2016, 4:44 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 50720: Added comments for tmpfs and sandbox mountpoints for bind backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50720/ --- (Updated Aug. 2, 2016, 4:44 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 50674: Stout: Enabled tests that pass on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50674/#review144555 --- 3rdparty/stout/tests/flags_tests.cpp (lines 231 - 235)

Re: Review Request 50724: Added MESOS-5388 to 1.0.1 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50724/#review144558 --- Ship it! Ship It! - Jie Yu On Aug. 2, 2016, 11:05 p.m.,

Re: Review Request 50726: Fixed the white space indentation in CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50726/#review144557 --- Ship it! Ship It! - Jie Yu On Aug. 2, 2016, 11:06 p.m.,

Review Request 50726: Fixed the white space indentation in CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50726/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 50724: Added MESOS-5388 to 1.0.1 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50724/ --- (Updated Aug. 2, 2016, 4:05 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 50609: Moved check for '--version' in master and agent 'main.cpp'.

> On Aug. 2, 2016, 6:04 p.m., Vinod Kone wrote: > > src/master/main.cpp, lines 220-223 > > > > > > shouldn't this be moved up above the load error as well? Sure thing - I was going to only address the '--version'

Re: Review Request 50609: Moved check for '--version' in master and agent 'main.cpp'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50609/ --- (Updated Aug. 2, 2016, 11:04 p.m.) Review request for mesos, Jie Yu and Pierre

Re: Review Request 50673: Made semantics of `os::rmdir` consistent between POSIX and Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50673/#review144547 --- 3rdparty/stout/tests/os/rmdir_tests.cpp (line 105)

Re: Review Request 50724: Added MESOS-5388 to 1.0.1 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50724/#review144550 --- CHANGELOG (line 7)

Review Request 50724: Added MESOS-5388 to 1.0.1 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50724/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 50581: Added logs for pre-exec commands to sandbox in MesosContainerizerLaunch.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50581/ --- (Updated Aug. 2, 2016, 3:43 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 50721: Fixed the bind backend document in container-image.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50721/#review144546 --- Ship it! Ship It! - Jie Yu On Aug. 2, 2016, 9:43 p.m.,

Re: Review Request 50380: Made resources benchmark test for ports `-=/-` more accurate.

> On 七月 29, 2016, 8:35 p.m., Benjamin Mahler wrote: > > src/tests/resources_tests.cpp, lines 2515-2523 > > > > > > Can we make the initial resources another parameter? I believe Klaus > > took this approach

Re: Review Request 50720: Added comments for tmpfs and sandbox mountpoints for bind backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50720/#review144544 --- Ship it! Ship It! - Jie Yu On Aug. 2, 2016, 9:43 p.m.,

Re: Review Request 50719: Supported scratch containers in Unified Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50719/#review144543 --- Ship it! Ship It! - Jie Yu On Aug. 2, 2016, 9:43 p.m.,

Re: Review Request 50569: Checked if resource is negative scalar directly in subtract.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50569/#review144542 --- I updated the commit to the following: ``` commit

Re: Review Request 50718: Deprecated the 'rootfs' proto field in ContainerLaunchInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50718/#review144541 --- Ship it! Ship It! - Jie Yu On Aug. 2, 2016, 9:43 p.m.,

Review Request 50723: Fixed the master to recover resources/update state for orphan tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50723/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5930

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

> On July 25, 2016, 6:04 p.m., Greg Mann wrote: > > Thanks Ammar! Patches look good to me; Vinod is going to take a look when > > he has some cycles. bump - Ammar --- This is an automatically generated e-mail. To reply, visit:

Review Request 50718: Deprecated the 'rootfs' proto field in ContainerLaunchInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50718/ --- Review request for mesos, Artem Harutyunyan, Ian Downes, Jie Yu, Timothy Chen,

Review Request 50721: Fixed the bind backend document in container-image.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50721/ --- Review request for mesos, Artem Harutyunyan, Ian Downes, Jie Yu, Timothy Chen,

Review Request 50720: Added comments for tmpfs and sandbox mountpoints for bind backend.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50720/ --- Review request for mesos, Artem Harutyunyan, Ian Downes, Jie Yu, Timothy Chen,

Review Request 50719: Supported scratch containers in Unified Containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50719/ --- Review request for mesos, Artem Harutyunyan, Ian Downes, Jie Yu, Timothy Chen,

Re: Review Request 49924: Added libprocess as a shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49924/ --- (Updated Aug. 2, 2016, 9:41 p.m.) Review request for mesos, Alex Clemmer and

Review Request 50722: TestCommit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50722/ --- Review request for mesos. Repository: mesos Description --- DO NOT

Re: Review Request 50717: Fixed `clean-python` Makefile target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50717/#review144531 --- Ship it! Ship It! - Vinod Kone On Aug. 2, 2016, 9:30 p.m.,

Re: Review Request 50664: Fixed continuation logic in logrotate module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50664/#review144530 --- Ship it! Ship It! - Joris Van Remoortere On Aug. 1, 2016,

Review Request 50717: Fixed `clean-python` Makefile target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50717/ --- Review request for mesos, Artem Harutyunyan and Vinod Kone. Bugs: MESOS-5958

Re: Review Request 50683: Libprocess: [3/3] Removed old http_parser code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50683/ --- (Updated Aug. 2, 2016, 9:06 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 50683: Libprocess: [3/3] Removed old http_parser code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50683/ --- (Updated Aug. 2, 2016, 6:29 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 50634: Libprocess: [2/3] Fixed decoder to support incremental URL parsing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50634/ --- (Updated Aug. 2, 2016, 6:28 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 50609: Moved check for '--version' in master and agent 'main.cpp'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50609/#review144517 --- src/master/main.cpp (lines 215 - 218)

Re: Review Request 49851: Implemented `MemorySubsystem`.

> On July 27, 2016, 2:05 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, line 494 > > > > > > How do we recover this field `updatedLimit`? I mean during agent > >

Re: Review Request 50516: Fixed quoting for executor IDs in log messages.

> On July 29, 2016, 7:05 p.m., Anand Mazumdar wrote: > > hmm, why can't the TaskID's have spaces? > > > > They are generated by the framework and are free to contain spaces. > > Neil Conway wrote: > Yeah, I was wondering that myself :) We don't quote them almost all the > time, however.

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49855/ --- (Updated Aug. 2, 2016, 5:51 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49852: Implemented `NetClsSubsystem`.

> On July 28, 2016, 3:01 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp, line 359 > > > > > > Where is the implementation of this class `NetClsHandleManager`? Would move

Re: Review Request 49852: Implemented `NetClsSubsystem`.

> On July 28, 2016, 2:23 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp, lines 961-965 > > > > > > Should this be a CHECK()? I return `Failure` here, feel free to reopen

Re: Review Request 49854: Implemented `DevicesSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49854/ --- (Updated Aug. 2, 2016, 5:50 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49853: Implemented `PerfEventSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49853/ --- (Updated Aug. 2, 2016, 5:49 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 45573: Added `PerfEventHandleManager`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45573/ --- (Updated Aug. 2, 2016, 5:49 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated Aug. 2, 2016, 5:48 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49850: Implemented `CpuacctSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49850/ --- (Updated Aug. 2, 2016, 5:48 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49849: Implemented `CpuSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49849/ --- (Updated Aug. 2, 2016, 5:48 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49828: Added default methods implementations for `Subsystem` base class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49828/ --- (Updated Aug. 2, 2016, 5:47 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49817/ --- (Updated Aug. 2, 2016, 5:47 p.m.) Review request for mesos, Gilbert Song, Jie

Review Request 50713: Documented behavior of content-type header in presence of errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50713/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-5853

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49817/ --- (Updated Aug. 2, 2016, 4:48 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50643: Implemented `CgroupsIsolatorProcess::finalize`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50643/ --- (Updated Aug. 2, 2016, 4:46 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50642: Implemented `CgroupsIsolatorProcess::initialize`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50642/ --- (Updated Aug. 2, 2016, 4:46 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50642: Implemented `CgroupsIsolatorProcess::initialize`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50642/#review144508 --- Can you rebase? - Jie Yu On July 31, 2016, 5:48 p.m., haosdent

Re: Review Request 50516: Fixed quoting for executor IDs in log messages.

> On July 29, 2016, 7:05 p.m., Anand Mazumdar wrote: > > hmm, why can't the TaskID's have spaces? > > > > They are generated by the framework and are free to contain spaces. > > Neil Conway wrote: > Yeah, I was wondering that myself :) We don't quote them almost all the > time, however.

Re: Review Request 50516: Fixed quoting for executor IDs in log messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50516/#review144507 --- Ship it! Ship It! - Anand Mazumdar On Aug. 2, 2016, 3:58

Re: Review Request 50609: Moved check for '--version' in master and agent 'main.cpp'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50609/ --- (Updated Aug. 2, 2016, 4:16 p.m.) Review request for mesos, Jie Yu and Pierre

Re: Review Request 50609: Moved check for '--version' in agent's 'main.cpp'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50609/ --- (Updated Aug. 2, 2016, 4:14 p.m.) Review request for mesos, Jie Yu and Pierre

Re: Review Request 50516: Fixed quoting for executor IDs in log messages.

> On July 29, 2016, 7:05 p.m., Anand Mazumdar wrote: > > hmm, why can't the TaskID's have spaces? > > > > They are generated by the framework and are free to contain spaces. > > Neil Conway wrote: > Yeah, I was wondering that myself :) We don't quote them almost all the > time, however.

Re: Review Request 50516: Fixed quoting for executor IDs in log messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50516/ --- (Updated Aug. 2, 2016, 3:58 p.m.) Review request for mesos and Anand Mazumdar.

Re: Review Request 50205: Enhanced benchmark test for resources to include shared resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50205/#review144499 --- Ship it! The test itself LGTM so I'll commit it. However when

Re: Review Request 49921: Fixed mesos tests to run most of the tests on Unix and OSX.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49921/ --- (Updated Aug. 2, 2016, 3:37 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49921: Fixed mesos tests to run 723 test on Unix.

> On July 12, 2016, 5:11 a.m., Alex Clemmer wrote: > > src/tests/CMakeLists.txt, line 52 > > > > > > Is this review relevant anymore? In #49688 it looks like we're using a > > much more recent version of this file,

Re: Review Request 49870: Added test executables required to run tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49870/ --- (Updated Aug. 2, 2016, 3:36 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49874: Added logrotate_container_logger for running mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49874/ --- (Updated Aug. 2, 2016, 3:36 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49862: Changed libmesos from static library to a shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/ --- (Updated Aug. 2, 2016, 3:35 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49688: Added cmake build variables for mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/ --- (Updated Aug. 2, 2016, 3:32 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49688: Added cmake build variables for mesos tests.

> On Aug. 2, 2016, 1:17 a.m., Alex Clemmer wrote: > > src/tests/cmake/MesosTestsConfigure.cmake, line 76 > > > > > > This variable doesn't seem to exist. Did you mean the (eminently badly > > named)

Re: Review Request 50252: Added native implementation for v1 Mesos interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50252/ --- (Updated Aug. 2, 2016, 3:23 p.m.) Review request for mesos, Joris Van

Re: Review Request 50127: Added NvidiaGpuDockerContainerizerTest.ROOT_DOCKER_LaunchWithGpu.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50127/ --- (Updated 八月 2, 2016, 2:23 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50123: Added GPU scheduler for docker containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50123/ --- (Updated 八月 2, 2016, 2:22 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50125: Added mesos-docker-executor support for device control.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/ --- (Updated 八月 2, 2016, 2:21 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50128: Added helper functions to 'Docker::Device'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/ --- (Updated 八月 2, 2016, 2:19 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50513: Added missing process IDs in libprocess.

> On July 29, 2016, 12:44 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/authenticator.cpp, line 57 > > > > > > Why this one is enclosed in underscores? > > Gastón Kleiman wrote: > Added the naming

Re: Review Request 50563: Made HierarchicalAllocatorProcess specify a process ID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50563/ --- (Updated Aug. 2, 2016, 1:55 p.m.) Review request for mesos and Alexander

Re: Review Request 50521: Added "zookeeper" prefix to ZK process IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50521/ --- (Updated Aug. 2, 2016, 1:55 p.m.) Review request for mesos and Alexander

Re: Review Request 50639: Made all Actor IDs outside of libprocess follow the same schema.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50639/ --- (Updated Aug. 2, 2016, 1:54 p.m.) Review request for mesos and Alexander

Re: Review Request 50513: Added missing process IDs in libprocess.

> On July 29, 2016, 12:44 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/include/process/sequence.hpp, line 66 > > > > > > Why do you treat `Sequence` not like other processes in this patch? > > > >

Re: Review Request 50519: Made libprocess Actor IDs consistent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50519/ --- (Updated Aug. 2, 2016, 1:50 p.m.) Review request for mesos and Alexander

Re: Review Request 50515: Added missing process IDs.

> On July 29, 2016, 12:45 p.m., Alexander Rukletsov wrote: > > src/exec/exec.cpp, line 87 > > > > > > No need for `process::` here because > > `using namespace process` above. Fixed here and in

Re: Review Request 50515: Added missing process IDs.

> On July 29, 2016, 12:45 p.m., Alexander Rukletsov wrote: > > src/slave/containerizer/mesos/containerizer.hpp, line 304 > > > > > > See my comment in the previous patch regarding `sequence`. Fixed, renamed it to

Re: Review Request 50515: Added missing process IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50515/ --- (Updated Aug. 2, 2016, 1:47 p.m.) Review request for mesos and Alexander

Re: Review Request 50513: Added missing process IDs in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50513/ --- (Updated Aug. 2, 2016, 1:45 p.m.) Review request for mesos and Alexander

Re: Review Request 50637: Added id to the libprocess Sequence constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50637/ --- (Updated Aug. 2, 2016, 1:42 p.m.) Review request for mesos and Alexander

Re: Review Request 50637: Added id to the libprocess Sequence constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50637/ --- (Updated Aug. 2, 2016, 1:29 p.m.) Review request for mesos and Alexander

Review Request 50706: Added test cases for PARTITION_AWARE behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50706/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4049

Review Request 50707: Added test for agent removal behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50707/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4049

Review Request 50705: Changed master to allow partitioned slaves to reregister.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50705/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4049

Review Request 50704: Made a few minor tweaks to comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50704/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4049

  1   2   >