Re: Review Request 51068: Prevent memory leaks

> On Aug. 16, 2016, 11:35 p.m., Benjamin Mahler wrote: > > Hey Aaron, I was not able to identify the leaks you were addressing. Also > > there seems to be some object lifetime issues introduced with this patch. It looks like I was wrong about this, I had thought the copy constructor of tuple

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

> On Aug. 17, 2016, 8:06 a.m., Qian Zhang wrote: > > src/tests/environment.cpp, line 438 > > > > > > Here can we change it to the following? > > ``` > > if (matches(test, "ROOT_CGROUPS_Isolate") || > >

Re: Review Request 49234: Code cleanup for docker/runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49234/#review146159 --- Patch looks great! Reviews applied: [49234] Passed command:

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

> On Aug. 17, 2016, 4:06 p.m., Qian Zhang wrote: > > src/tests/environment.cpp, line 438 > > > > > > Here can we change it to the following? > > ``` > > if (matches(test, "ROOT_CGROUPS_Isolate") || > >

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Aug. 17, 2016, 5:36 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 29 > > > > > > move this right before `#include ` Also move `#include ` with it. - Jiang Yan

Re: Review Request 51027: Track allocation candidates to bound allocator.

> On Aug. 17, 2016, 5:38 p.m., Guangya Liu wrote: > > Can you please also clarify some difference with > > https://reviews.apache.org/r/41658/, as here the work is carry from > > https://reviews.apache.org/r/41658/ , I think that this is more simple and > > clear compared with counter in

Re: Review Request 51027: Track allocation candidates to bound allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review146094 --- src/master/allocator/mesos/hierarchical.hpp (line 216)

Re: Review Request 49063: Updating formatting of some lambda calls for readability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49063/#review146153 --- Bad patch! Reviews applied: [49063] Failed command:

Re: Review Request 50540: Add systemd watchdog support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50540/ --- (Updated Aug. 19, 2016, 12:09 a.m.) Review request for mesos, David Robinson,

Re: Review Request 51220: Moved setns test helper to the common test helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51220/#review146149 --- Bad patch! Reviews applied: [51220, 51215] Failed command:

Re: Review Request 49234: Code cleanup for docker/runtime isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49234/ --- (Updated 八月 18, 2016, 11:38 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 51172: Implemented the volume/image isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51172/#review146146 --- src/slave/containerizer/mesos/isolators/volume/image.hpp (line

Re: Review Request 51042: Added high-level function to set capabilties on process exec'd next.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51042/#review146148 --- src/linux/capabilities.cpp (lines 297 - 313)

Re: Review Request 51042: Added high-level function to set capabilties on process exec'd next.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51042/#review146147 --- Looking at what runC does:

Re: Review Request 50540: Add systemd watchdog support.

> On Aug. 17, 2016, 12:44 a.m., Jie Yu wrote: > > High level question: is this useful? I imagine watchdog logic for agent is > > to call sd_notify from `Slave` actor (similar to Master) so that we know > > `Slave` is still functional. I think this is the right way to detect > > hanging. > >

Re: Review Request 50540: Add systemd watchdog support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50540/ --- (Updated Aug. 18, 2016, 11:19 p.m.) Review request for mesos, David Robinson,

Re: Review Request 51217: Added `os::execlp' in `stout` library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51217/#review146141 --- Patch looks great! Reviews applied: [51210, 51217] Passed

Re: Review Request 49849: Implemented `CpuSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49849/#review146135 --- Fix it, then Ship it! Made some adjustment while committing.

Re: Review Request 49063: Updating formatting of some lambda calls for readability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49063/#review146139 --- Fix it, then Ship it! src/master/http.cpp (lines 2838 - 2839)

Re: Review Request 44332: Fixed a typo in the HierarchicalAllocatorTest.CoarseGrained test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44332/ --- (Updated Aug. 18, 2016, 10:15 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 51171: Supported image provisioner singleton methods for global pointer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51171/#review146129 --- It was my bad. After looking at the code closely, I realized that

Review Request 51220: Moved setns test helper to the common test helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51220/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-6053

Re: Review Request 51215: Moved memory test helper to the common test helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51215/#review146121 --- Bad patch! Reviews applied: [51215] Failed command:

Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50751/#review146117 --- Bad review! Reviews applied: [50751, 50750, 50748, 50749, 50733,

Re: Review Request 51217: Added `os::execlp' in `stout` library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51217/ --- (Updated Aug. 18, 2016, 6:20 p.m.) Review request for mesos, Alex Naparu,

Review Request 51217: Added `os::execlp' in `stout` library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51217/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph

Review Request 51211: Eumlate execlp functionality on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51211/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph

Review Request 51213: Used `os::execlp` instead of `::execlp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51213/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph

Review Request 51210: Update mesos-executor name for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51210/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joseph

Re: Review Request 51031: Added non-recursive version of `cgroups::get`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51031/#review146102 --- Patch looks great! Reviews applied: [51091, 51031] Passed

Review Request 51215: Moved memory test helper to the common test helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51215/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-6053

Re: Review Request 51091: Disallowed unknown cgroups isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51091/ --- (Updated Aug. 18, 2016, 4:25 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49853: Implemented `PerfEventSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49853/ --- (Updated Aug. 18, 2016, 4:09 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50750/ --- (Updated Aug. 18, 2016, 4:10 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50758: Updated `UserCgroupIsolatorTest` to use `CgroupsIsolatorProcess`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50758/ --- (Updated Aug. 18, 2016, 4:09 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49850: Implemented `CpuacctSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49850/ --- (Updated Aug. 18, 2016, 4:09 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50749: Removed CgroupsDevicesIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50749/ --- (Updated Aug. 18, 2016, 4:09 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49851: Implemented `MemorySubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/ --- (Updated Aug. 18, 2016, 4:09 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50748: Removed CgroupsMemIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50748/ --- (Updated Aug. 18, 2016, 4:09 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50751: Removed CgroupsPerfEventIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50751/ --- (Updated Aug. 18, 2016, 4:10 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50733: Removed CgroupsCpushareIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50733/ --- (Updated Aug. 18, 2016, 4:09 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49849: Implemented `CpuSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49849/ --- (Updated Aug. 18, 2016, 4:09 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49855: Enabled cgroups unified isolator in isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49855/ --- (Updated Aug. 18, 2016, 4:09 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49828: Added default methods implementations for `Subsystem` base class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49828/ --- (Updated Aug. 18, 2016, 4:09 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49854: Implemented `DevicesSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49854/ --- (Updated Aug. 18, 2016, 4:09 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 49852: Implemented `NetClsSubsystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49852/ --- (Updated Aug. 18, 2016, 4:09 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51185: Removed the expired TODO about non-recursive version `cgroups::get`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51185/ --- (Updated Aug. 18, 2016, 4:09 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51031: Added non-recursive version of `cgroups::get`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51031/ --- (Updated Aug. 18, 2016, 4:05 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51031: Added non-recursive version of `cgroups::get`.

> On Aug. 17, 2016, 7:55 p.m., Jiang Yan Xu wrote: > > Mind adding a test? We already have > > `CgroupsAnyHierarchyTest.ROOT_CGROUPS_Get` but we can add another > > `ROOT_CGROUPS_Nonresursive_Get` and change the current one into a > > `ROOT_CGROUPS_Recursive_Get`. > > > > The argument `bool

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50750/ --- (Updated Aug. 18, 2016, 1:50 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

> On Aug. 17, 2016, 8:06 a.m., Qian Zhang wrote: > > src/tests/environment.cpp, line 438 > > > > > > Here can we change it to the following? > > ``` > > if (matches(test, "ROOT_CGROUPS_Isolate") || > >

Re: Review Request 50750: Removed CgroupsNetClsIsolatorProcess.

> On Aug. 17, 2016, 4:06 p.m., Qian Zhang wrote: > > src/tests/environment.cpp, line 438 > > > > > > Here can we change it to the following? > > ``` > > if (matches(test, "ROOT_CGROUPS_Isolate") || > >

Re: Review Request 51195: Refactored the test helper to use a single binary.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51195/#review146068 --- Patch looks great! Reviews applied: [51195] Passed command: