----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51172/#review146146 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/volume/image.hpp (line 28) <https://reviews.apache.org/r/51172/#comment212523> s/docker runtime/volume image src/slave/containerizer/mesos/isolators/volume/image.cpp (lines 49 - 50) <https://reviews.apache.org/r/51172/#comment212525> kill this src/slave/containerizer/mesos/isolators/volume/image.cpp (line 94) <https://reviews.apache.org/r/51172/#comment212530> s/int/size_t src/slave/containerizer/mesos/isolators/volume/image.cpp (lines 97 - 99) <https://reviews.apache.org/r/51172/#comment212526> I think that we also need to check if the volume has source here, and just ignore such volumes as the volume who has sources can only be handled by docker volume isolator. ``` if (volume.has_source()) { ... } ``` src/slave/containerizer/mesos/isolators/volume/image.cpp (line 160) <https://reviews.apache.org/r/51172/#comment212528> kill this src/slave/containerizer/mesos/isolators/volume/image.cpp (line 165) <https://reviews.apache.org/r/51172/#comment212529> kill this - Guangya Liu On 八月 17, 2016, 8:44 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51172/ > ----------------------------------------------------------- > > (Updated 八月 17, 2016, 8:44 a.m.) > > > Review request for mesos, Benjamin Hindman, Benjamin Mahler, Artem > Harutyunyan, Jie Yu, Kevin Klues, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Implemented the volume/image isolator. > > > Diffs > ----- > > src/CMakeLists.txt 4362d472707193aa09343ef69f070e2d3efda324 > src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 > src/slave/containerizer/mesos/isolators/volume/image.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/volume/image.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/51172/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
