Review Request 52417: Implement catchup process for replicated log's read replica.

2016-10-01 Thread Igor Morozov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52417/ --- Review request for mesos. Repository: mesos Description --- Implement

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-10-01 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52002/#review151126 --- src/common/resources.cpp (lines 857 - 860)

Re: Review Request 51999: Refactor parsing of resources.

2016-10-01 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51999/#review150800 --- include/mesos/resources.hpp (line 172)

Re: Review Request 51715: Added a parallel gtest runner.

2016-10-01 Thread Benjamin Bannier
> On Sept. 21, 2016, 8:53 p.m., Kevin Klues wrote: > > support/mesos-gtest-runner.py, line 214 > > > > > > Can you add a quick comment about how this filter is working? It's not > > obvious at first glance what

Re: Review Request 51715: Added a parallel gtest runner.

2016-10-01 Thread Benjamin Bannier
> On Oct. 1, 2016, 11:10 p.m., Kevin Klues wrote: > > As a side note (I'm fine with shipping it as is for now), I'm wondering if > > we can't improve the output we see before / during / after the tests run. > > Right now, if I run `mesos-tests` I don't start to see any output for at > >

Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.

2016-10-01 Thread Sivaram Kannan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/ --- (Updated Oct. 1, 2016, 10:42 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 52311: Pass the user value from executor of switch_user flag is set.

2016-10-01 Thread Sivaram Kannan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52311/ --- (Updated Oct. 1, 2016, 10:35 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 51715: Added a parallel gtest runner.

2016-10-01 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/#review151122 --- As a side note (I'm fine with shipping it as is for now), I'm

Re: Review Request 50910: Added a python linter to mesos-style.cpp.

2016-10-01 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50910/#review151121 --- Ship it! Ship It! - Kevin Klues On Aug. 11, 2016, 9:54

Re: Review Request 50912: Added the infrastructure for a new python-based CLI.

2016-10-01 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50912/ --- (Updated Oct. 1, 2016, 8:09 p.m.) Review request for mesos, Haris Choudhary

Re: Review Request 51715: Added a parallel gtest runner.

2016-10-01 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/ --- (Updated Oct. 1, 2016, 9:06 p.m.) Review request for mesos, Kevin Klues and

Re: Review Request 51715: Added a parallel gtest runner.

2016-10-01 Thread Benjamin Bannier
> On Oct. 1, 2016, 7:43 p.m., Kevin Klues wrote: > > support/mesos-gtest-runner.py, lines 5-12 > > > > > > I would consider rewording this slightly, as it's not exactly clear to > > me what the difference between a

Re: Review Request 51715: Added a parallel gtest runner.

2016-10-01 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/ --- (Updated Oct. 1, 2016, 9:02 p.m.) Review request for mesos, Kevin Klues and

Re: Review Request 51715: Added a parallel gtest runner.

2016-10-01 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/#review151118 --- Fix it, then Ship it! The code itself looks great! Just a few

Re: Review Request 52064: Support for multiple versions of docs.

2016-10-01 Thread haosdent huang
> On Sept. 28, 2016, 3:55 a.m., haosdent huang wrote: > > site/source/layouts/documentation.erb, lines 15-19 > > > > > > Any reason that we add a back button instead of using the back button > > of browser? > > Tim

Re: Review Request 51027: Track allocation candidates to bound allocator.

2016-10-01 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51027/#review151117 --- src/master/allocator/mesos/hierarchical.cpp (line 1303)

Re: Review Request 46824: Fully qualified addresses of Flag members in add calls.

2016-10-01 Thread Benjamin Bannier
> On May 11, 2016, 11:27 p.m., Vinod Kone wrote: > > src/master/main.cpp, line 131 > > > > > > If `add` should be only called by derived classes, should `add` method > > be protected instead of public? > >

Re: Review Request 51716: Added configure option for Mesos test runner.

2016-10-01 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51716/ --- (Updated Oct. 1, 2016, 12:54 p.m.) Review request for mesos and Till

Re: Review Request 51718: Permitted specifying custom test driver in libprocess.

2016-10-01 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51718/ --- (Updated Oct. 1, 2016, 12:54 p.m.) Review request for mesos and Till

Re: Review Request 51719: Permitted specifying custom test driver in stout.

2016-10-01 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51719/ --- (Updated Oct. 1, 2016, 12:54 p.m.) Review request for mesos and Till

Re: Review Request 51717: Enable Mesos test runner.

2016-10-01 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51717/ --- (Updated Oct. 1, 2016, 12:54 p.m.) Review request for mesos and Till

Re: Review Request 52465: Fixed the race in master update slave.

2016-10-01 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52465/ --- (Updated 十月 1, 2016, 9:34 a.m.) Review request for mesos and Benjamin Mahler.