> On Oct. 1, 2016, 11:10 p.m., Kevin Klues wrote:
> > As a side note (I'm fine with shipping it as is for now), I'm wondering if 
> > we can't improve the output we see before / during / after the tests run. 
> > Right now, if I run  `mesos-tests` I don't start to see any output for at 
> > least 30-40 seconds. And when I do, it's just a series of dots that don't 
> > tell me a whole lot about the progress.
> > 
> > It would be nice to see a summary of how many tests are going to be run, 
> > how many are disabled, etc. right before they start running.
> > 
> > Just some suggestions for future improvements.

I think the handling of the logs currently goes as far as one can go without 
implementing a parser for the log output. Especially logging meaningfully 
during test execution is tricky as multiple concurrently running programs will 
log to the same output and some understanding of the output format is required 
to minimize interleaving.

Currently this logger supports three logging levels which all show output after 
a run is complete, with the minimal one being configured for `make check` in 
later patches in this series. Each test program will log its return status 
(either `.` for success, or `E` for failure), but this represents nothing like 
a true progress bar; we also log the overall status (`PASS` or `FAIL`). As the 
output while tests are still running is produced after shards exit, there will 
be some time before any output appears. With ideal execution, there would be no 
output until all shards exit simultanously.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51715/#review151122
-----------------------------------------------------------


On Oct. 1, 2016, 9:06 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51715/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2016, 9:06 p.m.)
> 
> 
> Review request for mesos, Kevin Klues and Till Toenshoff.
> 
> 
> Bugs: MESOS-6140
>     https://issues.apache.org/jira/browse/MESOS-6140
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds `b814987b28cfb65a7c9635c83399545e423e690a` of
> https://github.com/bbannier/gtest-shrdr.
> 
> 
> Diffs
> -----
> 
>   support/mesos-gtest-runner.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/51715/diff/
> 
> 
> Testing
> -------
> 
> Tested with e.g., `stout-tests`
> 
>     $ ./support/mesos-gtest-runner.py build/3rdparty/stout/stout-tests
>     ............
>     [PASS]
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to