Re: Review Request 53296: Added cgroup namespace support for unified container.

2016-11-06 Thread Jie Yu
> On Nov. 1, 2016, 4:43 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/namespaces/cgroup.hpp, line 28 > > > > > > Instead of creating a new namespace/cgroup isolator, I would suggest we > > add the

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

2016-11-06 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/#review154380 --- src/examples/persistent_volume_framework.cpp

Re: Review Request 53517: Added test case for cgroup namespace isolator.

2016-11-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53517/#review155107 --- Patch looks great! Reviews applied: [53296, 53515, 53516, 53517]

Re: Review Request 53330: Tracked layers and pull latency in docker store.

2016-11-06 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53330/ --- (Updated Nov. 7, 2016, 4:41 a.m.) Review request for mesos, Xiaojian Huang,

Re: Review Request 53105: Added an hourly timer for `slave/docker_containerizer/pull`.

2016-11-06 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53105/ --- (Updated Nov. 7, 2016, 4:40 a.m.) Review request for mesos, Xiaojian Huang,

Re: Review Request 53515: Fixed a typo in slave_recovery_tests.cpp.

2016-11-06 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53515/#review155105 --- Ship it! Ship It! - Qian Zhang On Nov. 6, 2016, 8:47 p.m.,

Re: Review Request 53296: Added cgroup namespace support for unified container.

2016-11-06 Thread haosdent huang
> On Nov. 1, 2016, 4:43 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/namespaces/cgroup.hpp, line 28 > > > > > > Instead of creating a new namespace/cgroup isolator, I would suggest we > > add the

Re: Review Request 50128: Added helper function to 'Docker::Device'.

2016-11-06 Thread Yubo Li
> On εδΈ€ζœˆ 4, 2016, 3:03 p.m., Guangya Liu wrote: > > What about update the summary and desription as this? > > > > Summary: > > ``` > > Overload the << operator for 'Docker::Device'. > > ``` > > > > Description: > > ``` > > This patch overload the << operator for 'Docker::Device', > > with

Re: Review Request 53296: Added cgroup namespace support for unified container.

2016-11-06 Thread Jie Yu
> On Nov. 1, 2016, 4:43 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/namespaces/cgroup.hpp, line 28 > > > > > > Instead of creating a new namespace/cgroup isolator, I would suggest we > > add the

Re: Review Request 53296: Added cgroup namespace support for unified container.

2016-11-06 Thread haosdent huang
> On Nov. 1, 2016, 4:43 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/namespaces/cgroup.hpp, line 28 > > > > > > Instead of creating a new namespace/cgroup isolator, I would suggest we > > add the

Re: Review Request 53296: Added cgroup namespace support for unified container.

2016-11-06 Thread Jie Yu
> On Nov. 1, 2016, 4:43 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/namespaces/cgroup.hpp, line 28 > > > > > > Instead of creating a new namespace/cgroup isolator, I would suggest we > > add the

Re: Review Request 52587: Allow CREATE of shared volumes based on capability of framework.

2016-11-06 Thread Neil Conway
> On Nov. 4, 2016, 7:30 p.m., Neil Conway wrote: > > src/master/validation.cpp, line 1532 > > > > > > Can we use consistent tense here? The other volume error messages say > > "has been attempted" rather than

Re: Review Request 53365: Fixed an issue in the gzip error handling.

2016-11-06 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53365/#review155091 --- hmm, I couldn't find any documentation around when `msg` may be

Re: Review Request 53296: Added cgroup namespace support for unified container.

2016-11-06 Thread haosdent huang
> On Nov. 1, 2016, 4:43 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/namespaces/cgroup.hpp, line 28 > > > > > > Instead of creating a new namespace/cgroup isolator, I would suggest we > > add the

Re: Review Request 53296: Added cgroup namespace support for unified container.

2016-11-06 Thread haosdent huang
> On Nov. 1, 2016, 4:43 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/namespaces/cgroup.hpp, line 28 > > > > > > Instead of creating a new namespace/cgroup isolator, I would suggest we > > add the

Re: Review Request 53296: Added cgroup namespace support for unified container.

2016-11-06 Thread Jie Yu
> On Nov. 1, 2016, 4:43 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/namespaces/cgroup.hpp, line 28 > > > > > > Instead of creating a new namespace/cgroup isolator, I would suggest we > > add the

Review Request 53517: Added test case for cgroup namespace isolator.

2016-11-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53517/ --- Review request for mesos, Jie Yu, Qian Zhang, and Jiang Yan Xu. Bugs:

Review Request 53516: Moved `namespaces/pid` associated test cases to a separate file.

2016-11-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53516/ --- Review request for mesos, Jie Yu, Qian Zhang, and Jiang Yan Xu. Bugs:

Review Request 53515: Fixed a typo in slave_recovery_tests.cpp.

2016-11-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53515/ --- Review request for mesos, Jie Yu, Qian Zhang, and Jiang Yan Xu. Bugs:

Re: Review Request 53296: Added cgroup namespace support for unified container.

2016-11-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53296/ --- (Updated Nov. 6, 2016, 12:47 p.m.) Review request for mesos, Jie Yu, Qian

Re: Review Request 53296: Added cgroup namespace support for unified container.

2016-11-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53296/#review155080 --- Patch looks great! Reviews applied: [53296] Passed command:

Re: Review Request 53296: Added cgroup namespace support for unified container.

2016-11-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53296/ --- (Updated Nov. 6, 2016, 7:35 a.m.) Review request for mesos, Jie Yu, Qian