----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53365/#review155091 -----------------------------------------------------------
hmm, I couldn't find any documentation around when `msg` may be not be set for error cases except for `deflateEnd()` and `inflateEnd()`. Can you share some? AFAICT, we only need to add a fallback for these 2 calls and not all of the ones as has been done in this review. Also, I don't think we need to even check the return type of `deflateEnd()`/`inflateEnd()` since we are sure that the state of the stream is consistent i.e., `Z_STREAM_END`? - Anand Mazumdar On Nov. 2, 2016, 3:02 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53365/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2016, 3:02 a.m.) > > > Review request for mesos and Anand Mazumdar. > > > Repository: mesos > > > Description > ------- > > It turns out that zlib does not always set the `msg` field, the > calling code is expected to handle the case where `msg` is NULL. > I discovered this while I was playing with the library during > the implementation of a streaming decompressor. > > > Diffs > ----- > > 3rdparty/stout/include/stout/gzip.hpp > b78a8a31204ee585f8e4a88eaefe7346faa46b8d > > Diff: https://reviews.apache.org/r/53365/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
