Re: Review Request 54115: Added an http::serve abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54115/#review157001 --- Bad patch! Reviews applied: [54115, 54114, 54113, 54112, 54111,

Review Request 54116: Added test for `slavePreLaunchDockerTaskExecutorDecorator` hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54116/ --- Review request for mesos, Adam B, Gastón Kleiman, and Kapil Arya. Bugs:

Re: Review Request 53457: Updated Socket::Impl::accept to return std::shared_ptr.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53457/ --- (Updated Nov. 28, 2016, 7:18 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 53457: Updated Socket::Impl::accept to return std::shared_ptr.

> On Nov. 11, 2016, 1:06 a.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/poll_socket.cpp, lines 109-115 > > > > > > This introduces a leakable path for the 's' file descriptor: if create > > fails, 's' is

Re: Review Request 54039: Added `recordio::transform` helper.

> On Nov. 28, 2016, 3:23 a.m., Anand Mazumdar wrote: > > src/common/recordio.hpp, line 112 > > > > > > hmm, this doesn't need to be an `Owned` here. Can we just use > > `Reader&& reader` instead? > > > >

Re: Review Request 54039: Added `recordio::transform` helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54039/ --- (Updated Nov. 28, 2016, 6:48 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 54039: Added `recordio::transform` helper.

> On Nov. 27, 2016, 10:49 p.m., Anand Mazumdar wrote: > > src/common/recordio.hpp, lines 128-130 > > > > > > hmm, it's a bit unfortunate that we would _only_ notice a disconnection > > between the client and the

Review Request 54114: Updated http::Connection::disconnect to do a complete socket shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54114/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 54115: Added an http::serve abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54115/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 54111: Removed unused Socket from Encoder.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54111/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 54113: Added support for specifying how a socket should be shutdown.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54113/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 54112: Added support for http::connect to take an network::Address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54112/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 54110: Added `process::loop` abstraction.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54110/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 54109: Changes in Mesos to make http::Request::client optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54109/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 53462: Updated usage of network::Address and network::Socket in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53462/ --- (Updated Nov. 28, 2016, 6:18 a.m.) Review request for mesos, Benjamin Mahler

Review Request 54108: Changes in libprocess to make http::Request::client optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54108/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 53462: Updated usage of network::Address in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53462/ --- (Updated Nov. 28, 2016, 6:17 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 53460: Refactored network::Address into inet::Address.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53460/ --- (Updated Nov. 28, 2016, 6:15 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 54053: Updated 'io::redirect()' to take an optional vector of callback hooks.

> On Nov. 28, 2016, 2:32 a.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/io.hpp, line 130 > > > > > > We typically prefer explicit typing, instead of using typedef. > > Kevin Klues wrote: > Meaning,

Re: Review Request 53459: Refactored `Socket` to support a templated version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53459/ --- (Updated Nov. 28, 2016, 5:40 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 53458: Removed `Socket` dependency on `Socket::Impl`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53458/ --- (Updated Nov. 28, 2016, 5:38 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 54053: Updated 'io::redirect()' to take an optional vector of callback hooks.

> On Nov. 28, 2016, 2:32 a.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/io.hpp, line 130 > > > > > > We typically prefer explicit typing, instead of using typedef. Meaning, don't have a type called

Re: Review Request 54039: Added `recordio::transform` helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54039/#review156984 --- src/common/recordio.hpp (line 112)

Re: Review Request 54053: Updated 'io::redirect()' to take an optional vector of callback hooks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54053/#review156982 --- Fix it, then Ship it!

Re: Review Request 54049: Cleaned up includes in tests/api_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54049/#review156979 --- Ship it! I would use the description as the summary instead.

Re: Review Request 53994: Added streaming support to `/api/v1` handler on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53994/#review156978 --- Looks good. Mostly comments around getting rid of the `_api()`

Re: Review Request 54039: Added `recordio::transform` helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54039/#review156976 --- src/common/recordio.hpp (lines 128 - 130)

Re: Review Request 54093: Refactored recordio::ReaderProcess to be managed by gc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54093/#review156973 --- Ship it! src/common/recordio.hpp (line 107)

Re: Review Request 53123: Made `process::defaultClone` private.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53123/#review156974 --- Patch looks great! Reviews applied: [53118, 53119, 53120, 53121,

Re: Review Request 54048: Fixed a bug in scheduler library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54048/#review156972 --- Ship it! Ship It! - Anand Mazumdar On Nov. 26, 2016, 5:40

Re: Review Request 53517: Added test case for cgroup namespace isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53517/#review156971 --- Patch looks great! Reviews applied: [53296, 53516, 54105, 53517]

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54062/ --- (Updated Nov. 27, 2016, 4:12 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 53123: Made `process::defaultClone` private.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53123/ --- (Updated Nov. 27, 2016, 4:10 p.m.) Review request for mesos, Alexander

Re: Review Request 53122: Used child hooks to enter namespaces in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53122/ --- (Updated Nov. 27, 2016, 4:09 p.m.) Review request for mesos, Alexander

Re: Review Request 53121: Added a child hook for entering the target pid's namespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53121/ --- (Updated Nov. 27, 2016, 4:01 p.m.) Review request for mesos, Alexander

Re: Review Request 53120: Moved `ns.hpp` to stout [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53120/ --- (Updated Nov. 27, 2016, 4 p.m.) Review request for mesos, Alexander Rukletsov,

Re: Review Request 53517: Added test case for cgroup namespace isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53517/ --- (Updated Nov. 27, 2016, 3:39 p.m.) Review request for mesos, Jie Yu, Qian

Review Request 54105: Added `CgroupNamespaceFilter`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54105/ --- Review request for mesos, Jie Yu, Qian Zhang, and Jiang Yan Xu. Bugs:

Re: Review Request 53516: Moved `namespaces/pid` associated test cases to a separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53516/ --- (Updated Nov. 27, 2016, 3:38 p.m.) Review request for mesos, Jie Yu, Qian

Re: Review Request 53515: Fixed a typo in slave_recovery_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53515/ --- (Updated Nov. 27, 2016, 3:36 p.m.) Review request for mesos, Jie Yu, Qian

Re: Review Request 53296: Added cgroup namespace support for unified container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53296/ --- (Updated Nov. 27, 2016, 3:34 p.m.) Review request for mesos, Jie Yu, Qian

Re: Review Request 53517: Added test case for cgroup namespace isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53517/ --- (Updated Nov. 27, 2016, 2:24 p.m.) Review request for mesos, Jie Yu, Qian

Re: Review Request 53516: Moved `namespaces/pid` associated test cases to a separate file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53516/ --- (Updated Nov. 27, 2016, 2:23 p.m.) Review request for mesos, Jie Yu, Qian

Re: Review Request 53296: Added cgroup namespace support for unified container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53296/ --- (Updated Nov. 27, 2016, 2:22 p.m.) Review request for mesos, Jie Yu, Qian

Re: Review Request 53146: Added a child hook for switching the user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53146/ --- (Updated Nov. 27, 2016, 2:15 p.m.) Review request for mesos, Alexander

Re: Review Request 53147: Made health check run under the same user with tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53147/ --- (Updated Nov. 27, 2016, 2:15 p.m.) Review request for mesos, Alexander

Re: Review Request 54104: Adjusted code style in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54104/#review156966 --- Patch looks great! Reviews applied: [54104] Passed command:

Re: Review Request 53147: Made health check run under the same user with tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53147/#review156965 --- Bad patch! Reviews applied: [53147, 53146] Failed command:

Review Request 53123: Made `process::defaultClone` private.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53123/ --- Review request for mesos, Alexander Rukletsov, Gastón Kleiman, Jie Yu, and Qian

Re: Review Request 53121: Added a child hook for entering the target pid's namespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53121/ --- (Updated Nov. 27, 2016, 10:45 a.m.) Review request for mesos, Alexander

Re: Review Request 53122: Used child hooks to enter namespaces in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53122/ --- (Updated Nov. 27, 2016, 10:46 a.m.) Review request for mesos, Alexander

Re: Review Request 53119: Moved `ns.hpp` to stout [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53119/ --- (Updated Nov. 27, 2016, 10:45 a.m.) Review request for mesos, Alexander

Re: Review Request 53120: Moved `ns.hpp` to stout [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53120/ --- (Updated Nov. 27, 2016, 10:45 a.m.) Review request for mesos, Alexander

Re: Review Request 53118: Fixed incorrect header order in `cni.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53118/ --- (Updated Nov. 27, 2016, 10:45 a.m.) Review request for mesos, Alexander

Review Request 54104: Adjusted code style in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54104/ --- Review request for mesos, Alexander Rukletsov, Gastón Kleiman, Jie Yu, and Qian

Re: Review Request 53146: Added a child hook for switching the user.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53146/ --- (Updated Nov. 27, 2016, 10:39 a.m.) Review request for mesos, Alexander

Re: Review Request 53147: Made health check run under the same user with tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53147/ --- (Updated Nov. 27, 2016, 10:39 a.m.) Review request for mesos, Alexander

Re: Review Request 53122: Used child hooks to enter namespaces in health check.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53122/ --- (Updated Nov. 27, 2016, 10:37 a.m.) Review request for mesos, Alexander

Re: Review Request 53121: Added a child hook for entering the target pid's namespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53121/ --- (Updated Nov. 27, 2016, 10:37 a.m.) Review request for mesos, Alexander

Re: Review Request 53118: Fixed incorrect header order in `cni.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53118/ --- (Updated Nov. 27, 2016, 10:36 a.m.) Review request for mesos, Alexander

Re: Review Request 53120: Moved `ns.hpp` to stout [2/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53120/ --- (Updated Nov. 27, 2016, 10:36 a.m.) Review request for mesos, Alexander

Re: Review Request 53119: Moved `ns.hpp` to stout [1/2].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53119/ --- (Updated Nov. 27, 2016, 10:36 a.m.) Review request for mesos, Alexander

Re: Review Request 54103: Made MesosContainerizer launch helper to take ContainerLaunchInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54103/#review156964 --- Patch looks great! Reviews applied: [54095, 54096, 54097, 54098,