Re: Review Request 54650: Added validation for roles in ACCEPT call.

> On Dec. 13, 2016, 11:04 p.m., Guangya Liu wrote: > > src/master/validation.cpp, line 1411 > > > > > > Shall we add some check here to make sure the `allocation_info` exist > > as this field is `optional`? > >

Re: Review Request 55021: Added a framework capabilities struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55021/ --- (Updated Jan. 6, 2017, 3:21 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 55251: Added `filterRoles` method to extract some logic from `_roles`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55251/ --- Review request for mesos, Anand Mazumdar, Benjamin Bannier, Benjamin Mahler,

Review Request 55255: Added a test to check 'roles' is included in the `/state`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55255/ --- Review request for mesos, Anand Mazumdar, Benjamin Bannier, Benjamin Mahler,

Review Request 55253: Added 'roles' section in the response of `/state` endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55253/ --- Review request for mesos, Anand Mazumdar, Benjamin Bannier, Benjamin Mahler,

Review Request 55252: Added `_getRoles()` to extract some logic of `getRoles()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55252/ --- Review request for mesos, Anand Mazumdar, Benjamin Bannier, Benjamin Mahler,

Review Request 55254: Inserted `getRoles` to `getState`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55254/ --- Review request for mesos, Anand Mazumdar, Benjamin Bannier, Benjamin Mahler,

Re: Review Request 54688: Added a `docker_store_dir` flag to tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54688/#review160677 --- Bad review! Reviews applied: [54688, 52773, 52772, 53264]

Re: Review Request 55224: Removed unused namespace alias declarations in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55224/#review160673 --- Patch looks great! Reviews applied: [55218, 55219, 55226, 55220,

Re: Review Request 55068: Added Capabilities to Framework struct of Hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55068/#review160666 --- Patch looks great! Reviews applied: [55021, 55066, 55068]

Review Request 55242: Stop using os::system to chown a directory hierarchy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55242/ --- Review request for mesos, Benjamin Mahler and Jiang Yan Xu. Bugs: MESOS-6862

Review Request 55241: Stop using os::system to validate perf event names.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55241/ --- Review request for mesos, Benjamin Mahler, Greg Mann, and Jiang Yan Xu. Bugs:

Review Request 55240: Stop using os::system to copy local files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55240/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-6862

Review Request 55239: Stop using os::system to extract fetcher archives.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55239/ --- Review request for mesos, Jie Yu and Jiang Yan Xu. Bugs: MESOS-6862

Review Request 55238: Use os::spawn in the CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55238/ --- Review request for mesos, Avinash sridharan and Jiang Yan Xu. Bugs: MESOS-6862

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/#review160652 --- Patch looks great! Reviews applied: [54996] Passed command:

Re: Review Request 55162: Stout: Added style fixes and some useful error messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55162/ --- (Updated Jan. 6, 2017, 12:03 a.m.) Review request for mesos, Andrew

Re: Review Request 55006: CMake: renamed test binaries to match autotools.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55006/#review160651 --- support/windows-build.bat (line 73)

Re: Review Request 55005: CMake: renamed `process_tests` to `libprocess-tests` to match autotools.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55005/#review160650 --- 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake (line 20)

Re: Review Request 55005: CMake: renamed `process_tests` to `libprocess-tests` to match autotools.

> On Dec. 27, 2016, 1:14 p.m., Till Toenshoff wrote: > > 3rdparty/libprocess/src/tests/CMakeLists.txt, line 67 > > > > > > s/process-tests/libprocess-tests/ ? I would say this is not necessary. On `libx` is a POSIX

Re: Review Request 55004: CMake: renamed `stout_tests` to `stout-tests` to match autotools.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55004/#review160647 --- Ship it! Ship It! - Alex Clemmer On Dec. 23, 2016, 2:09

Re: Review Request 55177: Fixed scheme handling in URL::parse().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55177/#review160648 --- Can you write a JIRA for this and update this review? - Timothy

Re: Review Request 55162: Stout: Added style fixes and some useful error messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55162/ --- (Updated Jan. 5, 2017, 11:27 p.m.) Review request for mesos, Andrew

Re: Review Request 55177: Fixed scheme handling in URL::parse().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55177/#review160637 --- Patch looks great! Reviews applied: [55177] Passed command:

Re: Review Request 54688: Added a `docker_store_dir` flag to tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54688/ --- (Updated Jan. 5, 2017, 10:15 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 55162: Stout: Added style fixes and some useful error messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55162/#review160627 --- Patch looks great! Reviews applied: [55022, 55023, 55024, 55025,

Re: Review Request 55224: Removed unused namespace alias declarations in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55224/ --- (Updated Jan. 5, 2017, 8:07 p.m.) Review request for mesos and Michael Park.

Re: Review Request 55222: Avoided unnecessary copies in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55222/ --- (Updated Jan. 5, 2017, 8:05 p.m.) Review request for mesos and Michael Park.

Re: Review Request 55220: Cleaned up std::string usage in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55220/ --- (Updated Jan. 5, 2017, 8:04 p.m.) Review request for mesos and Michael Park.

Review Request 55226: Cleaned up std::string usage in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55226/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 55160: Added test for DockerContainerizer when `cgroups_enable_cfs` is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55160/ --- (Updated Jan. 5, 2017, 7:39 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 51052: Made mesos-docker-execute understand cgroups_enable_cfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51052/ --- (Updated Jan. 5, 2017, 7:39 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 54821: Refactored Docker::run() to make it only aware of docker cli options.

> On Jan. 4, 2017, 7:58 p.m., Jie Yu wrote: > > src/docker/docker.hpp, line 149 > > > > > > What is this? Should that be part of `env`? Talked to @gilbert offline, we believe this is not necessary anymore, so

Re: Review Request 54821: Refactored Docker::run() to make it only aware of docker cli options.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54821/ --- (Updated Jan. 5, 2017, 7:37 p.m.) Review request for mesos, Xiaojian Huang,

Review Request 55224: Removed unused namespace alias declarations in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55224/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 55223: Removed unused namespace alias declarations in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55223/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 55222: Avoided unnecessary copies in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55222/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 55221: Avoided needless copies in log tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55221/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 55219: Cleaned up std::string usage in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55219/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 55220: Cleaned up std::string usage in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55220/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 55218: Removed redundant `return` in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55218/ --- Review request for mesos and Michael Park. Repository: mesos Description

Re: Review Request 54873: Added asynchronous libcurl support to Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54873/#review160505 --- I got the feeling that nothing prevents `ContextImpl` completion

Re: Review Request 54688: Added a `docker_store_dir` flag to tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54688/ --- (Updated Jan. 5, 2017, 6 p.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/ --- (Updated Jan. 5, 2017, 6:05 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 55191: Add hostname support to the network/cni isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55191/ --- (Updated Jan. 5, 2017, 5:04 p.m.) Review request for mesos, Avinash sridharan,

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/ --- (Updated Jan. 5, 2017, 6:04 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 55021: Added a framework capabilities struct.

> On Jan. 5, 2017, 4:52 p.m., Benjamin Bannier wrote: > > While looking at https://reviews.apache.org/r/55068/, should we also update > > `mesos::internal::protobuf::frameworkHasCapability` here? Please disregard this comment, I got confused about the use value types. - Benjamin

Re: Review Request 53299: Fixed memory leak in implementation of Future::after().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53299/#review160603 --- Ship it! Ship It! - Joris Van Remoortere On Jan. 4, 2017,

Re: Review Request 55021: Added a framework capabilities struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55021/#review160599 --- While looking at https://reviews.apache.org/r/55068/, should we

Re: Review Request 54952: Made `getpwnam_r` error handling more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54952/#review160595 --- Ship it! Ship It! - Alexander Rukletsov On Dec. 28, 2016,

Re: Review Request 55021: Added a framework capabilities struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55021/#review160591 --- src/common/protobuf_utils.hpp (line 44)

Re: Review Request 54952: Made `getpwnam_r` error handling more robust.

> On Dec. 23, 2016, 10:40 a.m., Alexander Rukletsov wrote: > > 3rdparty/stout/include/stout/os/posix/su.hpp, line 66 > > > > > > How about pulling `delete[] buffer` before the comment because it is > > common to

Re: Review Request 52877: Fixed wrong float serialization in JSON in locales different from C.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52877/#review160587 --- This looks like a much more light-weight solution. It might be

Re: Review Request 55021: Added a framework capabilities struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55021/ --- (Updated Jan. 5, 2017, 8:19 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 55068: Added Capabilities to Framework struct of Hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55068/ --- (Updated Jan. 5, 2017, 8:19 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 55066: Added Capabilities to Framework struct of Master and Agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55066/ --- (Updated Jan. 5, 2017, 8:19 p.m.) Review request for mesos, Benjamin Bannier,