Re: Review Request 55691: Fix XSS vulnerability in pailer invocation.

2017-01-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55691/#review162593 --- Fix it, then Ship it! Ship It!

Re: Review Request 55829: Updated resources quantity stripping to strip AllocationInfo.

2017-01-22 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55829/#review162588 --- Patch looks great! Reviews applied: [54842, 54836, 55825, 55826,

Re: Review Request 55770: Fixed navbar and logo size in WebUI.

2017-01-22 Thread haosdent huang
> On Jan. 20, 2017, 3:18 p.m., haosdent huang wrote: > > src/webui/master/static/index.html, line 33 > > > > > > How about add class `.img-responsive` directly? > > Ilya Pronin wrote: > I tried, that didn't work

Re: Review Request 50871: Supported auto backend in Unified Containerizer.

2017-01-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50871/#review162586 --- src/slave/containerizer/mesos/provisioner/provisioner.hpp (lines

Re: Review Request 55770: Fixed navbar and logo size in WebUI.

2017-01-22 Thread haosdent huang
> On Jan. 20, 2017, 3:18 p.m., haosdent huang wrote: > > src/webui/master/static/index.html, line 33 > > > > > > How about add class `.img-responsive` directly? > > Ilya Pronin wrote: > I tried, that didn't work

Review Request 55829: Updated resources quantity stripping to strip AllocationInfo.

2017-01-22 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55829/ --- Review request for mesos, Benjamin Bannier, Jay Guo, Guangya Liu, and Michael

Review Request 55827: Added the ability to devolve v1 Resources.

2017-01-22 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55827/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 55826: Added a missing include to evolve.hpp.

2017-01-22 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55826/ --- Review request for mesos and Michael Park. Repository: mesos Description

Review Request 55825: Augmented printing of Resources to include AllocationInfo.

2017-01-22 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55825/ --- Review request for mesos, Jay Guo, Guangya Liu, and Michael Park. Bugs:

Re: Review Request 54836: Added helpers to allocate / unallocate Resources.

2017-01-22 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54836/ --- (Updated Jan. 23, 2017, 1:55 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 54836: Added helpers to allocate / unallocate Resources.

2017-01-22 Thread Benjamin Mahler
> On Dec. 18, 2016, 1:10 a.m., Guangya Liu wrote: > > src/common/resources.cpp, line 1075 > > > > > > How about put this in the `if` block? > > Benjamin Mahler wrote: > Then this wouldn't clear the allocation?

Re: Review Request 55271: Disallow multi-role frameworks to change their roles.

2017-01-22 Thread Michael Park
> On Jan. 20, 2017, 7:30 p.m., Michael Park wrote: > > src/master/master.hpp, lines 2475-2516 > > > > > > We set the `validationError` to `None` just above, so this should > > always be `true`. It looks to me

Re: Review Request 55714: Added fs::typeName() mapping function for fs id to fs type mapping.

2017-01-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55714/#review162582 --- Fix it, then Ship it! src/linux/fs.cpp (line 103)

Re: Review Request 55713: Added linux helper function fs::type() for filesystem id detection.

2017-01-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55713/#review162581 --- Ship it! Ship It! - Jie Yu On Jan. 20, 2017, 10:11 a.m.,

Re: Review Request 54215: Fixed duplicate image layer ids returned by docker store.

2017-01-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54215/#review162580 --- Let's take a look how docker handles this case. My feeling is

Re: Review Request 54816: Replaced os::getcwd() to sandbox.get() in provisioner test.

2017-01-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54816/#review162579 --- Ship it! Ship It! - Jie Yu On Jan. 19, 2017, 12:08 p.m.,

Re: Review Request 54213: Supported more layers through symlink for aufs backend.

2017-01-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54213/#review162577 --- src/slave/containerizer/mesos/provisioner/backends/aufs.cpp

Re: Review Request 54214: Added unit test for aufs backend supporting many layers.

2017-01-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54214/#review162578 --- Ship it! Ship It! - Jie Yu On Jan. 19, 2017, 12:08 p.m.,

Re: Review Request 54212: Fixed overlay backend provisioning multi images symlink.

2017-01-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54212/#review162576 --- src/slave/containerizer/mesos/provisioner/backends/overlay.cpp

Re: Review Request 55791: Rework clipboard functionality in UI.

2017-01-22 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55791/ --- (Updated Jan. 22, 2017, 6:11 p.m.) Review request for mesos and haosdent

Re: Review Request 55807: Updated the list of terminal states in the webui.

2017-01-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55807/#review162575 --- Ship it! LGTM, let's commit them if the other patches in this

Re: Review Request 55805: Updated webui to display number of unreachable agents.

2017-01-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55805/#review162574 --- Ship it! Ship It! - haosdent huang On Jan. 21, 2017, 11:27

Re: Review Request 55809: Fixed HTML syntax error in webui.

2017-01-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55809/#review162572 --- Ship it! Ship It! - haosdent huang On Jan. 21, 2017, 11:27

Re: Review Request 55459: Added task check validation test.

2017-01-22 Thread Alexander Rukletsov
> On Jan. 21, 2017, 3:39 p.m., Vinod Kone wrote: > > Still planning to check against the actual strings? I usually tend to avoid this (what you say in the comment), but we can add them. - Alexander --- This is an automatically