Review Request 58646: Fixed a style issue in v1 mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58646/ --- Review request for mesos, Gilbert Song and Artem Harutyunyan. Bugs: MESOS-4263

Review Request 58645: Updated the tests to verify persistent volume usage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58645/ --- Review request for mesos, Gilbert Song and Artem Harutyunyan. Bugs: MESOS-4263

Review Request 58644: Improved POSIX disk isolator to report usage for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58644/ --- Review request for mesos, Gilbert Song and Artem Harutyunyan. Bugs: MESOS-4263

Review Request 58643: Added a TODO about an issue in POSIX disk isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58643/ --- Review request for mesos, Gilbert Song and Artem Harutyunyan. Bugs: MESOS-4263

Review Request 58642: Cancelled the disk usage collection if no longer needed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58642/ --- Review request for mesos, Gilbert Song and Artem Harutyunyan. Bugs: MESOS-4263

Review Request 58641: Fixed a style issue in mesos.proto.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58641/ --- Review request for mesos, Gilbert Song and Artem Harutyunyan. Bugs: MESOS-4263

Review Request 58640: Updated the Overwrite docker provisioner test for MESOS-7280.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58640/ --- Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. Bugs:

Re: Review Request 57254: Added support for hierarchical roles to DRFSorter.

> On April 20, 2017, 2:35 a.m., Michael Park wrote: > > src/master/allocator/sorter/drf/sorter.cpp > > Line 155 (original), 328 (patched) > > > > > > ``` > > for (Node* current = CHECK_NOTNULL(find(name)); > >

Re: Review Request 57254: Added support for hierarchical roles to DRFSorter.

> On April 20, 2017, 2:35 a.m., Michael Park wrote: > > src/master/allocator/sorter/drf/sorter.cpp > > Lines 117-125 (patched) > > > > > > I think this would be cleaner to say: > > ```cpp > > auto iter =

Re: Review Request 58626: Added executor authentication and authorization to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58626/#review172723 --- Patch looks great! Reviews applied: [58626] Passed command:

Re: Review Request 57964: Added a test to verify metrics when shared resources are present.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57964/#review172689 --- src/tests/persistent_volume_tests.cpp Lines 1174-1175 (patched)

Re: Review Request 58626: Added executor authentication and authorization to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58626/ --- (Updated April 21, 2017, 10:03 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 58626: Added executor authentication and authorization to the CHANGELOG.

> On April 21, 2017, 9:23 p.m., Vinod Kone wrote: > > CHANGELOG > > Lines 24 (patched) > > > > > > Do you want to add some blurb to `upgrades.md` regarding the disruption > > and link it from here? > > > >

Review Request 58635: Updated the upgrade documentation for executor authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58635/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-7005

Re: Review Request 58626: Added executor authentication and authorization to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58626/#review172713 --- CHANGELOG Lines 24 (patched)

Re: Review Request 58625: Added documentation for executor authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58625/#review172712 --- Ship it! Ship It! - Vinod Kone On April 21, 2017, 7:16

Re: Review Request 58624: Added test for failed HTTP executor authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58624/#review172711 --- Ship it! Nice test. - Vinod Kone On April 21, 2017, 8:52

Re: Review Request 58624: Added test for failed HTTP executor authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58624/ --- (Updated April 21, 2017, 8:52 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 58626: Added executor authentication and authorization to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58626/ --- (Updated April 21, 2017, 7:16 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 58625: Added documentation for executor authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58625/ --- (Updated April 21, 2017, 7:16 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 58624: Added test for failed HTTP executor authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58624/ --- (Updated April 21, 2017, 7:09 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 58603: Allowed whitelist additional devices in cgroups devices subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58603/#review172699 --- At a high level, I'd suggest breaking this patch into several

Review Request 58626: Added executor authentication and authorization to the CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58626/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-7005

Review Request 58625: Added documentation for executor authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58625/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-7005

Review Request 58624: Added test for failed HTTP executor authentication.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58624/ --- Review request for mesos, Anand Mazumdar, Alexander Rojas, and Vinod Kone.

Re: Review Request 58303: Pass the slave pointer directly to Master::removeTask.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58303/#review172701 --- Patch looks great! Reviews applied: [58304, 58305, 58621, 58622,

Re: Review Request 53840: Metric in the allocator to track latency in running allocations.

> On April 20, 2017, 6:04 p.m., James Peach wrote: > > If I understand this correctly, this is publishing a time series of the > > idle time between allocator runs. Is that correct? If so, what insight does > > this metric give and how should operators interpret it? Why is a simple > >

Re: Review Request 53840: Metric in the allocator to track latency in running allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53840/ --- (Updated April 21, 2017, 5:53 p.m.) Review request for mesos, James Peach and

Re: Review Request 58428: Added tests for failed executor authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58428/#review172687 --- Ship it! Ship It! - Vinod Kone On April 19, 2017, 6:48

Re: Review Request 58255: Added implicit authorization to the agent executor API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58255/#review172686 --- Ship it! Ship It! - Vinod Kone On April 19, 2017, 12:34

Re: Review Request 57963: Metrics for used resources should incorporate shared resources.

> On April 21, 2017, 10:37 a.m., Jiang Yan Xu wrote: > > LGTM! > > > > Can we have a test? It doesn't have to be a standalone test if we already > > have a test that just launches tasks from two frameworks, then we can just > > add it to the test? If not seems like that's proper test to have

Re: Review Request 57963: Metrics for used resources should incorporate shared resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57963/#review172681 --- LGTM! Can we have a test? It doesn't have to be a standalone

Review Request 58622: Document that master message validation is best effort.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58622/ --- Review request for mesos and Neil Conway. Bugs: MESOS-7372

Re: Review Request 58303: Pass the slave pointer directly to Master::removeTask.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58303/ --- (Updated April 21, 2017, 5:04 p.m.) Review request for mesos, Adam B, Mesos

Re: Review Request 58621: Add some parameter validation to RegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58621/ --- (Updated April 21, 2017, 4:57 p.m.) Review request for mesos and Neil Conway.

Review Request 58621: Add some parameter validation to RegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58621/ --- Review request for mesos and Neil Conway. Bugs: MESOS-7372

Re: Review Request 58303: Pass the slave pointer directly to Master::removeTask.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58303/ --- (Updated April 21, 2017, 4:57 p.m.) Review request for mesos, Adam B, Mesos

Re: Review Request 58305: Add some parameter validation to ReRegisterSlaveMessage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/ --- (Updated April 21, 2017, 4:56 p.m.) Review request for mesos, Mesos Reviewbot

Re: Review Request 58603: Allowed whitelist additional devices in cgroups devices subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58603/#review172602 --- Patch looks great! Reviews applied: [58603] Passed command:

Re: Review Request 58545: Removed NOTE about incomplete implementation of FrameworkInfo.roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58545/#review172593 --- Ship it! Ship It! - Benjamin Bannier On April 20, 2017,

Re: Review Request 58603: Allowed whitelist additional devices in cgroups devices subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58603/ --- (Updated April 21, 2017, 7:02 a.m.) Review request for mesos, haosdent huang

Review Request 58603: Allowed whitelist additional devices in cgroups devices subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58603/ --- Review request for mesos, haosdent huang and Jie Yu. Bugs: MESOS-6791

Re: Review Request 58584: Disabled support for setting quota on nested roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58584/#review172587 --- LGTM src/master/quota_handler.cpp Lines 518-521 (patched)