Re: Review Request 58137: CLI: Added 'mesos config show' command to display the config file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58137/#review173996 --- Patch looks great! Reviews applied: [57896, 57951, 58381, 57952,

Re: Review Request 57816: Add a scheduler flag `suppress_offers_on_registration`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57816/ --- (Updated May 5, 2017, 2:21 a.m.) Review request for mesos, James Peach, Vinod

Re: Review Request 58998: Fixed extra newline in webui for re-registered frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58998/#review173992 --- src/webui/master/static/framework.html Lines 40-41 (original),

Re: Review Request 58998: Fixed extra newline in webui for re-registered frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58998/#review173991 --- Patch looks great! Reviews applied: [58998] Passed command:

Re: Review Request 57817: Offers not sent for deactivated roles as indicated in `SUBSCRIBE`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/ --- (Updated May 5, 2017, 12:34 a.m.) Review request for mesos, James Peach, Vinod

Re: Review Request 57818: Added unit tests to verify offers are suppressed based on registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57818/ --- (Updated May 5, 2017, 12:34 a.m.) Review request for mesos, James Peach, Vinod

Re: Review Request 57815: Added `deactivated_roles` field in `FrameworkInfo`.

> On April 17, 2017, 6:28 p.m., Vinod Kone wrote: > > include/mesos/scheduler/scheduler.proto > > Lines 249-250 (original), 249-250 (patched) > > > > > > Hmm, I was hoping that we could re-use the `Call::Suppress`

Re: Review Request 57815: Added `deactivated_roles` field in `FrameworkInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57815/ --- (Updated May 5, 2017, 12:34 a.m.) Review request for mesos, James Peach, Vinod

Re: Review Request 58759: Introduced SecretFetcher module interface.

> On May 4, 2017, 6:25 p.m., Jie Yu wrote: > > include/mesos/module/secretfetcher.hpp > > Lines 17 (patched) > > > > > > secret_fetcher.hpp > > > > (we have secret_generator.hpp). Let's make sure it's

Re: Review Request 58999: Added --secret_fetcher flag for agent.

> On May 4, 2017, 6:29 p.m., Jie Yu wrote: > > src/slave/containerizer/containerizer.hpp > > Lines 66 (patched) > > > > > > Why optional? > > Kapil Arya wrote: > That way we don't have to update the existing

Re: Review Request 58999: Added --secret_fetcher flag for agent.

> On May 4, 2017, 10:29 p.m., Jie Yu wrote: > > src/slave/containerizer/containerizer.hpp > > Lines 66 (patched) > > > > > > Why optional? > > Kapil Arya wrote: > That way we don't have to update the existing

Re: Review Request 58759: Introduced SecretFetcher module interface.

> On May 4, 2017, 10:25 p.m., Jie Yu wrote: > > include/mesos/secret/fetcher.hpp > > Lines 17 (patched) > > > > > > I'd put the file to include/mesos/fetcher/secret_fetcher.hpp > > Kapil Arya wrote: > I am not

Re: Review Request 58999: Added --secret_fetcher flag for agent.

> On May 4, 2017, 10:29 p.m., Jie Yu wrote: > > src/slave/containerizer/containerizer.hpp > > Lines 66 (patched) > > > > > > Why optional? > > Kapil Arya wrote: > That way we don't have to update the existing

Re: Review Request 58759: Introduced SecretFetcher module interface.

> On May 4, 2017, 6:25 p.m., Jie Yu wrote: > > include/mesos/secret/fetcher.hpp > > Lines 17 (patched) > > > > > > I'd put the file to include/mesos/fetcher/secret_fetcher.hpp I am not sure so sure about it because

Re: Review Request 58880: Added Secret to Image::Docker in v1/mesos.proto.

> On May 2, 2017, 5:11 p.m., Vinod Kone wrote: > > Make sure to update unversioned mesos.proto as well. Follow up by https://reviews.apache.org/r/59010/ - Gilbert --- This is an automatically generated e-mail. To reply, visit:

Review Request 59019: Updated the documentation for '--docker_registry' option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59019/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos

Review Request 59013: Implemented passing Image::Secret Puller::pull().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59013/ --- Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till

Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59018/ --- Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till

Review Request 59014: Implemented resolving an image secret in registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59014/ --- Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till

Review Request 59016: Fixed the comment style issue in docker/spec.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59016/ --- Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till

Review Request 59017: Added support for docker spec helper 'parseAuthConfig()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59017/ --- Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till

Review Request 59011: Fixed docker/appc store 'using' format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59011/ --- Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till

Review Request 59015: Implemented passing docker config to URIs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59015/ --- Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till

Review Request 59012: Implemented passing the secret fetcher to registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59012/ --- Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till

Review Request 59010: Updated protobuf comments for Image::Secret.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59010/ --- Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till

Re: Review Request 58999: Added --secret_fetcher flag for agent.

> On May 4, 2017, 10:29 p.m., Jie Yu wrote: > > src/slave/containerizer/containerizer.hpp > > Lines 66 (patched) > > > > > > Why optional? > > Kapil Arya wrote: > That way we don't have to update the existing

Re: Review Request 58999: Added --secret_fetcher flag for agent.

> On May 4, 2017, 6:29 p.m., Jie Yu wrote: > > src/slave/containerizer/containerizer.hpp > > Lines 66 (patched) > > > > > > Why optional? That way we don't have to update the existing unit tests involving

Re: Review Request 58967: Set the working directory to parent task's for DEBUG containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58967/#review173971 --- Ship it! Ship It! - Jie Yu On May 3, 2017, 4:46 p.m.,

Re: Review Request 59000: Added environment secret isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59000/#review173970 --- src/slave/containerizer/mesos/isolators/environment_secret.cpp

Re: Review Request 58999: Added --secret_fetcher flag for agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58999/#review173969 --- src/slave/containerizer/containerizer.hpp Lines 66 (patched)

Re: Review Request 58760: Added default secret fetcher module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58760/#review173967 --- src/Makefile.am Lines 934 (patched)

Re: Review Request 58759: Introduced SecretFetcher module interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58759/#review173966 --- include/mesos/module/secretfetcher.hpp Lines 17 (patched)

Re: Review Request 58137: CLI: Added 'mesos config show' command to display the config file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58137/ --- (Updated May 4, 2017, 9:39 p.m.) Review request for mesos, Joseph Wu and Kevin

Re: Review Request 52064: Support for multiple versions of docs.

> On Dec. 23, 2016, 5:38 p.m., haosdent huang wrote: > > Sorry for the long delay on this, I've finally carved up some time to try and close this out. I've left some comments below, and am working on addressing the issues, I will update the review tomorrow with the final result, hopefully

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/ --- (Updated May 4, 2017, 9:26 p.m.) Review request for mesos, haosdent huang and

Review Request 59001: Added volume secret isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59001/ --- Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. Bugs:

Review Request 59000: Added environment secret isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59000/ --- Review request for mesos, Gilbert Song, Greg Mann, Jie Yu, and Vinod Kone.

Review Request 58999: Added --secret_fetcher flag for agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58999/ --- Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. Repository:

Re: Review Request 58759: Introduced SecretFetcher module interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58759/ --- (Updated May 4, 2017, 4:06 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 58760: Added default secret fetcher module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58760/ --- (Updated May 4, 2017, 4:06 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review173951 --- Patch looks great! Reviews applied: [58719, 58720] Passed

Review Request 58998: Fixed extra newline in webui for re-registered frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58998/ --- Review request for mesos and haosdent huang. Repository: mesos Description

Re: Review Request 58987: Add failure print when socket recv data.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58987/#review173934 --- Patch looks great! Reviews applied: [58987] Passed command:

Re: Review Request 58942: CHANGELOG for 1.3.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58942/#review173914 --- Patch looks great! Reviews applied: [58942] Passed command:

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/ --- (Updated May 4, 2017, 3:52 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 58941: Exposed full unreserved resources in /state endpoint on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58941/#review173911 --- Ship it! Ship It! - Jie Yu On May 2, 2017, 11:33 p.m.,

Re: Review Request 58940: Exposed full unreserved resources in /slaves endpoint on master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58940/#review173910 --- Ship it! Ship It! - Jie Yu On May 2, 2017, 11:32 p.m.,

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/#review173903 --- Patch looks great! Reviews applied: [58977, 58928, 58224]

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/ --- (Updated May 4, 2017, 1:59 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 58980: Passed '--default_container_info' to the command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58980/#review173894 --- Patch looks great! Reviews applied: [58980] Passed command:

Re: Review Request 58939: Filesystem isolation check for Mesos image provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58939/#review173890 --- Patch looks great! Reviews applied: [58939] Passed command:

Review Request 58987: Add failure print when socket recv data.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58987/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos

Re: Review Request 58974: Fixed flakiness in HierarchicalAllocatorTest.NestedRoleQuota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58974/#review173883 --- Patch looks great! Reviews applied: [58974] Passed command:

Re: Review Request 58967: Set the working directory to parent task's for DEBUG containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58967/#review173875 --- Patch looks great! Reviews applied: [58847, 58262, 58718, 58817,