Re: Review Request 58720: CLI: Extended the unit test infrastructure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review174111 --- Patch looks great! Reviews applied: [58719, 58720] Passed

Re: Review Request 58923: Added new ContainerLaunchInfo task_environment.

> On May 4, 2017, 2:04 a.m., Adam B wrote: > > The terminology in this area of the code confuses me. Do we have a glossary > > for the different executors, command tasks, etc. somewhere? That is confusing indeed - will add this particular point to a JIRA touching this area.

Re: Review Request 58923: Added new ContainerLaunchInfo task_environment.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58923/ --- (Updated May 6, 2017, 2:46 a.m.) Review request for mesos, Adam B, Gilbert

Re: Review Request 58999: Added --secret_resolver flag to agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58999/ --- (Updated May 5, 2017, 9:26 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 59001: Added volume secret isolator.

> On May 5, 2017, 2:34 p.m., Chun-Hung Hsiao wrote: > > src/slave/containerizer/mesos/containerizer.cpp > > Lines 228 (patched) > > > > > > This might violate the assumption that there is only one filesystem > >

Re: Review Request 59001: Added volume secret isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59001/ --- (Updated May 5, 2017, 8:53 p.m.) Review request for mesos, Gilbert Song, Jie

Review Request 59038: Fixed flakiness in HierarchicalAllocatorTest.NestedRoleDRF.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59038/ --- Review request for mesos, Anindya Sinha and Michael Park. Bugs: MESOS-7462

Re: Review Request 59000: Added environment secret isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59000/ --- (Updated May 5, 2017, 8:33 p.m.) Review request for mesos, Gilbert Song, Greg

Re: Review Request 58999: Added --secret_resolver flag to agent.

> On May 4, 2017, 6:29 p.m., Jie Yu wrote: > > src/slave/containerizer/containerizer.hpp > > Lines 66 (patched) > > > > > > Why optional? > > Kapil Arya wrote: > That way we don't have to update the existing

Re: Review Request 58760: Added default secret resolver module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58760/ --- (Updated May 5, 2017, 8:32 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 58759: Introduced SecretResolver module interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58759/ --- (Updated May 5, 2017, 8:31 p.m.) Review request for mesos, Gilbert Song, Jie

Review Request 59037: Fixed a typo that detects if the platform is linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59037/ --- Review request for mesos, Gilbert Song and Jie Yu. Repository: mesos

Re: Review Request 58939: Filesystem isolation check for Mesos image provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58939/#review174106 --- src/slave/containerizer/mesos/containerizer.cpp Lines 1162-1172

Re: Review Request 59012: Implemented passing the secret fetcher to registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59012/#review174103 --- Should we use a shared pointer for `SecretResolver` instead of

Re: Review Request 58942: CHANGELOG for 1.3.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58942/#review174102 --- Ship it! Ship It! - Neil Conway On May 5, 2017, 11:27 p.m.,

Re: Review Request 58892: Added C++11 scoped enumeration to style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58892/#review174101 --- Ship it! Ship It! - Michael Park On May 2, 2017, 3:11 p.m.,

Re: Review Request 58942: CHANGELOG for 1.3.0 release.

> On May 3, 2017, 8:35 p.m., Adam B wrote: > > CHANGELOG > > Lines 95 (patched) > > > > > > I bet we can graduate a few more of these. Maybe not the ones that > > still have "Unresolved Critical Issues", but some of

Re: Review Request 58942: CHANGELOG for 1.3.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58942/ --- (Updated May 5, 2017, 4:27 p.m.) Review request for mesos and Neil Conway.

Re: Review Request 58942: CHANGELOG for 1.3.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58942/ --- (Updated May 5, 2017, 4:20 p.m.) Review request for mesos and Neil Conway.

Re: Review Request 58942: CHANGELOG for 1.3.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58942/ --- (Updated May 5, 2017, 4:15 p.m.) Review request for mesos and Neil Conway.

Re: Review Request 59012: Implemented passing the secret fetcher to registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59012/ --- (Updated May 5, 2017, 4:16 p.m.) Review request for mesos, Adam B, Chun-Hung

Re: Review Request 58942: CHANGELOG for 1.3.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58942/ --- (Updated May 5, 2017, 3:42 p.m.) Review request for mesos and Neil Conway.

Re: Review Request 58725: Fetching docker image manifests with 'Accept' header.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58725/#review174087 --- Ship it! Ship It! - Jie Yu On May 1, 2017, 5:24 p.m.,

Re: Review Request 59017: Added support for docker spec helper 'parseAuthConfig()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59017/#review174083 --- Fix it, then Ship it! include/mesos/docker/spec.hpp Line 76

Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59018/#review174075 --- src/uri/fetchers/docker.cpp Lines 693 (patched)

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/ --- (Updated May 5, 2017, 9:23 p.m.) Review request for mesos, haosdent huang and

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/ --- (Updated May 5, 2017, 9:20 p.m.) Review request for mesos, haosdent huang and

Re: Review Request 52064: Support for multiple versions of docs.

> On Dec. 23, 2016, 5:38 p.m., haosdent huang wrote: > > site/Rakefile > > Lines 122 (patched) > > > > > > Replace all `\/latest\/` looks a bit dangerous. Do you have an example > > for this? > > Tim Anderegg

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/ --- (Updated May 5, 2017, 9:16 p.m.) Review request for mesos, haosdent huang and

Re: Review Request 59016: Fixed the comment style issue in docker/spec.hpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59016/#review174073 --- Ship it! Ship It! - Chun-Hung Hsiao On May 4, 2017, 11:22

Re: Review Request 59014: Implemented resolving an image secret in registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59014/ --- (Updated May 5, 2017, 1:30 p.m.) Review request for mesos, Adam B, Chun-Hung

Re: Review Request 59012: Implemented passing the secret fetcher to registry puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59012/ --- (Updated May 5, 2017, 1:30 p.m.) Review request for mesos, Adam B, Chun-Hung

Re: Review Request 59010: Updated protobuf comments for Image::Secret.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59010/ --- (Updated May 5, 2017, 1:30 p.m.) Review request for mesos, Adam B, Chun-Hung

Review Request 59029: Added a script to publish JARs to maven snapshot repository.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59029/ --- Review request for mesos, Anand Mazumdar and Kapil Arya. Repository: mesos

Re: Review Request 58942: CHANGELOG for 1.3.0 release.

> On May 3, 2017, 4:48 a.m., Stephan Erb wrote: > > CHANGELOG > > Lines 117 (patched) > > > > > > I was once confused by this "All issues" title in presence of the > > "Unresolved Critical Issues". > > > >

Re: Review Request 58942: CHANGELOG for 1.3.0 release.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58942/ --- (Updated May 5, 2017, 12:51 p.m.) Review request for mesos and Neil Conway.

Re: Review Request 59001: Added volume secret isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59001/#review174051 --- src/slave/containerizer/mesos/containerizer.cpp Lines 228

Re: Review Request 58939: Filesystem isolation check for Mesos image provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58939/ --- (Updated May 5, 2017, 6:07 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 59019: Updated the documentation for '--docker_registry' option.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59019/#review174058 --- Patch looks great! Reviews applied: [59019] Passed command:

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/ --- (Updated May 5, 2017, 5:02 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 58999: Added --secret_resolver flag to agent.

> On May 4, 2017, 6:29 p.m., Jie Yu wrote: > > src/slave/containerizer/containerizer.hpp > > Lines 66 (patched) > > > > > > Why optional? > > Kapil Arya wrote: > That way we don't have to update the existing

Re: Review Request 58999: Added --secret_resolver flag to agent.

> On May 4, 2017, 10:29 p.m., Jie Yu wrote: > > src/slave/containerizer/containerizer.hpp > > Lines 66 (patched) > > > > > > Why optional? > > Kapil Arya wrote: > That way we don't have to update the existing

Re: Review Request 58999: Added --secret_resolver flag to agent.

> On May 4, 2017, 10:29 p.m., Jie Yu wrote: > > src/slave/containerizer/containerizer.hpp > > Lines 66 (patched) > > > > > > Why optional? > > Kapil Arya wrote: > That way we don't have to update the existing

Re: Review Request 59011: Fixed docker/appc store 'using' format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59011/#review174028 --- Ship it! Ship It! - Chun-Hung Hsiao On May 4, 2017, 11:22

Re: Review Request 59010: Updated protobuf comments for Image::Secret.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59010/#review174027 --- Fix it, then Ship it! include/mesos/mesos.proto Line 2140

Re: Review Request 58974: Fixed flakiness in HierarchicalAllocatorTest.NestedRoleQuota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58974/#review174020 --- Ship it! Ship It! - Alexander Rukletsov On May 3, 2017,

Re: Review Request 59001: Added volume secret isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59001/ --- (Updated May 5, 2017, 6:44 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 59000: Added environment secret isolator.

> On May 4, 2017, 6:32 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/environment_secret.cpp > > Lines 37-44 (patched) > > > > > > Why you need this? Can you make sure to avoid such small nits while

Re: Review Request 59000: Added environment secret isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59000/ --- (Updated May 5, 2017, 6:43 a.m.) Review request for mesos, Gilbert Song, Greg

Re: Review Request 58999: Added --secret_resolver flag to agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58999/ --- (Updated May 5, 2017, 6:41 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 58760: Added default secret resolver module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58760/ --- (Updated May 5, 2017, 6:38 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 58759: Introduced SecretResolver module interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58759/ --- (Updated May 5, 2017, 6:37 a.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 58999: Added --secret_fetcher flag for agent.

> On May 4, 2017, 6:29 p.m., Jie Yu wrote: > > src/slave/containerizer/containerizer.hpp > > Lines 66 (patched) > > > > > > Why optional? > > Kapil Arya wrote: > That way we don't have to update the existing