Re: Review Request 60070: Adjusted the agent to the new resources format [11/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60070/#review178348 --- src/slave/paths.cpp Lines 478-481 (original), 479-482 (patched) <

Re: Review Request 60069: Adjusted the master to the new resources format [10/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60069/#review178347 --- src/master/master.cpp Line 3613 (original), 3638 (patched)

Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.

> On May 9, 2017, 8:54 p.m., Benjamin Mahler wrote: > > Before you commit this, it would be great if you could test this (I can't > > tell how you tested this from the testing done section), e.g.: > > > > * Clicking on a link from the top level task page (state should already be > > loaded) >

Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.

> On May 9, 2017, 8:54 p.m., Benjamin Mahler wrote: > > src/webui/master/static/js/controllers.js > > Lines 1016-1017 (patched) > > > > > > I'm a bit confused as to why we would want to set up the listener if we >

Re: Review Request 60071: Adjusted test utilities to the resource format [17/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60071/ --- (Updated June 19, 2017, 10:48 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 60070: Adjusted the agent to the new resources format [11/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60070/ --- (Updated June 19, 2017, 10:42 p.m.) Review request for mesos and Neil Conway.

Re: Review Request 60072: Adjusted tests to the new resource format [19/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60072/ --- (Updated June 19, 2017, 10:36 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 60138: Tweaked a parameter to pass by const ref instead of value.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60138/#review178336 --- Ship it! Ship It! - Gastón Kleiman On June 15, 2017, 11:14 p

Re: Review Request 60074: Updated authorization tests [20/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60074/ --- (Updated June 19, 2017, 10:36 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 60073: Added `RESERVATION_REFINEMENT` capability to tests [18/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60073/ --- (Updated June 19, 2017, 10:35 p.m.) Review request for mesos, Neil Conway and V

Re: Review Request 60071: Adjusted test utilities to the resource format [17/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60071/ --- (Updated June 19, 2017, 10:35 p.m.) Review request for mesos and Vinod Kone.

Review Request 60223: Removed `modelProtobufJSON` and replaced with `JSON::Protobuf` [16/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60223/ --- Review request for mesos. Repository: mesos Description --- Removed `mod

Re: Review Request 60207: Changed the semantics of `JSON::protobuf` for deprecated fields [14/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60207/ --- (Updated June 19, 2017, 10:34 p.m.) Review request for mesos, Neil Conway and V

Re: Review Request 60190: Added the agent `RESERVATION_REFINEMENT` capability [13/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60190/ --- (Updated June 19, 2017, 10:34 p.m.) Review request for mesos, Benjamin Mahler a

Review Request 60222: Marked `Resource.role` as deprecated [15/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60222/ --- Review request for mesos and Neil Conway. Repository: mesos Description -

Re: Review Request 60040: Resources: Adjusted `parse` to produce new resource format [6/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60040/ --- (Updated June 19, 2017, 10:33 p.m.) Review request for mesos, Benjamin Mahler a

Re: Review Request 60016: Resources: Adjusted the comparators to new resource format [3/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60016/ --- (Updated June 19, 2017, 10:33 p.m.) Review request for mesos, Benjamin Mahler a

Re: Review Request 60015: Introduced a utility function `Resources::reservationRole` [7/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60015/ --- (Updated June 19, 2017, 10:33 p.m.) Review request for mesos, Benjamin Mahler a

Re: Review Request 60070: Adjusted the agent to the new resources format [11/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60070/ --- (Updated June 19, 2017, 10:33 p.m.) Review request for mesos and Neil Conway.

Re: Review Request 60069: Adjusted the master to the new resources format [10/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60069/ --- (Updated June 19, 2017, 10:33 p.m.) Review request for mesos and Neil Conway.

Re: Review Request 60068: Adjusted the authorizer to the new resource format [12/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60068/ --- (Updated June 19, 2017, 10:33 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 60021: Adjusted (UN)RESERVE operations to handle reservation refinement [8/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60021/ --- (Updated June 19, 2017, 10:33 p.m.) Review request for mesos and Benjamin Mahle

Re: Review Request 60182: Resources: Adjusted the predicates to the new resource format [2/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60182/ --- (Updated June 19, 2017, 10:32 p.m.) Review request for mesos and Neil Conway.

Re: Review Request 60185: Adjusted the master validation to the new resource format [9/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60185/ --- (Updated June 19, 2017, 10:33 p.m.) Review request for mesos and Neil Conway.

Re: Review Request 60017: Resources: Adjusted the utilities to the new resource format [5/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60017/ --- (Updated June 19, 2017, 10:33 p.m.) Review request for mesos, Benjamin Mahler a

Re: Review Request 60184: Resources: Adjusted `operator<<` to the new resource format [4/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60184/ --- (Updated June 19, 2017, 10:33 p.m.) Review request for mesos and Neil Conway.

Re: Review Request 60181: Resources: Updated the comment to mention the resource format [1/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60181/ --- (Updated June 19, 2017, 10:32 p.m.) Review request for mesos and Neil Conway.

Re: Review Request 53517: Added test case for cgroup namespace isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53517/ --- (Updated June 20, 2017, 4:17 a.m.) Review request for mesos, Jason Lai, Jie Yu,

Re: Review Request 54105: Added `CgroupNamespaceFilter`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54105/ --- (Updated June 20, 2017, 4:17 a.m.) Review request for mesos, Jason Lai, Jie Yu,

Re: Review Request 60218: Added a couple of missing validation logic + minor improvements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60218/#review178335 --- Fix it, then Ship it! src/common/resources.cpp Lines 877 (patc

Re: Review Request 60219: Introduced `downgradeResources` to facilitate out-bound resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60219/#review178334 --- Ship it! - Neil Conway On June 20, 2017, 12:59 a.m., Michael

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/ --- (Updated June 20, 2017, 3:48 a.m.) Review request for . Bugs: MESOS-7468

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

> On May 11, 2017, 8:35 a.m., Tomasz Janiszewski wrote: > > src/webui/master/static/browse.html > > Lines 17-20 (original), 17-20 (patched) > > > > > > How about usign `` here instead of list? Then `/` will be just >

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58874/ --- (Updated June 20, 2017, 3:41 a.m.) Review request for mesos, Benjamin Mahler an

Review Request 60219: Introduced `downgradeResources` to facilitate out-bound resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60219/ --- Review request for mesos and Neil Conway. Repository: mesos Description -

Review Request 60218: Added a couple of missing validation logic + minor improvements.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60218/ --- Review request for mesos and Neil Conway. Repository: mesos Description -

Re: Review Request 60107: Add class definition for ObjectFilter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/ --- (Updated June 20, 2017, 12:30 a.m.) Review request for mesos, Anand Mazumdar, G

Review Request 60216: Fixed the commit message hook to allow `fixup` and `squash` commits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60216/ --- Review request for mesos, Benjamin Bannier, Joseph Wu, and Michael Park. Bugs:

Re: Review Request 60215: WIP: Logged offer ids of sent offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60215/ --- (Updated June 19, 2017, 11:08 p.m.) Review request for mesos, Armand Grillet, B

Review Request 60215: Logged offer ids of sent offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60215/ --- Review request for mesos, Armand Grillet, Benjamin Bannier, and Till Toenshoff.

Review Request 60214: Logged when an offer is removed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60214/ --- Review request for mesos, Armand Grillet, Benjamin Bannier, and Till Toenshoff.

Re: Review Request 60103: Changed variable name _ack to statusUpdateAck.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60103/#review178319 --- Fix it, then Ship it! src/tests/slave_recovery_tests.cpp Line

Re: Review Request 60070: Adjusted the agent to the new resources format [11/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60070/#review178316 --- src/common/resources_utils.hpp Lines 140 (patched)

Re: Review Request 59413: Fix bytes.hpp constexpr compilation failure with GCC 7.1.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59413/#review178318 --- Fix it, then Ship it! 3rdparty/stout/include/stout/bytes.hpp L

Re: Review Request 60190: Added the agent `RESERVATION_REFINEMENT` capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60190/#review178315 --- Ship it! Ship It! - Neil Conway On June 19, 2017, 6:43 a.m.,

Re: Review Request 60038: Prevented allocating reservation refinements to non-capable frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60038/ --- (Updated June 19, 2017, 2:52 p.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 60210: Disabled emitting unset fields with default values in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60210/#review178304 --- Can we add a bit more context on the motivation here? i.e., are we

Re: Review Request 60207: Added `emit_default_value` option to `JSON::protobuf`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60207/#review178303 --- I wonder if an `enum` would be clearer at call-sites than a boolea

Re: Review Request 60209: Fixed the `serialize` function to respect the protobuf format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60209/#review178300 --- I'm a bit confused on when code should be using `modelProtobufJSON

Re: Review Request 60211: Added RESERVATION_REFINEMENT capability for example frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60211/#review178298 --- Ship it! Ship It! - Neil Conway On June 19, 2017, 8:45 p.m.,

Re: Review Request 60207: Added `emit_default_value` option to `JSON::protobuf`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60207/#review178294 --- Fix it, then Ship it! Needs test coverage. 3rdparty/stout/inc

Review Request 60211: Added RESERVATION_REFINEMENT capability for example frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60211/ --- Review request for mesos and Neil Conway. Repository: mesos Description -

Review Request 60210: Disabled emitting unset fields with default values in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60210/ --- Review request for mesos, Neil Conway and Vinod Kone. Repository: mesos Descr

Review Request 60209: Fixed the `serialize` function to respect the protobuf format.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60209/ --- Review request for mesos, Neil Conway and Vinod Kone. Repository: mesos Descr

Review Request 60207: Added `emit_default_value` option to `JSON::protobuf`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60207/ --- Review request for mesos, Neil Conway and Vinod Kone. Repository: mesos Descr

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

> On May 17, 2017, 2:14 p.m., Jie Yu wrote: > > src/slave/flags.cpp > > Lines 770-786 (patched) > > > > > > This sounds like a heuristic. Any justification why this heuristic? > > Wondering if label based solution i

Review Request 60203: Introduce HTB class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60203/ --- Review request for mesos, Ilya Pronin, Jie Yu, Santhosh Kumar Shanmugham, and Co

Re: Review Request 60069: Adjusted the master to the new resources format [10/N].

> On June 15, 2017, 1:32 a.m., Neil Conway wrote: > > src/master/master.cpp > > Line 3907 (original), 3907 (patched) > > > > > > Confused why this is in the same loop as `injectAllocationInfo`; > > updating the com

Re: Review Request 59760: Added REGION_AWARE framework capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59760/ --- (Updated June 19, 2017, 5:56 p.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 59760: Added REGION_AWARE framework capability.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59760/ --- (Updated June 19, 2017, 5:51 p.m.) Review request for mesos and Vinod Kone. B

Re: Review Request 60017: Resources: Adjusted the utilities to the new resource format [5/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60017/#review178239 --- src/common/resources.cpp Line 1501 (original), 1501-1505 (patched

Re: Review Request 60184: Resources: Adjusted the `operator<<` to the new resource format [4/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60184/#review178238 --- src/common/resources.cpp Line 2221 (original), 2202 (patched)

Re: Review Request 60182: Resources: Adjusted the predicates to the new resource format [2/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60182/#review178242 --- src/v1/resources.cpp Line 1044 (original), 1053 (patched)

Re: Review Request 60016: Resources: Adjusted the comparators to new resource format [3/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60016/#review178237 --- src/common/resources.cpp Line 239 (original), 245 (patched)

Re: Review Request 60182: Resources: Adjusted the predicates to the new resource format [2/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60182/#review178234 --- include/mesos/resources.hpp Lines 266-269 (original), 266-271 (pa

Re: Review Request 60181: Resources: Updated the comment to mention the resource format [1/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60181/#review178233 --- include/mesos/resources.hpp Lines 56-63 (original), 56-63 (patche

Re: Review Request 60070: Adjusted the agent to the new resources format [11/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60070/#review178194 --- src/slave/slave.cpp Lines 1395 (patched)

Re: Review Request 60070: Adjusted the agent to the new resources format [11/N].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60070/#review178195 --- src/master/master.cpp Line 7308 (original), 7308 (patched)