Re: Review Request 59989: Added a test `ProtobufTest.JsonifyMap`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59989/ --- (Updated July 4, 2017, 10:44 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 59987: Added protobuf map support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59987/ --- (Updated July 4, 2017, 10:43 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 59988: Added a new protobuf message `MapMessage` for protobuf tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59988/ --- (Updated July 4, 2017, 10:44 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

> On July 3, 2017, 9:51 a.m., Alexander Rojas wrote: > > I think the acceptor files do not belong in the `common/http.?pp` files. > > Perhaps create a new header called acceptors? Agree, since these Acceptors contain logic about not only HTTP request but also Authorization. It's better to

Re: Review Request 60425: Added MESOS-7581 to the 1.3.1 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60425/#review179538 --- Fix it, then Ship it! Thanks! CHANGELOG Lines 14 (patched)

Re: Review Request 60427: Added MESOS-7581 to the 1.2.2 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60427/#review179539 --- Fix it, then Ship it! CHANGELOG Lines 306 (patched)

Re: Review Request 60428: Added MESOS-7581 to the 1.1.3 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60428/#review179540 --- Fix it, then Ship it! CHANGELOG Lines 801 (patched)

Re: Review Request 60580: Added filtering to the '/frameworks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60580/ --- (Updated July 3, 2017, 8:10 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 60628: Enable fetcher_tests.cpp unit test module on Windows platform.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60628/ --- Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li

Review Request 60626: Eliminate os::shell calls from HDFS for Windows compatibility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60626/ --- Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li

Review Request 60625: Normalize file separation characters on Windows when building path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60625/ --- Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li

Review Request 60624: Enable HDFS compilation and associated tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60624/ --- Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li

Review Request 60623: Convert "file://" URI handling to use new path::uri() function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60623/ --- Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li

Review Request 60622: Add new stout function: path::uri (convert filename to valid URI).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60622/ --- Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li

Review Request 60620: Modify os::write to write binary files on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60620/ --- Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and Li

Re: Review Request 60581: Added filtering to the '/slaves' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60581/ --- (Updated July 3, 2017, 7:03 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review179533 --- src/messages/flags.hpp Lines 58 (patched)

Re: Review Request 60557: Passed default container DNS info to Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60557/#review179532 --- Ship it! Ship It! - Avinash sridharan On June 30, 2017,

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- (Updated July 3, 2017, 6:35 p.m.) Review request for mesos, Jie Yu, James

Re: Review Request 60558: Set container DNS with `--default_container_dns` in Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60558/#review179530 --- src/docker/docker.hpp Lines 167 (patched)

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

> On June 27, 2017, 5:33 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js > > Lines 604 (patched) > > > > > > `ng-repeat` support map, have you try > > > > ``` > >

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60370/#review179531 --- src/webui/master/static/js/controllers.js Lines 610 (patched)

Re: Review Request 60369: Exposed allocated resources per each role in /state endpoint on agent.

> On July 3, 2017, 1:22 p.m., Benjamin Mahler wrote: > > src/slave/http.cpp > > Lines 1330-1334 (patched) > > > > > > Whoops, I should have noticed this earlier, but when going to commit > > this I was taking a

Re: Review Request 60369: Exposed allocated resources per each role in /state endpoint on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60369/ --- (Updated July 3, 2017, 5:52 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 60500: Introduced `--default_container_dns` agent flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60500/#review179520 --- docs/configuration.md Lines 1309 (patched)

Re: Review Request 60440: Updated local development workflow of mesos website.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60440/#review179519 --- Should we make `support/mesos-website/entrypoint.sh` support a

Re: Review Request 60439: Added scripts to automate website publishing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60439/#review179523 --- Really sorry for the delay. LGTM, just want to sure is it

Re: Review Request 60439: Added scripts to automate website publishing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60439/#review179518 --- support/mesos-website/entrypoint.sh Lines 32 (patched)

Re: Review Request 60439: Added scripts to automate website publishing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60439/#review179517 --- support/mesos-website/build.sh Lines 42-43 (patched)

Re: Review Request 60439: Added scripts to automate website publishing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60439/#review179515 --- support/mesos-website/entrypoint.sh Lines 32 (patched)

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- (Updated July 3, 2017, 4:18 p.m.) Review request for mesos, Jie Yu, James

Re: Review Request 60280: Provide full path to the custom executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60280/ --- (Updated July 3, 2017, 4 p.m.) Review request for mesos, Jie Yu, James Peach,

Review Request 60598: Replaced abort() with _exit() in ChildHook::SUPERVISOR from subprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60598/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, and James Peach.

Re: Review Request 60280: Provide full path to the custom executor.

> On June 30, 2017, 11:48 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 799 (patched) > > > > > > What if `launchInfo.working_directory()` is not set? Maybe use > > os::realpath here to

Review Request 60600: Set container DNS with `--default_container_dns` in CNI isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60600/ --- Review request for mesos, Avinash sridharan and Jie Yu. Bugs: MESOS-7709

Re: Review Request 60369: Exposed allocated resources per each role in /state endpoint on agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60369/#review179499 --- src/slave/http.cpp Lines 1330-1334 (patched)

Re: Review Request 60397: Check perf version compatibility in tests with disabled coredumps.

> On June 27, 2017, 5:44 a.m., Benjamin Mahler wrote: > > src/tests/environment.cpp > > Line 542 (original), 542-548 (patched) > > > > > > Shouldn't this just be covered by `perf::suppported`? > > > > Would

Re: Review Request 60397: Check perf version compatibility in tests with disabled coredumps.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60397/ --- (Updated July 3, 2017, 10:57 a.m.) Review request for mesos, Benjamin Bannier,

Review Request 60594: Add a`network/ports` isolator nested container test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60594/ --- Review request for mesos. Bugs: MESOS-7675

Review Request 60593: Test the `network/ports` isolator recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60593/ --- Review request for mesos. Bugs: MESOS-7675

Review Request 60592: Configure the `network/ports` isolator watch interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60592/ --- Review request for mesos. Bugs: MESOS-7576

Review Request 60591: Optionally isolate only the agent network ports.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60591/ --- Review request for mesos. Bugs: MESOS-7675

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179491 --- src/common/http.hpp Lines 181 (patched)

Re: Review Request 60279: Add constructor for ObjectApprover::Object.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60279/#review179490 --- Ship it! Ship It! - Alexander Rojas On June 22, 2017, 10:22

Re: Review Request 60107: Added filtering to the '/tasks' endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60107/#review179488 --- I think the acceptor files do not belong in the `common/http.?pp`