----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60440/#review179519 -----------------------------------------------------------
Should we make `support/mesos-website/entrypoint.sh` support a environment variable `MODE=dev` and then we `export MODE=dev` in `site/mesos-website-dev.sh` and just call `support/mesos-website.sh`? It would help to avoid write duplicate code in different places. site/entrypoint.sh Lines 26 (patched) <https://reviews.apache.org/r/60440/#comment254265> s/MacOSX/MacOS - haosdent huang On June 29, 2017, 9:59 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60440/ > ----------------------------------------------------------- > > (Updated June 29, 2017, 9:59 p.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, and haosdent > huang. > > > Bugs: MESOS-7625 > https://issues.apache.org/jira/browse/MESOS-7625 > > > Repository: mesos > > > Description > ------- > > Made the layout and scripts consistent with CI based automatic > publishing of the website. > > > Diffs > ----- > > site/Dockerfile 8ba0be0c28e924f7a2b89e6e5a3237deb3751a41 > site/README.md ebd3e6a0fea7ae0fe3b28719bcab28ee8f7c356c > site/build.sh 11f15e15621c4d3db1472e88911787b9b3100f97 > site/entrypoint.sh PRE-CREATION > site/mesos-website-dev.sh PRE-CREATION > > > Diff: https://reviews.apache.org/r/60440/diff/1/ > > > Testing > ------- > > Tested by running the script locally. > > > Thanks, > > Vinod Kone > >
