Re: Review Request 61154: Added safe downcasts for Socket.

2017-07-29 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61154/#review181769 --- Fix it, then Ship it! Not sure I like the call-site code that

Re: Review Request 61153: Added discard happens-before relationship in process::await/collect.

2017-07-29 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61153/#review181768 --- Ship it! Ship It! - Benjamin Mahler On July 27, 2017, 1:55

Re: Review Request 61152: Added overload of process::await that takes and returns single future.

2017-07-29 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61152/#review181767 --- Ship it! - Benjamin Mahler On July 27, 2017, 1:55 a.m.,

Re: Review Request 61150: Added Future::onAbandoned semantics to process::collect/await.

2017-07-29 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61150/#review181765 --- Fix it, then Ship it! I'm hoping we can update abandonment to

Re: Review Request 61148: Added Future::recover.

2017-07-29 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61148/#review181763 --- Fix it, then Ship it!

Re: Review Request 61151: Used Future::recover in Mesos.

2017-07-29 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61151/#review181764 --- src/slave/containerizer/mesos/io/switchboard.cpp Line 1646

Re: Review Request 61147: Added Future::onAbandoned and Future::isAbandoned.

2017-07-29 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61147/#review181762 --- Fix it, then Ship it!

Re: Review Request 61069: Introduced an optimized fixed size last-in-first-out semaphore.

2017-07-29 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61069/#review181751 --- Fix it, then Ship it! Looks good, I wasn't able to find any

Re: Review Request 61060: Cached a reference to a ProcessBase in every UPID.

2017-07-29 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61060/#review181761 --- Ship it! Some TODOs with thoughts on the longer term plan here

Re: Review Request 61067: More optimizations for creating a MessageEvent.

2017-07-29 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61067/#review181760 --- Ship it! Ship It! - Benjamin Mahler On July 24, 2017, 1:49

Re: Review Request 61058: Added a lock-free event queue.

2017-07-29 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61058/#review181758 --- Fix it, then Ship it! 3rdparty/libprocess/configure.ac Lines

Re: Review Request 60934: Implemented blkio subsystem usage() for resource statistics.

2017-07-29 Thread Gilbert Song
> On July 28, 2017, 10:27 a.m., James Peach wrote: > > I don't see any tests for this? Tests will be included in my followup patches. - Gilbert --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 60934: Implemented blkio subsystem usage() for resource statistics.

2017-07-29 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60934/ --- (Updated July 29, 2017, 5 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 60933: Added stats/control helpers for the Blkio cgroup subsystem.

2017-07-29 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60933/ --- (Updated July 29, 2017, 4:59 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 60932: Added protobuf scheme for blkio subsystem in CgroupInfo.

2017-07-29 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/ --- (Updated July 29, 2017, 4:58 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 61058: Added a lock-free event queue.

2017-07-29 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61058/ --- (Updated July 29, 2017, 8:52 p.m.) Review request for mesos and Benjamin

Re: Review Request 61058: Added a lock-free event queue.

2017-07-29 Thread Benjamin Hindman
> On July 26, 2017, 2:08 a.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/event_queue.hpp > > Lines 127-136 (patched) > > > > > > Hm.. if a thread is checking `empty()` after the sequence is > > incremented

Re: Review Request 61172: Added mesos.http and mesos.exceptions for CLI.

2017-07-29 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61172/#review181756 --- In _testing done_, there seems to be a missing first part asking

Re: Review Request 60900: Updated Python linter to work with multiple directories.

2017-07-29 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60900/ --- (Updated July 29, 2017, 2:15 p.m.) Review request for mesos, Eric Chung and

Re: Review Request 60235: Linted support/test-upgrade.py.

2017-07-29 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60235/ --- (Updated July 29, 2017, 9:03 a.m.) Review request for mesos, Benjamin Bannier