Re: Review Request 62230: Avoid GC pruning events from blocking other processes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62230/#review185263 --- FAIL: Some Mesos tests failed. Reviews applied: `['62252',

Re: Review Request 62263: Add test to browse and read in sandbox virtual path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62263/#review185262 --- FAIL: Some Mesos tests failed. Reviews applied: `['62040',

Re: Review Request 62252: Added `process::Executor::execute()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62252/#review185261 --- Thanks for taking this on Chun! A few high level comments to

Re: Review Request 62237: Fixed a memory leak in composing containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62237/#review185260 --- Ship it! Ship It! - Jie Yu On Sept. 12, 2017, 7:27 a.m.,

Re: Review Request 62246: Added workaround for a docker bug in docker build helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62246/#review185259 --- FAIL: Some Mesos tests failed. Reviews applied: `['62246']`

Review Request 62263: Add test to browse and read in sandbox virtual path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62263/ --- Review request for mesos, Benjamin Mahler and Jason Lai. Bugs: MESOS-7899

Re: Review Request 62047: Allowed look up latest executor directory by virtual path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62047/ --- (Updated Sept. 13, 2017, 1:25 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 62254: Ignored /proc/self/ns/pid_for_children when listing namespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62254/#review185251 --- FAIL: Some Mesos tests failed. Reviews applied: `['62253',

Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58048/#review185248 --- src/common/resources.cpp Lines 185 (patched)

Re: Review Request 52064: Support for multiple versions of docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52064/#review185249 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 62197: Added new overloads for the `createExecutorInfo` test helper method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62197/ --- (Updated Sept. 12, 2017, 11:49 p.m.) Review request for mesos, Benjamin

Re: Review Request 62197: Added new overloads for the `createExecutorInfo` test helper method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62197/#review185243 --- Fix it, then Ship it! src/tests/mesos.hpp Lines 590 (patched)

Re: Review Request 62253: Ignored cgroups v2 hierarchy when parsing /proc/self/cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62253/#review185239 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 12, 2017,

Re: Review Request 62254: Ignored /proc/self/ns/pid_for_children when listing namespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62254/#review185238 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 12, 2017,

Re: Review Request 62230: Avoid GC pruning events from blocking other processes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62230/ --- (Updated Sept. 12, 2017, 8:52 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 62252: Added `process::Executor::execute()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62252/ --- (Updated Sept. 12, 2017, 8:12 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 62197: Added new overloads for the `createExecutorInfo` test helper method.

> On Sept. 12, 2017, 5:21 p.m., Greg Mann wrote: > > src/tests/mesos.hpp > > Lines 512-522 (original), 620-638 (patched) > > > > > > I'm not sure why this overload was added originally, since `const > > char*` is

Re: Review Request 62197: Added new overloads for the `createExecutorInfo` test helper method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62197/ --- (Updated Sept. 12, 2017, 7:47 p.m.) Review request for mesos, Benjamin

Re: Review Request 52064: Support for multiple versions of docs.

Great. I'll be there too! On Tue, Sep 12, 2017 at 11:59 AM, Tim Anderegg wrote: > > > > On May 9, 2017, 4:30 p.m., haosdent huang wrote: > > > Hi, @tim Thanks a lot for your update. I am still reading you patch > and have not finished. Could return my comments if it

Re: Review Request 52064: Support for multiple versions of docs.

> On May 9, 2017, 4:30 p.m., haosdent huang wrote: > > Hi, @tim Thanks a lot for your update. I am still reading you patch and > > have not finished. Could return my comments if it works at my side. Thanks > > a lot for your contributions. > > Tim Anderegg wrote: > Thanks @haosdent,

Re: Review Request 61982: Cleaned up DefaultExecutor tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61982/#review185221 --- Ship it! - Greg Mann On Sept. 9, 2017, 12:03 a.m., Gastón

Review Request 62253: Ignored cgroups v2 hierarchy when parsing /proc/self/cgroups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62253/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-7969

Review Request 62254: Ignored /proc/self/ns/pid_for_children when listing namespaces.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62254/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-7968

Re: Review Request 52064: Support for multiple versions of docs.

> On May 9, 2017, 4:30 p.m., haosdent huang wrote: > > Hi, @tim Thanks a lot for your update. I am still reading you patch and > > have not finished. Could return my comments if it works at my side. Thanks > > a lot for your contributions. > > Tim Anderegg wrote: > Thanks @haosdent,

Review Request 62252: Added `process::Executor::execute()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62252/ --- Review request for mesos, Benjamin Hindman and Benjamin Mahler. Bugs:

Re: Review Request 62197: Added new overloads for the `createExecutorInfo` test helper method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62197/#review185216 --- src/tests/mesos.hpp Lines 512-522 (original), 620-638 (patched)

Re: Review Request 62246: Added workaround for a docker bug in docker build helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62246/#review185202 --- Bad review! Error: No reviewers specified. Please find a

Review Request 62246: Added workaround for a docker bug in docker build helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62246/ --- Review request for mesos. Repository: mesos Description --- This patch

Re: Review Request 62241: Added SchedulerHttpApiTest.UpdateHttpToPidSchedulerAndBack test.

> On Sept. 12, 2017, 3:16 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Mesos failed to build. > > > > Reviews applied: [62240, 62241] > > > > All the build artifacts available at: > > http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62241 > > > > Relevant logs: > > > > -

Re: Review Request 62241: Added SchedulerHttpApiTest.UpdateHttpToPidSchedulerAndBack test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62241/#review185183 --- FAIL: Mesos failed to build. Reviews applied: [62240, 62241]

Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62213/#review185182 --- FAIL: Mesos failed to build. Reviews applied: [62212, 62213]

Re: Review Request 62230: Avoid GC pruning events from blocking other processes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62230/#review185181 --- FAIL: Mesos failed to build. Reviews applied: [62230] All the

Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'.

> On Sept. 6, 2017, 7:15 p.m., Jie Yu wrote: > > include/mesos/mesos.proto > > Lines 1044 (patched) > > > > > > Also, I'd suggest we put `id` into `source`. Given that the CSI spec > > change, we'll use string for

Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'.

> On April 17, 2017, 11:49 a.m., Jie Yu wrote: > > src/tests/resources_tests.cpp > > Lines 2255 (patched) > > > > > > instead of relying on 'count', let's use `size()` instead. > > Qian Zhang wrote: > I think

Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'.

> On Sept. 2, 2017, 6:27 p.m., Jie Yu wrote: > > This might need to be adjusted based on this: > > https://github.com/container-storage-interface/spec/pull/97 > > > > so `id` should be string, and `metadata` is labels given the above PR goes > > through Like you suggested below, I moved `id`

Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'.

> On Aug. 28, 2017, 8:24 p.m., Jie Yu wrote: > > src/common/resources.cpp > > Line 187 (original), 187 (patched) > > > > > > We also need to update `addable` and `subtractable` similar to what we > > did for

Re: Review Request 58048: Added 'id' and 'metadata' fields to 'Resource.DiskInfo.Source'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58048/ --- (Updated Sept. 12, 2017, 3:14 p.m.) Review request for mesos, Jie Yu and Jan

Review Request 62241: Added SchedulerHttpApiTest.UpdateHttpToPidSchedulerAndBack test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62241/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-7867

Review Request 62240: Removed metrics removal from Master::failoverFramework().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62240/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-7867

Re: Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2]

> On Sept. 12, 2017, 11:07 a.m., Alexander Rukletsov wrote: > > src/launcher/default_executor.cpp > > Lines 1317-1319 (original), 1333-1337 (patched) > > > > > > Instead of checking a flag, why not replacing

Re: Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2]

> On Sept. 12, 2017, 11:03 a.m., Andrei Budnik wrote: > > src/docker/executor.cpp > > Lines 141 (patched) > > > > > > Do we really need to send `TASK_STARTING`, if we know that right after > > sending

Re: Review Request 62018: Updated logging::initialize to make flags optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62018/ --- (Updated Sept. 12, 2017, 11:33 a.m.) Review request for mesos, Andrei Budnik

Re: Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2]

> On Sept. 12, 2017, 11:03 a.m., Andrei Budnik wrote: > > src/docker/executor.cpp > > Lines 141 (patched) > > > > > > Do we really need to send `TASK_STARTING`, if we know that right after > > sending

Re: Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62212/#review185157 --- For the default executor, a cleaner approach would be to

Re: Review Request 62212: Send TASK_STARTING from the built-in executors. [1/2]

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62212/#review185156 --- src/docker/executor.cpp Lines 141 (patched)

Re: Review Request 62237: Fixed a memory leak in composing containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62237/#review185155 --- FAIL: Mesos stdout-tests failed to build. Reviews applied:

Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62213/ --- (Updated Sept. 12, 2017, 9:58 a.m.) Review request for mesos, Andrei Budnik

Re: Review Request 62047: Allowed look up latest executor directory by virtual path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62047/#review185153 --- FAIL: Some Mesos tests failed. Reviews applied: [62040, 62174,

Re: Review Request 62018: Updated logging::initialize to make flags optional.

> On Sept. 4, 2017, 1:39 p.m., Alexander Rukletsov wrote: > > src/logging/logging.cpp > > Lines 135-139 (patched) > > > > > > This approach changes defaults for clients, who start calling > >

Re: Review Request 60495: Added network ports isolator listen socket utilities.

> On Sept. 8, 2017, 3:43 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Line 112 (original), 112 (patched) > > > > > > Why do we need a `for` loop like this? I think

Review Request 62237: Fixed a memory leak in composing containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62237/ --- Review request for mesos, Anand Mazumdar and Jie Yu. Bugs: MESOS-7927