Re: Review Request 63312: Updated Resources::apply for new operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63312/#review189267 --- Bad patch! Reviews applied: [63312, 63105, 61946, 61810, 63104,

Re: Review Request 63293: Update google-glog to 0.3.5.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63293/#review189264 --- Is there a pressing need to update this _right now_? As it is, we

Re: Review Request 63311: Fixed Flag Tests review issues.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63311/#review189263 --- This needs to be squashed into the original review (one review

Re: Review Request 63310: Fixed Path Tests review issues.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63310/#review189262 --- This needs to be squashed into the original review (one review

Re: Review Request 63253: Fixed DefaultExecutorTest for proper URI handling on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63253/ --- (Updated Oct. 25, 2017, 11:19 p.m.) Review request for mesos, Andrew

Re: Review Request 63253: Fixed DefaultExecutorTest for proper URI handling on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63253/#review189257 --- src/tests/default_executor_tests.cpp Lines 1652-1653 (patched)

Re: Review Request 63253: Fixed DefaultExecutorTest for proper URI handling on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63253/#review189257 --- src/tests/default_executor_tests.cpp Lines 1652-1653 (patched)

Re: Review Request 63253: Fixed DefaultExecutorTest for proper URI handling on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63253/ --- (Updated Oct. 25, 2017, 10:17 p.m.) Review request for mesos, Andrew

Re: Review Request 63253: Fixed DefaultExecutorTest for proper URI handling on Windows.

> On Oct. 25, 2017, 10:07 p.m., Gaston Kleiman wrote: > > src/tests/default_executor_tests.cpp > > Lines 1657 (patched) > > > > > > Nit: do we need this the whitespace after the opening quotes? There used to be a

Re: Review Request 63253: Fixed DefaultExecutorTest for proper URI handling on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63253/#review189252 --- Fix it, then Ship it! src/tests/default_executor_tests.cpp

Review Request 63315: Allowe override of parallel jobs in docker build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63315/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos

Re: Review Request 63253: Fixed DefaultExecutorTest for proper URI handling on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63253/#review189251 --- PASS: Mesos patch 63253 was successfully built and tested.

Review Request 63314: Add support for Ubuntu 16.04 in docker build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63314/ --- Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos

Re: Review Request 63212: Added a findByTarget method for fs::MountInfoTable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63212/#review189120 --- src/linux/fs.hpp Lines 276 (patched)

Re: Review Request 63211: Moved the logic of setting '/' as rslave into the launch helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63211/#review189101 --- src/slave/containerizer/mesos/launch.cpp Lines 247 (patched)

Review Request 63312: Updated Resources::apply for new operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63312/ --- Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, and Jan

Re: Review Request 63200: Added ContainerMountInfo to avoid pre_exec_commands for mounts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63200/ --- (Updated Oct. 25, 2017, 9:15 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 63200: Added ContainerMountInfo to avoid pre_exec_commands for mounts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63200/ --- (Updated Oct. 25, 2017, 9:13 p.m.) Review request for mesos, Gilbert Song,

Review Request 63311: Fixed Flag Tests review issues.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63311/ --- Review request for mesos and Andrew Schwartzmeyer. Bugs: MESOS-3437

Review Request 63310: Fixed Path Tests review issues.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63310/ --- Review request for mesos and Andrew Schwartzmeyer. Bugs: MESOS-3442

Re: Review Request 63304: Removed Flag Tests TODO comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63304/#review189248 --- This review request should squashed into 63239 (as in, amend the

Re: Review Request 63304: Removed Flag Tests TODO comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63304/ --- (Updated Oct. 25, 2017, 8:35 p.m.) Review request for mesos and Andrew

Re: Review Request 63253: Fixed DefaultExecutorTest for proper URI handling on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63253/ --- (Updated Oct. 25, 2017, 7:59 p.m.) Review request for mesos, Andrew

Re: Review Request 63253: Fixed DefaultExecutorTest for proper URI handling on Windows.

> On Oct. 25, 2017, 4:38 p.m., Gaston Kleiman wrote: > > src/tests/default_executor_tests.cpp > > Lines 1650 (patched) > > > > > > This should be: > > > > `" if ((Get-Content testFile) -NotMatch 'pizza')"`

Re: Review Request 63253: Fixed DefaultExecutorTest for proper URI handling on Windows.

> On Oct. 25, 2017, 3:58 p.m., Gaston Kleiman wrote: > > src/tests/default_executor_tests.cpp > > Lines 1764 (patched) > > > > > > The indentation here looks strange. This was removed since it's specific to Linux

Re: Review Request 63253: Fixed DefaultExecutorTest for proper URI handling on Windows.

> On Oct. 25, 2017, 5:25 p.m., Andrew Schwartzmeyer wrote: > > src/tests/default_executor_tests.cpp > > Line 1766 (original), 1772 (patched) > > > > > > Is it just me or did this indentation change? I don't see

Re: Review Request 63304: Removed Flag Tests TODO comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63304/#review189239 --- FAIL: Failed to apply the current review. Failed command:

Review Request 63304: Removed Flag Tests TODO comments.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63304/ --- Review request for mesos and Andrew Schwartzmeyer. Bugs: MESOS-3437

Re: Review Request 63280: Made the containerizer launch be explicit about O_CLOEXEC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63280/#review189232 --- PASS: Mesos patch 63280 was successfully built and tested.

Re: Review Request 63294: Update glog patch (config.guess) to support ARM.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63294/#review189217 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 63253: Fixed DefaultExecutorTest for proper URI handling on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63253/#review189210 --- src/tests/default_executor_tests.cpp Lines 1764 (patched)

Re: Review Request 63238: Ported and enabled Path Tests on Windows.

> On Oct. 24, 2017, 6:32 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/tests/path_tests.cpp > > Lines 40-61 (original), 43-90 (patched) > > > > > > Instead of using an `#ifdef` here, we can probably just use

Re: Review Request 63257: Added a few test helpers for creating disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63257/#review189205 --- PASS: Mesos patch 63257 was successfully built and tested.

Re: Review Request 63253: Fixed DefaultExecutorTest for proper URI handling on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63253/#review189204 --- src/tests/default_executor_tests.cpp Lines 1650 (patched)

Re: Review Request 63253: Fixed DefaultExecutorTest for proper URI handling on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63253/#review189201 --- src/tests/default_executor_tests.cpp Lines 1764 (patched)

Re: Review Request 63253: Fixed DefaultExecutorTest for proper URI handling on Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63253/#review189194 --- PASS: Mesos patch 63253 was successfully built and tested.

Review Request 63295: Update glog-0.3.3.patch to build on ARM.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63295/ --- Review request for mesos. Repository: mesos Description --- glog has an

Re: Review Request 63294: Update glog patch (config.guess) to support ARM.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63294/#review189186 --- Bad review! Error: No reviewers specified. Please find a

Re: Review Request 63293: Update google-glog to 0.3.5.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63293/ --- (Updated Oct. 25, 2017, 12:28 p.m.) Review request for mesos. Bugs:

Review Request 63293: Update google-glog to 0.3.5.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63293/ --- Review request for mesos. Repository: mesos Description --- Version

Review Request 63294: Update glog patch (config.guess) to support ARM.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63294/ --- Review request for mesos. Repository: mesos Description ---

Re: Review Request 63292: Added lamdba::zip.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63292/#review189185 --- Patch looks great! Reviews applied: [63292] Passed command:

Re: Review Request 63292: Added lamdba::zip.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63292/#review189184 --- PASS: Mesos patch 63292 was successfully built and tested.

Review Request 63292: Added lamdba::zip.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63292/ --- Review request for mesos, Alexander Rojas and Vinod Kone. Repository: mesos