Re: Review Request 63353: Don't clear the executor ID of non-command executors on re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63353/#review189780 --- PASS: Mesos patch 63353 was successfully built and tested.

Re: Review Request 63447: Fixed bulleted list formatting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63447/#review189777 --- FAIL: Some Mesos tests failed. Failed command:

Re: Review Request 63331: Added documentation for the `network/ports` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63331/#review189776 --- PASS: Mesos patch 63331 was successfully built and tested.

Re: Review Request 62775: Added a test `ROOT_NoTransitionFromKillingToFinished`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62775/#review189774 --- LGTM, just two small comments: 1) The `TASK_STARTING` changes

Re: Review Request 63453: Patched concurrentqueue to check for libstdc++ instead of GCC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63453/#review189767 --- Ship it! Thanks! :) - Benjamin Mahler On Oct. 31, 2017,

Re: Review Request 63437: Slave heartbeat add message sender distinguish.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63437/#review189766 --- PASS: Mesos patch 63437 was successfully built and tested.

Re: Review Request 63455: Fixed Protobuf header dependency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63455/#review189765 --- Ship it! Ship It! - Benjamin Bannier On Oct. 31, 2017,

Review Request 63453: Patched concurrentqueue to check for libstdc++ instead of GCC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63453/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 63455: Fixed Protobuf header dependency.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63455/ --- Review request for mesos and Benjamin Bannier. Repository: mesos Description

Re: Review Request 63353: Don't clear the executor ID of non-command executors on re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63353/#review189761 --- Fix it, then Ship it! Can you split the fix and the test? We

Re: Review Request 62775: Added a test `ROOT_NoTransitionFromKillingToFinished`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62775/#review189764 --- Ship it! Can you update the testing section. Ran it in a loop

Re: Review Request 63420: Moved Linux namespace helpers into a source file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63420/#review189758 --- PASS: Mesos patch 63420 was successfully built and tested.

Re: Review Request 63447: Fixed bulleted list formatting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63447/#review189754 --- Patch looks great! Reviews applied: [63447] Passed command:

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63434/#review189750 --- PASS: Mesos patch 63434 was successfully built and tested.

Re: Review Request 63272: Windows: Added `os::get_job_info` to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63272/#review189740 --- Ship it! Ship It! - Jeff Coffler On Oct. 31, 2017, 5:51

Re: Review Request 63447: Fixed bulleted list formatting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63447/#review189739 --- Ship it! Ship It! - Jiang Yan Xu On Oct. 31, 2017, 10:48

Re: Review Request 63400: Fix bad links.

> On Oct. 30, 2017, 11:03 a.m., Andrew Schwartzmeyer wrote: > > docs/cmake.md > > Lines 245-251 (original), 245-250 (patched) > > > > > > This should make no difference, it's part of the base Markdown syntax > >

Re: Review Request 63400: Fix bad links.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63400/#review189737 --- Ship it! Ship It! - Andrew Schwartzmeyer On Oct. 30, 2017,

Re: Review Request 63272: Windows: Added `os::get_job_info` to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63272/ --- (Updated Oct. 31, 2017, 10:51 a.m.) Review request for mesos, Akash Gupta,

Review Request 63447: Fixed bulleted list formatting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63447/ --- Review request for mesos and Jiang Yan Xu. Repository: mesos Description

Re: Review Request 63331: Added documentation for the `network/ports` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63331/#review189735 --- Patch looks great! Reviews applied: [63331] Passed command:

Re: Review Request 63331: Added documentation for the `network/ports` isolator.

> On Oct. 31, 2017, 2:39 a.m., Qian Zhang wrote: > > docs/upgrades.md > > Lines 370 (patched) > > > > > > s/A new field, `limitation`, was added/A new field `limitation` was > > added/ This is correct as written.

Re: Review Request 63331: Added documentation for the `network/ports` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63331/ --- (Updated Oct. 31, 2017, 4:57 p.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 63419: Updated tests to use `createCallKill`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63419/#review189734 --- PASS: Mesos patch 63419 was successfully built and tested.

Re: Review Request 63437: Slave heartbeat add message sender distinguish.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63437/#review189722 --- Patch looks great! Reviews applied: [63437] Passed command:

Re: Review Request 63331: Added documentation for the `network/ports` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63331/#review189720 --- PASS: Mesos patch 63331 was successfully built and tested.

Re: Review Request 63423: Cleared the executor auth token after using it.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63423/#review189715 --- PASS: Mesos patch 63423 was successfully built and tested.

Re: Review Request 63420: Moved Linux namespace helpers into a source file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63420/#review189713 --- Patch looks great! Reviews applied: [63420] Passed command:

Re: Review Request 63400: Fix bad links.

> On Oct. 30, 2017, 6:03 p.m., Andrew Schwartzmeyer wrote: > > site/source/blog/2014-03-28-mesos-community-update-1.md > > Line 31 (original), 31 (patched) > > > > > > The `[lacking a while]` link is missing the

Re: Review Request 63400: Fix bad links.

> On Oct. 30, 2017, 6:03 p.m., Andrew Schwartzmeyer wrote: > > docs/cmake.md > > Lines 245-251 (original), 245-250 (patched) > > > > > > This should make no difference, it's part of the base Markdown syntax > > (as

Re: Review Request 63428: Updated XFS tests to handle the TASK_STARTING state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63428/#review189704 --- PASS: Mesos patch 63428 was successfully built and tested.

Re: Review Request 63428: Updated XFS tests to handle the TASK_STARTING state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63428/#review189702 --- Patch looks great! Reviews applied: [63428] Passed command:

Re: Review Request 63331: Added documentation for the `network/ports` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63331/#review189700 --- Fix it, then Ship it! LGTM! Can you also update CHANGELOG

Re: Review Request 63432: Updated the comment about slaves.removed in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63432/#review189698 --- PASS: Mesos patch 63432 was successfully built and tested.

Re: Review Request 63432: Updated the comment about slaves.removed in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63432/#review189696 --- Patch looks great! Reviews applied: [63432] Passed command:

Re: Review Request 63414: Added a helper to get the resoruce provider ID from an offer operation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63414/#review189694 --- FAIL: Failed to apply the dependent review: 59988. Failed

Re: Review Request 63434: Added IPv6 capabilities for TCP and HTTP healthchecks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63434/#review189693 --- Patch looks great! Reviews applied: [63434] Passed command: