Re: Review Request 65856: Added `--fetcher_stall_timeout` to abort stalled artifact fetching.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65856/#review198434 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 65842: Changed `os::spawn` to return `Option` instead of `int`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65842/#review198433 --- Patch looks great! Reviews applied: [65839, 65840, 65841, 65842]

Review Request 65856: Added `--fetcher_stall_timeout` to abort stalled artifact fetching.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65856/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-8620

Review Request 65855: Added the `stall_timeout` parameter to `net::download()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65855/ --- Review request for mesos and Gilbert Song. Bugs: MESOS-8620

Re: Review Request 59987: Added protobuf map support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59987/#review198429 --- Chun and I went over this together, so feel free to reach out to

Re: Review Request 65853: Updated createQuotaInfo helper to handle quota limit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65853/#review198432 --- PASS: Mesos patch 65853 was successfully built and tested.

Re: Review Request 65847: Fixed allocator test `QuotaAbsentFramework`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65847/#review198430 --- Patch looks great! Reviews applied: [65661, 65819, 65820, 65821,

Review Request 65853: Updated createQuotaInfo helper to handle quota limit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65853/ --- Review request for mesos, Michael Park and Meng Zhu. Repository: mesos

Review Request 65851: Disallow limit in /quota requests and SET_QUOTA calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65851/ --- Review request for mesos, Michael Park and Meng Zhu. Repository: mesos

Re: Review Request 65780: Removed an unnecessary argument from master::Call validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65780/ --- (Updated March 1, 2018, 2:31 a.m.) Review request for mesos, Michael Park and

Review Request 65852: Added a test to ensure /quota and SET_QUOTA disallow limit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65852/ --- Review request for mesos, Michael Park and Meng Zhu. Repository: mesos

Re: Review Request 65842: Changed `os::spawn` to return `Option` instead of `int`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65842/#review198424 --- Ditto, can you split this review per-project? I _highly_

Re: Review Request 65841: Changed `os::system` to return `Option` instead of `int`.

> On Feb. 28, 2018, 4:32 p.m., Andrew Schwartzmeyer wrote: > > Before I review this, it needs to be split for stout and mesos changes. (Otherwise I'll leave a bunch of comments on code that'll get deleted from this review ;) - Andrew

Re: Review Request 65841: Changed `os::system` to return `Option` instead of `int`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65841/#review198422 --- Before I review this, it needs to be split for stout and mesos

Re: Review Request 65840: Windows: Fixed remaining W* macros in `windows.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65840/#review198421 --- 3rdparty/stout/include/stout/windows.hpp Line 367 (original),

Re: Review Request 65839: Windows: Removed W* test-only macros in `windows.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65839/#review198420 --- Changes LGTM but this needs to be split into three commits as

Re: Review Request 65683: Updated discard handling in `Docker::inspect()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/ --- (Updated March 1, 2018, 12:07 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 65683: Updated discard handling in 'Docker::inspect()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/ --- (Updated Feb. 28, 2018, 11:48 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 65683: Updated discard handling in 'Docker::inspect()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/ --- (Updated Feb. 28, 2018, 11:49 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 65799: Ported mesos-master to Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65799/#review198418 --- src/master/main.cpp Lines 212 (patched)

Re: Review Request 65795: Adding warning to `apply-reviews.py` for previously submitted patches.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65795/#review198417 --- Fix it, then Ship it! Thanks for your contribution!

Re: Review Request 65759: Added inspect retries to the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65759/#review198414 --- Ship it! Ship It! - Greg Mann On Feb. 28, 2018, 6:05 p.m.,

Re: Review Request 65847: Fixed allocator test `QuotaAbsentFramework`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65847/#review198412 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 63368: Added MemoryProfiler class to Libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review198409 --- 3rdparty/libprocess/src/memory_profiler.cpp Lines 305 (patched)

Re: Review Request 63372: Added documentation for memory profiling.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review198404 --- docs/memory-profiling.md Lines 22 (patched)

Re: Review Request 65661: Updated comment and variables to decouple quota limit and guarantee.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65661/#review198410 --- Patch looks great! Reviews applied: [65661] Passed command:

Re: Review Request 65661: Updated comment and variables to decouple quota limit and guarantee.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65661/#review198407 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 65847: Fixed allocator test `QuotaAbsentFramework`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65847/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-8456

Review Request 65845: Fixed broken test `SlavesEndpointFullResources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65845/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-8456

Review Request 65844: Added `upgradeResource` to some resource parsing functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65844/ --- Review request for mesos, Benjamin Mahler and Michael Park. Repository: mesos

Review Request 65821: Made second resource allocation stage burst-able (below limit).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65821/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-8456

Review Request 65820: Added an utility to filter resources reserved by ancestor roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65820/ --- Review request for mesos, Benjamin Mahler and Michael Park. Repository: mesos

Review Request 65819: Enforced quota limit in the first resource allocation stage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65819/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-8456

Re: Review Request 65842: Changed `os::spawn` to return `Option` instead of `int`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65842/#review198403 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 63366: Added jemalloc release tarball and build rules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63366/ --- (Updated Feb. 28, 2018, 7:56 p.m.) Review request for mesos, Alexander

Re: Review Request 65462: Used the new 'route()' overload from libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65462/ --- (Updated Feb. 28, 2018, 7:56 p.m.) Review request for mesos, Alexander

Re: Review Request 65461: Provided new overload of 'ProcessBase::route()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65461/ --- (Updated Feb. 28, 2018, 7:55 p.m.) Review request for mesos, Alexander

Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65838/#review198402 --- Patch looks great! Reviews applied: [65838] Passed command:

Re: Review Request 65840: Windows: Fixed remaining W* macros in `windows.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65840/#review198400 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 65842: Changed `os::spawn` to return `Option` instead of `int`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65842/ --- Review request for mesos, Andrew Schwartzmeyer, Joseph Wu, and Michael Park.

Review Request 65841: Changed `os::system` to return `Option` instead of `int`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65841/ --- Review request for mesos, Andrew Schwartzmeyer, Joseph Wu, and Michael Park.

Review Request 65840: Windows: Fixed remaining W* macros in `windows.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65840/ --- Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. Repository:

Review Request 65839: Windows: Removed W* test-only macros in `windows.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65839/ --- Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. Repository:

Re: Review Request 65759: Added inspect retries to the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65759/ --- (Updated Feb. 28, 2018, 6:05 p.m.) Review request for mesos, Alexander

Re: Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65838/#review198397 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 65833: Displayed resource provider resources in GET_AGENTS response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65833/#review198394 --- Patch looks great! Reviews applied: [65587, 65588, 65589, 65590,

Re: Review Request 65759: Added inspect retries to the Docker executor.

> On Feb. 28, 2018, 10:04 a.m., Greg Mann wrote: > > src/docker/executor.cpp > > Lines 242-247 (patched) > > > > > > Doesn't this render the `onFailed` callback registered on L357 useless? > > i.e., the `inspect`

Re: Review Request 65759: Added inspect retries to the Docker executor.

> On Feb. 28, 2018, 10:04 a.m., Greg Mann wrote: > > src/docker/executor.cpp > > Lines 242-247 (patched) > > > > > > Doesn't this render the `onFailed` callback registered on L357 useless? > > i.e., the `inspect`

Review Request 65838: Updated validation of 'RAW' and 'BLOCK' disk resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65838/ --- Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.

Re: Review Request 65758: Fix flakyness in MasterTests.RegistryUpdateAfterReconfiguration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65758/#review198390 --- Ship it! Ship It! - Alexander Rukletsov On Feb. 22, 2018,

Re: Review Request 65836: WIP: Random source in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65836/#review198389 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 65836: WIP: Random source in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65836/#review198388 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 65833: Displayed resource provider resources in GET_AGENTS response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65833/#review198387 --- PASS: Mesos patch 65833 was successfully built and tested.

Review Request 65834: WIP: Random source in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65834/ --- Review request for mesos. Repository: mesos Description --- WIP: Random

Review Request 65835: WIP: Random source in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65835/ --- Review request for mesos. Repository: mesos Description --- WIP: Random

Review Request 65836: WIP: Random source in mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65836/ --- Review request for mesos. Repository: mesos Description --- WIP: Random

Re: Review Request 65683: Updated discard handling in 'Docker::inspect()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/#review198384 --- Ship it! Ship It! - Andrei Budnik On Feb. 28, 2018, 8:49

Review Request 65832: Displayed resource provider resources in GET_RESOURCE_PROVIDER response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65832/ --- Review request for mesos, Jie Yu and Jan Schlicht. Bugs: MESOS-8388

Review Request 65833: Displayed resource provider resources in GET_AGENTS response.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65833/ --- Review request for mesos, Jie Yu and Jan Schlicht. Bugs: MESOS-8388

Re: Review Request 65759: Added inspect retries to the Docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65759/#review198382 --- src/docker/executor.cpp Lines 242-247 (patched)

Re: Review Request 65713: Handled hanging docker `stop`, `inspect` commands in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65713/#review198381 --- src/docker/executor.cpp Lines 516-517 (patched)

Re: Review Request 65713: Handled hanging docker `stop`, `inspect` commands in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65713/#review198380 --- Fix it, then Ship it! src/docker/executor.cpp Lines 516

Re: Review Request 65683: Updated discard handling in 'Docker::inspect()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/ --- (Updated Feb. 28, 2018, 8:49 a.m.) Review request for mesos, Andrei Budnik,